[INFO] fetching crate zfs-cmd-api 0.2.0... [INFO] checking zfs-cmd-api-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zfs-cmd-api 0.2.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate zfs-cmd-api 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zfs-cmd-api 0.2.0 [INFO] finished tweaking crates.io crate zfs-cmd-api 0.2.0 [INFO] tweaked toml for crates.io crate zfs-cmd-api 0.2.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding enumflags2 v0.6.4 (latest: v0.7.10) [INFO] [stderr] Adding enumflags2_derive v0.6.4 (latest: v0.7.10) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding shell-words v0.1.0 (latest: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2ae0bf51c8f2ac8721eaf0b7c5a1ecbb43c9599eacafd37eb6f15481f4d24897 [INFO] running `Command { std: "docker" "start" "-a" "2ae0bf51c8f2ac8721eaf0b7c5a1ecbb43c9599eacafd37eb6f15481f4d24897", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2ae0bf51c8f2ac8721eaf0b7c5a1ecbb43c9599eacafd37eb6f15481f4d24897", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ae0bf51c8f2ac8721eaf0b7c5a1ecbb43c9599eacafd37eb6f15481f4d24897", kill_on_drop: false }` [INFO] [stdout] 2ae0bf51c8f2ac8721eaf0b7c5a1ecbb43c9599eacafd37eb6f15481f4d24897 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6951ef3f64d8c8ee16739ab3847362ed0b5c12e57c16f69b7379657497e40977 [INFO] running `Command { std: "docker" "start" "-a" "6951ef3f64d8c8ee16739ab3847362ed0b5c12e57c16f69b7379657497e40977", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking shell-words v0.1.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking fmt-extra v0.2.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling enumflags2_derive v0.6.4 [INFO] [stderr] Checking enumflags2 v0.6.4 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking zfs-cmd-api v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `status` and `cmd` are never read [INFO] [stdout] --> src/lib.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct CmdInfo { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 30 | status: process::ExitStatus, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 31 | stderr: String, [INFO] [stdout] 32 | cmd: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CmdInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:557:12 [INFO] [stdout] | [INFO] [stdout] 522 | let mut cmd = self.cmd(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 557 | Ok(ZfsSend { [INFO] [stdout] | ____________^ [INFO] [stdout] 558 | | child: cmd [INFO] [stdout] 559 | | .stdout(std::process::Stdio::piped()) [INFO] [stdout] 560 | | .spawn()? [INFO] [stdout] 561 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:630:12 [INFO] [stdout] | [INFO] [stdout] 577 | let mut cmd = self.cmd(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 630 | Ok(ZfsSend { [INFO] [stdout] | ____________^ [INFO] [stdout] 631 | | child: cmd [INFO] [stdout] 632 | | .stdout(std::process::Stdio::piped()) [INFO] [stdout] 633 | | .spawn()? [INFO] [stdout] 634 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:693:12 [INFO] [stdout] | [INFO] [stdout] 648 | let mut cmd = self.cmd(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 693 | Ok(ZfsRecv { [INFO] [stdout] | ____________^ [INFO] [stdout] 694 | | child: cmd [INFO] [stdout] 695 | | .stdin(std::process::Stdio::piped()) [INFO] [stdout] 696 | | .spawn()?, [INFO] [stdout] 697 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zfs-cmd-api` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `status` and `cmd` are never read [INFO] [stdout] --> src/lib.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct CmdInfo { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 30 | status: process::ExitStatus, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 31 | stderr: String, [INFO] [stdout] 32 | cmd: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CmdInfo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:557:12 [INFO] [stdout] | [INFO] [stdout] 522 | let mut cmd = self.cmd(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 557 | Ok(ZfsSend { [INFO] [stdout] | ____________^ [INFO] [stdout] 558 | | child: cmd [INFO] [stdout] 559 | | .stdout(std::process::Stdio::piped()) [INFO] [stdout] 560 | | .spawn()? [INFO] [stdout] 561 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:630:12 [INFO] [stdout] | [INFO] [stdout] 577 | let mut cmd = self.cmd(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 630 | Ok(ZfsSend { [INFO] [stdout] | ____________^ [INFO] [stdout] 631 | | child: cmd [INFO] [stdout] 632 | | .stdout(std::process::Stdio::piped()) [INFO] [stdout] 633 | | .spawn()? [INFO] [stdout] 634 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:693:12 [INFO] [stdout] | [INFO] [stdout] 648 | let mut cmd = self.cmd(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 693 | Ok(ZfsRecv { [INFO] [stdout] | ____________^ [INFO] [stdout] 694 | | child: cmd [INFO] [stdout] 695 | | .stdin(std::process::Stdio::piped()) [INFO] [stdout] 696 | | .spawn()?, [INFO] [stdout] 697 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zfs-cmd-api` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "6951ef3f64d8c8ee16739ab3847362ed0b5c12e57c16f69b7379657497e40977", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6951ef3f64d8c8ee16739ab3847362ed0b5c12e57c16f69b7379657497e40977", kill_on_drop: false }` [INFO] [stdout] 6951ef3f64d8c8ee16739ab3847362ed0b5c12e57c16f69b7379657497e40977