[INFO] fetching crate zenoh-flow-commons 0.6.0-alpha... [INFO] checking zenoh-flow-commons-0.6.0-alpha against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zenoh-flow-commons 0.6.0-alpha into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate zenoh-flow-commons 0.6.0-alpha on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zenoh-flow-commons 0.6.0-alpha [INFO] finished tweaking crates.io crate zenoh-flow-commons 0.6.0-alpha [INFO] tweaked toml for crates.io crate zenoh-flow-commons 0.6.0-alpha written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 71 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding handlebars v5.1.2 (latest: v6.0.0) [INFO] [stderr] Adding hashbrown v0.13.2 (latest: v0.14.5) [INFO] [stderr] Adding keyed-set v0.4.5 (latest: v1.0.0) [INFO] [stderr] Adding uhlc v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding zenoh-buffers v0.10.1-rc (latest: v0.11.0) [INFO] [stderr] Adding zenoh-collections v0.10.1-rc (latest: v0.11.0) [INFO] [stderr] Adding zenoh-keyexpr v0.10.1-rc (latest: v0.11.0) [INFO] [stderr] Adding zenoh-protocol v0.10.1-rc (latest: v0.11.0) [INFO] [stderr] Adding zenoh-result v0.10.1-rc (latest: v0.11.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c898a731a12a91ad380b7bea6301c40aaf6dbe210bb161ba4251531fcb999439 [INFO] running `Command { std: "docker" "start" "-a" "c898a731a12a91ad380b7bea6301c40aaf6dbe210bb161ba4251531fcb999439", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c898a731a12a91ad380b7bea6301c40aaf6dbe210bb161ba4251531fcb999439", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c898a731a12a91ad380b7bea6301c40aaf6dbe210bb161ba4251531fcb999439", kill_on_drop: false }` [INFO] [stdout] c898a731a12a91ad380b7bea6301c40aaf6dbe210bb161ba4251531fcb999439 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4396e4c2374f4fe0b88e93bef9e61d0d0e4ae64320cd006020d9f8db6f1aacee [INFO] running `Command { std: "docker" "start" "-a" "4396e4c2374f4fe0b88e93bef9e61d0d0e4ae64320cd006020d9f8db6f1aacee", kill_on_drop: false }` [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling schemars v0.8.21 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking zenoh-collections v0.10.1-rc [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking token-cell v1.5.0 [INFO] [stderr] Checking zenoh-result v0.10.1-rc [INFO] [stderr] Compiling const_format_proc_macros v0.2.32 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Checking zenoh-buffers v0.10.1-rc [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking const_format v0.2.32 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling schemars_derive v0.8.21 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking keyed-set v0.4.5 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking uhlc v0.6.3 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking handlebars v5.1.2 [INFO] [stderr] Checking zenoh-keyexpr v0.10.1-rc [INFO] [stderr] Checking zenoh-protocol v0.10.1-rc [INFO] [stderr] Checking zenoh-flow-commons v0.6.0-alpha (/opt/rustwide/workdir) [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/deserialize.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 131 | pub struct TestStruct { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 132 | pub id: NodeId, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `TestStruct` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 126 | let global = Configuration(Arc::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let local = Configuration(Arc::new(json!({ "a": { "not-nested": false }, "c": 1 }))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Configuration::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/configuration.rs:148:13 [INFO] [stdout] | [INFO] [stdout] 126 | let global = Configuration(Arc::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let local = Configuration(Arc::new(json!({ "a": { "not-nested": false }, "c": 1 }))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | Configuration::default().merge_overwrite(Configuration::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize.rs:69:8 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn deserialize_id<'de, D>(deserializer: D) -> std::result::Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(id.into()) [INFO] [stdout] | ^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:115:8 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn try_parse_from_file(path: impl AsRef, vars: Vars) -> Result<(N, Vars)> [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let mut handlebars = Handlebars::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 116 | | (deserializer::(&path_buf))?(&rendered_descriptor) [INFO] [stdout] 117 | | .context(format!("Failed to deserialize {}", &path_buf.display()))?, [INFO] [stdout] 118 | | merged_vars, [INFO] [stdout] 119 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vars.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 90 | fn from(value: [(T, U); N]) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | / value [INFO] [stdout] 94 | | .into_iter() [INFO] [stdout] 95 | | .map(|(k, v)| (k.as_ref().into(), v.as_ref().into())) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vars.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 103 | fn from(value: Vec<(T, U)>) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | / value [INFO] [stdout] 107 | | .into_iter() [INFO] [stdout] 108 | | .map(|(k, v)| (k.as_ref().into(), v.as_ref().into())) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zenoh-flow-commons` (lib test) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deserialize.rs:69:8 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn deserialize_id<'de, D>(deserializer: D) -> std::result::Result, D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(id.into()) [INFO] [stdout] | ^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:115:8 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn try_parse_from_file(path: impl AsRef, vars: Vars) -> Result<(N, Vars)> [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let mut handlebars = Handlebars::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 116 | | (deserializer::(&path_buf))?(&rendered_descriptor) [INFO] [stdout] 117 | | .context(format!("Failed to deserialize {}", &path_buf.display()))?, [INFO] [stdout] 118 | | merged_vars, [INFO] [stdout] 119 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vars.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 90 | fn from(value: [(T, U); N]) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | / value [INFO] [stdout] 94 | | .into_iter() [INFO] [stdout] 95 | | .map(|(k, v)| (k.as_ref().into(), v.as_ref().into())) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vars.rs:106:17 [INFO] [stdout] | [INFO] [stdout] 103 | fn from(value: Vec<(T, U)>) -> Self { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | / value [INFO] [stdout] 107 | | .into_iter() [INFO] [stdout] 108 | | .map(|(k, v)| (k.as_ref().into(), v.as_ref().into())) [INFO] [stdout] | |_________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zenoh-flow-commons` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "4396e4c2374f4fe0b88e93bef9e61d0d0e4ae64320cd006020d9f8db6f1aacee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4396e4c2374f4fe0b88e93bef9e61d0d0e4ae64320cd006020d9f8db6f1aacee", kill_on_drop: false }` [INFO] [stdout] 4396e4c2374f4fe0b88e93bef9e61d0d0e4ae64320cd006020d9f8db6f1aacee