[INFO] fetching crate zebra-test 1.0.0-beta.39... [INFO] checking zebra-test-1.0.0-beta.39 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zebra-test 1.0.0-beta.39 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate zebra-test 1.0.0-beta.39 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zebra-test 1.0.0-beta.39 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate zebra-test 1.0.0-beta.39 [INFO] tweaked toml for crates.io crate zebra-test 1.0.0-beta.39 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 134 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.21.0 (latest: v0.24.1) [INFO] [stderr] Adding backtrace v0.3.71 (latest: v0.3.73) [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding gimli v0.28.1 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding object v0.32.2 (latest: v0.36.4) [INFO] [stderr] Adding owo-colors v3.5.0 (latest: v4.0.0) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0f5af49d587ca99af1de8a66ec12e22aaa14d8b89baa313ee58bec947e59de8c [INFO] running `Command { std: "docker" "start" "-a" "0f5af49d587ca99af1de8a66ec12e22aaa14d8b89baa313ee58bec947e59de8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0f5af49d587ca99af1de8a66ec12e22aaa14d8b89baa313ee58bec947e59de8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f5af49d587ca99af1de8a66ec12e22aaa14d8b89baa313ee58bec947e59de8c", kill_on_drop: false }` [INFO] [stdout] 0f5af49d587ca99af1de8a66ec12e22aaa14d8b89baa313ee58bec947e59de8c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3fa042a58744f0210fd4f361e2df7023e73a19b020d17fa9caae7202f4ea9f80 [INFO] running `Command { std: "docker" "start" "-a" "3fa042a58744f0210fd4f361e2df7023e73a19b020d17fa9caae7202f4ea9f80", kill_on_drop: false }` [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling spandoc-attribute v0.1.1 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Checking color-eyre v0.6.3 [INFO] [stderr] Checking spandoc v0.2.2 [INFO] [stderr] Checking zebra-test v1.0.0-beta.39 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/lib.rs:185:26 [INFO] [stdout] | [INFO] [stdout] 185 | pi: &std::panic::PanicInfo<'_>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/lib.rs:185:26 [INFO] [stdout] | [INFO] [stdout] 185 | pi: &std::panic::PanicInfo<'_>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 91 | .unwrap_or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | // These filters apply when RUST_LOG isn't set [INFO] [stdout] 93 | / EnvFilter::try_new("warn") [INFO] [stdout] 94 | | .unwrap() [INFO] [stdout] 95 | | .add_directive("zebra_consensus=error".parse().unwrap()) [INFO] [stdout] 96 | | .add_directive("zebra_network=error".parse().unwrap()) [INFO] [stdout] 97 | | .add_directive("zebra_state=error".parse().unwrap()) [INFO] [stdout] 98 | | .add_directive("zebrad=error".parse().unwrap()) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:99:36 [INFO] [stdout] | [INFO] [stdout] 91 | .unwrap_or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | .add_directive("tor_circmgr=error".parse().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 169 | let drop_guard = init(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | / tokio::runtime::Builder::new_current_thread() [INFO] [stdout] 173 | | .enable_all() [INFO] [stdout] 174 | | .build() [INFO] [stdout] 175 | | .expect("Failed to create Tokio runtime"), [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 95 | fn spawn2(&mut self, dir: T, command_path: impl ToString) -> Result, Report> { [INFO] [stdout] | ------ --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let command_and_args = format!("{self:?}"); [INFO] [stdout] 97 | let child = self.spawn(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | [INFO] [stdout] 99 | let child = child [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Ok(TestChild { [INFO] [stdout] | ____________^ [INFO] [stdout] 104 | | dir: Some(dir), [INFO] [stdout] 105 | | cmd: command_and_args, [INFO] [stdout] 106 | | command_path: command_path.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 114 | | bypass_test_capture: false, [INFO] [stdout] 115 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 140 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | command_path: &str, [INFO] [stdout] 142 | args: Arguments, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | ) -> Result> { [INFO] [stdout] 144 | let mut cmd = test_cmd(command_path, self.as_ref())?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | [INFO] [stdout] 146 | Ok(cmd [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | .args(args.into_arguments()) [INFO] [stdout] 148 | | .stdout(Stdio::piped()) [INFO] [stdout] 149 | | .stderr(Stdio::piped()) [INFO] [stdout] 150 | | .spawn2(self, command_path) [INFO] [stdout] 151 | | .unwrap()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:480:9 [INFO] [stdout] | [INFO] [stdout] 459 | reader: R, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 464 | let failure_regexes = self.failure_regexes.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 465 | let ignore_regexes = self.ignore_regexes.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 469 | let reader = BufReader::new(reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | let lines = BufRead::lines(reader).map(move |line| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 480 | Box::new(lines) as _ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:761:12 [INFO] [stdout] | [INFO] [stdout] 724 | pub fn wait_with_output(mut self) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 725 | let child = match self.child.take() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 726 | Some(child) => child, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 731 | return Err(eyre!( [INFO] [stdout] | ____________________________- [INFO] [stdout] 732 | | "test child was already taken\n\ [INFO] [stdout] 733 | | wait_with_output can only be called once for each child process", [INFO] [stdout] 734 | | )) [INFO] [stdout] | |_________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 755 | /// SPANDOC: waiting for command to exit [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | _________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | | [INFO] [stdout] 756 | | let output = child.wait_with_output().with_section({ [INFO] [stdout] 757 | | let cmd = self.cmd.clone(); [INFO] [stdout] 758 | | || cmd.header("Command:") [INFO] [stdout] 759 | | })?; [INFO] [stdout] | | - [INFO] [stdout] | |____________| [INFO] [stdout] | |____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 760 | [INFO] [stdout] 761 | Ok(TestOutput { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] 762 | | output, [INFO] [stdout] 763 | | cmd: self.cmd.clone(), [INFO] [stdout] 764 | | dir: self.dir.take(), [INFO] [stdout] 765 | | }) [INFO] [stdout] | |_________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:881:21 [INFO] [stdout] | [INFO] [stdout] 878 | .map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 881 | / err.with_section(|| { [INFO] [stdout] 882 | | format!("{unmatched_regexes:#?}").header("Unmatched regexes:") [INFO] [stdout] 883 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:926:21 [INFO] [stdout] | [INFO] [stdout] 923 | .map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 926 | / err.with_section(|| { [INFO] [stdout] 927 | | format!("{unmatched_regexes:#?}").header("Unmatched regexes:") [INFO] [stdout] 928 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:1490:9 [INFO] [stdout] | [INFO] [stdout] 1489 | fn context_from(self, source: C) -> Self::Return { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1490 | self.map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:1491:22 [INFO] [stdout] | [INFO] [stdout] 1489 | fn context_from(self, source: C) -> Self::Return { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1490 | self.map_err(|e| e.into()) [INFO] [stdout] 1491 | .map_err(|report| report.context_from(source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:1501:9 [INFO] [stdout] | [INFO] [stdout] 1498 | fn context_from(self, source: &TestStatus) -> Self::Return { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1501 | self.with_section(command).context_from(&source.status) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:1553:9 [INFO] [stdout] | [INFO] [stdout] 1509 | fn context_from(mut self, source: &mut TestChild) -> Self::Return { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1553 | self.section(stdout_buf.header(format!("{} Unread Stdout:", source.command_path))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:1562:9 [INFO] [stdout] | [INFO] [stdout] 1561 | fn context_from(self, source: &TestOutput) -> Self::Return { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1562 | self.with_section(|| source.cmd.clone().header("Command:")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:1583:9 [INFO] [stdout] | [INFO] [stdout] 1570 | fn context_from(self, source: &Output) -> Self::Return { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1583 | / self.context_from(&source.status) [INFO] [stdout] 1584 | | .with_section(stdout) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock_service.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 161 | fn call(&mut self, request: Request) -> Self::Future { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | let (response_sender, response_receiver) = ResponseSender::new(request); [INFO] [stdout] | --------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let proxy_item = Arc::new(Mutex::new(Some(response_sender))); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | / response_receiver [INFO] [stdout] 168 | | .map(|response| { [INFO] [stdout] 169 | | response.expect("A response was not sent by the `MockService` for a request") [INFO] [stdout] 170 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock_service.rs:723:13 [INFO] [stdout] | [INFO] [stdout] 719 | fn new(request: Request) -> (Self, oneshot::Receiver>) { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 720 | let (response_sender, response_receiver) = oneshot::channel(); [INFO] [stdout] | --------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 723 | / ResponseSender { [INFO] [stdout] 724 | | request, [INFO] [stdout] 725 | | response_sender, [INFO] [stdout] 726 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transcript.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 42 | fn check(&self, e: BoxError) -> Result<(), Report> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | / match self { [INFO] [stdout] 44 | | ExpectedTranscriptError::Any => Ok(()), [INFO] [stdout] 45 | | ExpectedTranscriptError::Exact(checker) => checker(Some(e)), [INFO] [stdout] 46 | | } [INFO] [stdout] 47 | | .map_err(ErrorCheckerError) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transcript.rs:82:23 [INFO] [stdout] | [INFO] [stdout] 80 | fn from(messages: I) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Self { [INFO] [stdout] 82 | messages: messages.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transcript.rs:145:58 [INFO] [stdout] | [INFO] [stdout] 143 | (Err(e), Ok(expected_rsp)) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | Err(eyre!("received an error when a response was expected")) [INFO] [stdout] 145 | .with_error(|| ErrorCheckerError(e.into())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zebra-test` (lib) due to 21 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 91 | .unwrap_or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | // These filters apply when RUST_LOG isn't set [INFO] [stdout] 93 | / EnvFilter::try_new("warn") [INFO] [stdout] 94 | | .unwrap() [INFO] [stdout] 95 | | .add_directive("zebra_consensus=error".parse().unwrap()) [INFO] [stdout] 96 | | .add_directive("zebra_network=error".parse().unwrap()) [INFO] [stdout] 97 | | .add_directive("zebra_state=error".parse().unwrap()) [INFO] [stdout] 98 | | .add_directive("zebrad=error".parse().unwrap()) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:99:36 [INFO] [stdout] | [INFO] [stdout] 91 | .unwrap_or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | .add_directive("tor_circmgr=error".parse().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 169 | let drop_guard = init(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | / tokio::runtime::Builder::new_current_thread() [INFO] [stdout] 173 | | .enable_all() [INFO] [stdout] 174 | | .build() [INFO] [stdout] 175 | | .expect("Failed to create Tokio runtime"), [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 95 | fn spawn2(&mut self, dir: T, command_path: impl ToString) -> Result, Report> { [INFO] [stdout] | ------ --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let command_and_args = format!("{self:?}"); [INFO] [stdout] 97 | let child = self.spawn(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | [INFO] [stdout] 99 | let child = child [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Ok(TestChild { [INFO] [stdout] | ____________^ [INFO] [stdout] 104 | | dir: Some(dir), [INFO] [stdout] 105 | | cmd: command_and_args, [INFO] [stdout] 106 | | command_path: command_path.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 114 | | bypass_test_capture: false, [INFO] [stdout] 115 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 140 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | command_path: &str, [INFO] [stdout] 142 | args: Arguments, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | ) -> Result> { [INFO] [stdout] 144 | let mut cmd = test_cmd(command_path, self.as_ref())?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | [INFO] [stdout] 146 | Ok(cmd [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | .args(args.into_arguments()) [INFO] [stdout] 148 | | .stdout(Stdio::piped()) [INFO] [stdout] 149 | | .stderr(Stdio::piped()) [INFO] [stdout] 150 | | .spawn2(self, command_path) [INFO] [stdout] 151 | | .unwrap()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:480:9 [INFO] [stdout] | [INFO] [stdout] 459 | reader: R, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 464 | let failure_regexes = self.failure_regexes.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 465 | let ignore_regexes = self.ignore_regexes.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 469 | let reader = BufReader::new(reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 470 | let lines = BufRead::lines(reader).map(move |line| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 480 | Box::new(lines) as _ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:761:12 [INFO] [stdout] | [INFO] [stdout] 724 | pub fn wait_with_output(mut self) -> Result> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 725 | let child = match self.child.take() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 726 | Some(child) => child, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 731 | return Err(eyre!( [INFO] [stdout] | ____________________________- [INFO] [stdout] 732 | | "test child was already taken\n\ [INFO] [stdout] 733 | | wait_with_output can only be called once for each child process", [INFO] [stdout] 734 | | )) [INFO] [stdout] | |_________________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 755 | /// SPANDOC: waiting for command to exit [INFO] [stdout] | ---------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | _________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | | [INFO] [stdout] 756 | | let output = child.wait_with_output().with_section({ [INFO] [stdout] 757 | | let cmd = self.cmd.clone(); [INFO] [stdout] 758 | | || cmd.header("Command:") [INFO] [stdout] 759 | | })?; [INFO] [stdout] | | - [INFO] [stdout] | |____________| [INFO] [stdout] | |____________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 760 | [INFO] [stdout] 761 | Ok(TestOutput { [INFO] [stdout] | ____________^ [INFO] [stdout] | |____________| [INFO] [stdout] 762 | | output, [INFO] [stdout] 763 | | cmd: self.cmd.clone(), [INFO] [stdout] 764 | | dir: self.dir.take(), [INFO] [stdout] 765 | | }) [INFO] [stdout] | |_________^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:881:21 [INFO] [stdout] | [INFO] [stdout] 878 | .map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 881 | / err.with_section(|| { [INFO] [stdout] 882 | | format!("{unmatched_regexes:#?}").header("Unmatched regexes:") [INFO] [stdout] 883 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:926:21 [INFO] [stdout] | [INFO] [stdout] 923 | .map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 926 | / err.with_section(|| { [INFO] [stdout] 927 | | format!("{unmatched_regexes:#?}").header("Unmatched regexes:") [INFO] [stdout] 928 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:1490:9 [INFO] [stdout] | [INFO] [stdout] 1489 | fn context_from(self, source: C) -> Self::Return { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1490 | self.map_err(|e| e.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:1491:22 [INFO] [stdout] | [INFO] [stdout] 1489 | fn context_from(self, source: C) -> Self::Return { [INFO] [stdout] | ---- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1490 | self.map_err(|e| e.into()) [INFO] [stdout] 1491 | .map_err(|report| report.context_from(source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:1501:9 [INFO] [stdout] | [INFO] [stdout] 1498 | fn context_from(self, source: &TestStatus) -> Self::Return { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1501 | self.with_section(command).context_from(&source.status) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:1553:9 [INFO] [stdout] | [INFO] [stdout] 1509 | fn context_from(mut self, source: &mut TestChild) -> Self::Return { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1553 | self.section(stdout_buf.header(format!("{} Unread Stdout:", source.command_path))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:1562:9 [INFO] [stdout] | [INFO] [stdout] 1561 | fn context_from(self, source: &TestOutput) -> Self::Return { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1562 | self.with_section(|| source.cmd.clone().header("Command:")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:1583:9 [INFO] [stdout] | [INFO] [stdout] 1570 | fn context_from(self, source: &Output) -> Self::Return { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1583 | / self.context_from(&source.status) [INFO] [stdout] 1584 | | .with_section(stdout) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/arguments/tests.rs:177:30 [INFO] [stdout] | [INFO] [stdout] 177 | .prop_map(|keys| keys.into_iter().collect::>()) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock_service.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 161 | fn call(&mut self, request: Request) -> Self::Future { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | let (response_sender, response_receiver) = ResponseSender::new(request); [INFO] [stdout] | --------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let proxy_item = Arc::new(Mutex::new(Some(response_sender))); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | / response_receiver [INFO] [stdout] 168 | | .map(|response| { [INFO] [stdout] 169 | | response.expect("A response was not sent by the `MockService` for a request") [INFO] [stdout] 170 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mock_service.rs:723:13 [INFO] [stdout] | [INFO] [stdout] 719 | fn new(request: Request) -> (Self, oneshot::Receiver>) { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 720 | let (response_sender, response_receiver) = oneshot::channel(); [INFO] [stdout] | --------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 723 | / ResponseSender { [INFO] [stdout] 724 | | request, [INFO] [stdout] 725 | | response_sender, [INFO] [stdout] 726 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transcript.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 42 | fn check(&self, e: BoxError) -> Result<(), Report> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | / match self { [INFO] [stdout] 44 | | ExpectedTranscriptError::Any => Ok(()), [INFO] [stdout] 45 | | ExpectedTranscriptError::Exact(checker) => checker(Some(e)), [INFO] [stdout] 46 | | } [INFO] [stdout] 47 | | .map_err(ErrorCheckerError) [INFO] [stdout] | |___________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transcript.rs:82:23 [INFO] [stdout] | [INFO] [stdout] 80 | fn from(messages: I) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Self { [INFO] [stdout] 82 | messages: messages.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transcript.rs:145:58 [INFO] [stdout] | [INFO] [stdout] 143 | (Err(e), Ok(expected_rsp)) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | Err(eyre!("received an error when a response was expected")) [INFO] [stdout] 145 | .with_error(|| ErrorCheckerError(e.into())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zebra-test` (lib test) due to 22 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3fa042a58744f0210fd4f361e2df7023e73a19b020d17fa9caae7202f4ea9f80", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3fa042a58744f0210fd4f361e2df7023e73a19b020d17fa9caae7202f4ea9f80", kill_on_drop: false }` [INFO] [stdout] 3fa042a58744f0210fd4f361e2df7023e73a19b020d17fa9caae7202f4ea9f80