[INFO] fetching crate zcash_proofs 0.17.0... [INFO] checking zcash_proofs-0.17.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zcash_proofs 0.17.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate zcash_proofs 0.17.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zcash_proofs 0.17.0 [INFO] finished tweaking crates.io crate zcash_proofs 0.17.0 [INFO] tweaked toml for crates.io crate zcash_proofs 0.17.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 142 packages to latest compatible versions [INFO] [stderr] Adding bech32 v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding nonempty v0.7.0 (latest: v0.10.0) [INFO] [stderr] Adding radium v0.7.0 (latest: v1.1.0) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki-roots v0.25.4 (latest: v0.26.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding wyz v0.5.1 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d968a5b9f2a9da61c56aac67775c1853c284c7875610c1c366a848a70590591e [INFO] running `Command { std: "docker" "start" "-a" "d968a5b9f2a9da61c56aac67775c1853c284c7875610c1c366a848a70590591e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d968a5b9f2a9da61c56aac67775c1853c284c7875610c1c366a848a70590591e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d968a5b9f2a9da61c56aac67775c1853c284c7875610c1c366a848a70590591e", kill_on_drop: false }` [INFO] [stdout] d968a5b9f2a9da61c56aac67775c1853c284c7875610c1c366a848a70590591e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6cfa23d4c6432b5764189578bdec0c48d788318f1c2d90fdde4ea40ef9b0a4db [INFO] running `Command { std: "docker" "start" "-a" "6cfa23d4c6432b5764189578bdec0c48d788318f1c2d90fdde4ea40ef9b0a4db", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking nonempty v0.7.0 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking blake2b_simd v1.0.2 [INFO] [stderr] Checking memuse v0.2.1 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking halo2_legacy_pdqsort v0.1.0 [INFO] [stderr] Checking uint v0.9.5 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking zcash_spec v0.1.0 [INFO] [stderr] Checking zip32 v0.1.1 [INFO] [stderr] Checking incrementalmerkletree v0.6.0 [INFO] [stderr] Checking blake2s_simd v1.0.2 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking bs58 v0.5.1 [INFO] [stderr] Checking f4jumble v0.1.0 [INFO] [stderr] Checking zcash_encoding v0.2.1 [INFO] [stderr] Compiling document-features v0.2.10 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Checking equihash v0.2.0 [INFO] [stderr] Checking known-folders v1.2.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking zcash_protocol v0.3.0 [INFO] [stderr] Checking zcash_address v0.5.0 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking pairing v0.23.0 [INFO] [stderr] Checking bls12_381 v0.8.0 [INFO] [stderr] Checking bellman v0.14.0 [INFO] [stderr] Checking jubjub v0.10.0 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling visibility v0.1.1 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking fpe v0.6.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking zcash_note_encryption v0.4.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking pasta_curves v0.5.1 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking halo2_proofs v0.3.0 [INFO] [stderr] Checking reddsa v0.5.1 [INFO] [stderr] Checking redjubjub v0.7.0 [INFO] [stderr] Checking sapling-crypto v0.2.0 [INFO] [stderr] Checking halo2_gadgets v0.3.0 [INFO] [stderr] Checking orchard v0.9.0 [INFO] [stderr] Checking zcash_primitives v0.17.0 [INFO] [stderr] Checking zcash_proofs v0.17.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:342:9 [INFO] [stdout] | [INFO] [stdout] 336 | let spend_fs = File::open(spend_path).expect("couldn't load Sapling spend parameters file"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let output_fs = File::open(output_path).expect("couldn't load Sapling output parameters file"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | let sprout_fs = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | BufReader::with_capacity(1024 * 1024, spend_fs), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:343:9 [INFO] [stdout] | [INFO] [stdout] 336 | let spend_fs = File::open(spend_path).expect("couldn't load Sapling spend parameters file"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let output_fs = File::open(output_path).expect("couldn't load Sapling output parameters file"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | let sprout_fs = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | BufReader::with_capacity(1024 * 1024, output_fs), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:344:9 [INFO] [stdout] | [INFO] [stdout] 336 | let spend_fs = File::open(spend_path).expect("couldn't load Sapling spend parameters file"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let output_fs = File::open(output_path).expect("couldn't load Sapling output parameters file"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | let sprout_fs = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | sprout_fs.map(|fs| BufReader::with_capacity(1024 * 1024, fs)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:339:29 [INFO] [stdout] | [INFO] [stdout] 339 | sprout_path.map(|p| File::open(p).expect("couldn't load Sprout groth16 parameters file")); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit/sprout/mod.rs:210:26 [INFO] [stdout] | [INFO] [stdout] 210 | pack_into_inputs(cs.namespace(|| "input packing"), &public_inputs) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zcash_proofs` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:342:9 [INFO] [stdout] | [INFO] [stdout] 336 | let spend_fs = File::open(spend_path).expect("couldn't load Sapling spend parameters file"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let output_fs = File::open(output_path).expect("couldn't load Sapling output parameters file"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | let sprout_fs = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 342 | BufReader::with_capacity(1024 * 1024, spend_fs), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:343:9 [INFO] [stdout] | [INFO] [stdout] 336 | let spend_fs = File::open(spend_path).expect("couldn't load Sapling spend parameters file"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let output_fs = File::open(output_path).expect("couldn't load Sapling output parameters file"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | let sprout_fs = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | BufReader::with_capacity(1024 * 1024, output_fs), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:344:9 [INFO] [stdout] | [INFO] [stdout] 336 | let spend_fs = File::open(spend_path).expect("couldn't load Sapling spend parameters file"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let output_fs = File::open(output_path).expect("couldn't load Sapling output parameters file"); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | let sprout_fs = [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | sprout_fs.map(|fs| BufReader::with_capacity(1024 * 1024, fs)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:339:29 [INFO] [stdout] | [INFO] [stdout] 339 | sprout_path.map(|p| File::open(p).expect("couldn't load Sprout groth16 parameters file")); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit/sprout/mod.rs:210:26 [INFO] [stdout] | [INFO] [stdout] 210 | pack_into_inputs(cs.namespace(|| "input packing"), &public_inputs) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zcash_proofs` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "6cfa23d4c6432b5764189578bdec0c48d788318f1c2d90fdde4ea40ef9b0a4db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6cfa23d4c6432b5764189578bdec0c48d788318f1c2d90fdde4ea40ef9b0a4db", kill_on_drop: false }` [INFO] [stdout] 6cfa23d4c6432b5764189578bdec0c48d788318f1c2d90fdde4ea40ef9b0a4db