[INFO] fetching crate zbuf 0.1.2... [INFO] checking zbuf-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zbuf 0.1.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate zbuf 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zbuf 0.1.2 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate zbuf 0.1.2 [INFO] tweaked toml for crates.io crate zbuf 0.1.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4b5b92cd08014167caac62fccd42cbe62a540d83f62b32cad3933487a3f4417c [INFO] running `Command { std: "docker" "start" "-a" "4b5b92cd08014167caac62fccd42cbe62a540d83f62b32cad3933487a3f4417c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4b5b92cd08014167caac62fccd42cbe62a540d83f62b32cad3933487a3f4417c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b5b92cd08014167caac62fccd42cbe62a540d83f62b32cad3933487a3f4417c", kill_on_drop: false }` [INFO] [stdout] 4b5b92cd08014167caac62fccd42cbe62a540d83f62b32cad3933487a3f4417c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5f272a5069114e9ce9685e89bf6422e220e2a5bd3221a077d2815ba137c01340 [INFO] running `Command { std: "docker" "start" "-a" "5f272a5069114e9ce9685e89bf6422e220e2a5bd3221a077d2815ba137c01340", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking zbuf v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> bytesbuf.rs:683:24 [INFO] [stdout] | [INFO] [stdout] 683 | if let b' '...b'~' = byte { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> bytesbuf.rs:683:24 [INFO] [stdout] | [INFO] [stdout] 683 | if let b' '...b'~' = byte { [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> strbuf.rs:412:44 [INFO] [stdout] | [INFO] [stdout] 410 | pub unsafe fn write_to_uninitialized_tail(&mut self, f: F) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 411 | where F: FnOnce(&mut str) -> usize { [INFO] [stdout] 412 | self.0.write_to_uninitialized_tail(|uninitialized| { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 413 | | // Safety: the BytesBuf inside StrBuf is private, [INFO] [stdout] 414 | | // and this module mantains UTF-8 well-formedness. [INFO] [stdout] 415 | | let uninitialized_str = str_from_utf8_unchecked_mut(uninitialized); [INFO] [stdout] 416 | | f(uninitialized_str) [INFO] [stdout] 417 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> strbuf.rs:461:37 [INFO] [stdout] | [INFO] [stdout] 459 | pub fn write_to_zeroed_tail(&mut self, f: F) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 460 | where F: FnOnce(&mut str) -> usize { [INFO] [stdout] 461 | self.0.write_to_zeroed_tail(|tail_bytes| { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 462 | | // Safety: a sequence of zero bytes is well-formed UTF-8. [INFO] [stdout] 463 | | let tail_str = unsafe { [INFO] [stdout] 464 | | str_from_utf8_unchecked_mut(tail_bytes) [INFO] [stdout] ... | [INFO] [stdout] 468 | | additional_len [INFO] [stdout] 469 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> strbuf.rs:467:13 [INFO] [stdout] | [INFO] [stdout] 467 | &tail_str[..additional_len]; // Check char boundary [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 467 | let _ = &tail_str[..additional_len]; // Check char boundary [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zbuf` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> strbuf.rs:412:44 [INFO] [stdout] | [INFO] [stdout] 410 | pub unsafe fn write_to_uninitialized_tail(&mut self, f: F) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 411 | where F: FnOnce(&mut str) -> usize { [INFO] [stdout] 412 | self.0.write_to_uninitialized_tail(|uninitialized| { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 413 | | // Safety: the BytesBuf inside StrBuf is private, [INFO] [stdout] 414 | | // and this module mantains UTF-8 well-formedness. [INFO] [stdout] 415 | | let uninitialized_str = str_from_utf8_unchecked_mut(uninitialized); [INFO] [stdout] 416 | | f(uninitialized_str) [INFO] [stdout] 417 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> strbuf.rs:461:37 [INFO] [stdout] | [INFO] [stdout] 459 | pub fn write_to_zeroed_tail(&mut self, f: F) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 460 | where F: FnOnce(&mut str) -> usize { [INFO] [stdout] 461 | self.0.write_to_zeroed_tail(|tail_bytes| { [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 462 | | // Safety: a sequence of zero bytes is well-formed UTF-8. [INFO] [stdout] 463 | | let tail_str = unsafe { [INFO] [stdout] 464 | | str_from_utf8_unchecked_mut(tail_bytes) [INFO] [stdout] ... | [INFO] [stdout] 468 | | additional_len [INFO] [stdout] 469 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> strbuf.rs:467:13 [INFO] [stdout] | [INFO] [stdout] 467 | &tail_str[..additional_len]; // Check char boundary [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 467 | let _ = &tail_str[..additional_len]; // Check char boundary [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zbuf` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5f272a5069114e9ce9685e89bf6422e220e2a5bd3221a077d2815ba137c01340", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f272a5069114e9ce9685e89bf6422e220e2a5bd3221a077d2815ba137c01340", kill_on_drop: false }` [INFO] [stdout] 5f272a5069114e9ce9685e89bf6422e220e2a5bd3221a077d2815ba137c01340