[INFO] fetching crate zarchive 0.2.0... [INFO] checking zarchive-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate zarchive 0.2.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate zarchive 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate zarchive 0.2.0 [INFO] finished tweaking crates.io crate zarchive 0.2.0 [INFO] tweaked toml for crates.io crate zarchive 0.2.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 50 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8ac4b9a72e7ac1340e2af65e9c56114f01efe8199c44e033793ea7f8321c47f0 [INFO] running `Command { std: "docker" "start" "-a" "8ac4b9a72e7ac1340e2af65e9c56114f01efe8199c44e033793ea7f8321c47f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8ac4b9a72e7ac1340e2af65e9c56114f01efe8199c44e033793ea7f8321c47f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ac4b9a72e7ac1340e2af65e9c56114f01efe8199c44e033793ea7f8321c47f0", kill_on_drop: false }` [INFO] [stdout] 8ac4b9a72e7ac1340e2af65e9c56114f01efe8199c44e033793ea7f8321c47f0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a1851a5c184661ce03eec266d87b915fb3a9096d019c28a3f56260413b7e2451 [INFO] running `Command { std: "docker" "start" "-a" "a1851a5c184661ce03eec266d87b915fb3a9096d019c28a3f56260413b7e2451", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling scratch v1.0.7 [INFO] [stderr] Compiling cxxbridge-flags v1.0.128 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling unicode-width v0.1.13 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling codespan-reporting v0.11.1 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling link-cplusplus v1.0.9 [INFO] [stderr] Compiling cxx v1.0.128 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling cxx-build v1.0.128 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling cxxbridge-macro v1.0.128 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling zarchive v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:85:22 [INFO] [stdout] | [INFO] [stdout] 85 | .then(|| archive.count_dir_entries(self).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Ok(Self(RwLock::new(ffi::OpenFromFile( [INFO] [stdout] | ____________^ [INFO] [stdout] 177 | | path.as_ref().to_str().ok_or_else(|| { [INFO] [stdout] 178 | | ZArchiveError::InvalidFilePath(path.as_ref().to_string_lossy().to_string()) [INFO] [stdout] 179 | | })?, [INFO] [stdout] 180 | | )?))) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn file_size(&self, file: impl AsRef) -> Option { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let file = file.as_ref().to_str()?; [INFO] [stdout] 186 | let mut archive = self.0.write().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let node_handle = archive.pin_mut().LookUp(file, true, false).ok()?; [INFO] [stdout] 188 | / archive [INFO] [stdout] 189 | | .pin_mut() [INFO] [stdout] 190 | | .GetFileSize(node_handle) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zarchive` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:85:22 [INFO] [stdout] | [INFO] [stdout] 85 | .then(|| archive.count_dir_entries(self).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | Ok(Self(RwLock::new(ffi::OpenFromFile( [INFO] [stdout] | ____________^ [INFO] [stdout] 177 | | path.as_ref().to_str().ok_or_else(|| { [INFO] [stdout] 178 | | ZArchiveError::InvalidFilePath(path.as_ref().to_string_lossy().to_string()) [INFO] [stdout] 179 | | })?, [INFO] [stdout] 180 | | )?))) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:188:9 [INFO] [stdout] | [INFO] [stdout] 184 | pub fn file_size(&self, file: impl AsRef) -> Option { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let file = file.as_ref().to_str()?; [INFO] [stdout] 186 | let mut archive = self.0.write().unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | let node_handle = archive.pin_mut().LookUp(file, true, false).ok()?; [INFO] [stdout] 188 | / archive [INFO] [stdout] 189 | | .pin_mut() [INFO] [stdout] 190 | | .GetFileSize(node_handle) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zarchive` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "a1851a5c184661ce03eec266d87b915fb3a9096d019c28a3f56260413b7e2451", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a1851a5c184661ce03eec266d87b915fb3a9096d019c28a3f56260413b7e2451", kill_on_drop: false }` [INFO] [stdout] a1851a5c184661ce03eec266d87b915fb3a9096d019c28a3f56260413b7e2451