[INFO] fetching crate yutani 0.0.0... [INFO] checking yutani-0.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate yutani 0.0.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate yutani 0.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate yutani 0.0.0 [INFO] finished tweaking crates.io crate yutani 0.0.0 [INFO] tweaked toml for crates.io crate yutani 0.0.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 17 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eb10b0823d8f4f20abea93e64ae94e6bdb31da5d77f4db8709467c21f48473ba [INFO] running `Command { std: "docker" "start" "-a" "eb10b0823d8f4f20abea93e64ae94e6bdb31da5d77f4db8709467c21f48473ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eb10b0823d8f4f20abea93e64ae94e6bdb31da5d77f4db8709467c21f48473ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb10b0823d8f4f20abea93e64ae94e6bdb31da5d77f4db8709467c21f48473ba", kill_on_drop: false }` [INFO] [stdout] eb10b0823d8f4f20abea93e64ae94e6bdb31da5d77f4db8709467c21f48473ba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7d90654c572ac8fbb69fa73c8d49494aaa9f015987d682ff82878d781c4f5836 [INFO] running `Command { std: "docker" "start" "-a" "7d90654c572ac8fbb69fa73c8d49494aaa9f015987d682ff82878d781c4f5836", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Compiling syslib-macro v0.0.0 [INFO] [stderr] Checking syslib v0.0.0 [INFO] [stderr] Checking yutani v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use prelude::WlError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `WlError` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub use prelude::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use prelude::WlError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use prelude::WlError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `WlError` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub use prelude::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use prelude::WlError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn event_loop>(path: P, state: T, constructor: GlobalBuilderFn) -> crate::Result> { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | wire::EventLoop::new(state).and_then(|mut event_loop| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:39:46 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn event_loop>(path: P, state: T, constructor: GlobalBuilderFn) -> crate::Result> { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | wire::EventLoop::new(state).and_then(|mut event_loop| { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 40 | | let server = wire::Server::listen(path) [INFO] [stdout] 41 | | .map(|server| Self { server, constructor, _marker: PhantomData })?; [INFO] [stdout] 42 | | event_loop.add(Box::new(server))?; [INFO] [stdout] 43 | | Ok(event_loop) [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:83:22 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn new(stream: Stream) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | objects: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn new(state: T) -> crate::Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | epoll: syslib::epoll_create(syslib::epoll::Flags::CLOSE_ON_EXEC)?, [INFO] [stdout] 148 | | sources: HashMap::new(), [INFO] [stdout] 149 | | state [INFO] [stdout] 150 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 208 | pub fn listen>(path: P) -> crate::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let socket = syslib::socket(Domain::UNIX, Type::STREAM | TypeFlags::CLOSE_ON_EXEC, Protocol::UNSPECIFIED)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 217 | | socket [INFO] [stdout] 218 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire.rs:245:12 [INFO] [stdout] | [INFO] [stdout] 242 | pub(crate) fn new(socket: Socket) -> crate::Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 246 | | socket, [INFO] [stdout] 247 | | rx_msg: RingBuffer::new(1024), [INFO] [stdout] 248 | | tx_msg: Vec::with_capacity(1024), [INFO] [stdout] 249 | | rx_fd: RingBuffer::new(8), [INFO] [stdout] 250 | | tx_fd: RingBuffer::new(8) [INFO] [stdout] 251 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn event_loop>(path: P, state: T, constructor: GlobalBuilderFn) -> crate::Result> { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | wire::EventLoop::new(state).and_then(|mut event_loop| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:39:46 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn event_loop>(path: P, state: T, constructor: GlobalBuilderFn) -> crate::Result> { [INFO] [stdout] | ------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | wire::EventLoop::new(state).and_then(|mut event_loop| { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 40 | | let server = wire::Server::listen(path) [INFO] [stdout] 41 | | .map(|server| Self { server, constructor, _marker: PhantomData })?; [INFO] [stdout] 42 | | event_loop.add(Box::new(server))?; [INFO] [stdout] 43 | | Ok(event_loop) [INFO] [stdout] 44 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:83:22 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn new(stream: Stream) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | objects: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 145 | pub fn new(state: T) -> crate::Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 147 | | epoll: syslib::epoll_create(syslib::epoll::Flags::CLOSE_ON_EXEC)?, [INFO] [stdout] 148 | | sources: HashMap::new(), [INFO] [stdout] 149 | | state [INFO] [stdout] 150 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 208 | pub fn listen>(path: P) -> crate::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let socket = syslib::socket(Domain::UNIX, Type::STREAM | TypeFlags::CLOSE_ON_EXEC, Protocol::UNSPECIFIED)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 217 | | socket [INFO] [stdout] 218 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wire.rs:245:12 [INFO] [stdout] | [INFO] [stdout] 242 | pub(crate) fn new(socket: Socket) -> crate::Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 246 | | socket, [INFO] [stdout] 247 | | rx_msg: RingBuffer::new(1024), [INFO] [stdout] 248 | | tx_msg: Vec::with_capacity(1024), [INFO] [stdout] 249 | | rx_fd: RingBuffer::new(8), [INFO] [stdout] 250 | | tx_fd: RingBuffer::new(8) [INFO] [stdout] 251 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yutani` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `yutani` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "7d90654c572ac8fbb69fa73c8d49494aaa9f015987d682ff82878d781c4f5836", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d90654c572ac8fbb69fa73c8d49494aaa9f015987d682ff82878d781c4f5836", kill_on_drop: false }` [INFO] [stdout] 7d90654c572ac8fbb69fa73c8d49494aaa9f015987d682ff82878d781c4f5836