[INFO] fetching crate yubirs 0.9.3... [INFO] checking yubirs-0.9.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate yubirs 0.9.3 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate yubirs 0.9.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate yubirs 0.9.3 [INFO] finished tweaking crates.io crate yubirs 0.9.3 [INFO] tweaked toml for crates.io crate yubirs 0.9.3 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 191 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bindgen v0.69.4 (latest: v0.70.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding which v4.4.2 (latest: v6.0.3) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `bdrck` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef11f8fb6ea32354709bc71364c5bcc4adc60b8cc8dd081c07388b2283c64c44 [INFO] running `Command { std: "docker" "start" "-a" "ef11f8fb6ea32354709bc71364c5bcc4adc60b8cc8dd081c07388b2283c64c44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef11f8fb6ea32354709bc71364c5bcc4adc60b8cc8dd081c07388b2283c64c44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef11f8fb6ea32354709bc71364c5bcc4adc60b8cc8dd081c07388b2283c64c44", kill_on_drop: false }` [INFO] [stdout] ef11f8fb6ea32354709bc71364c5bcc4adc60b8cc8dd081c07388b2283c64c44 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f9de75f88cdad11d193a84b11dd4fcc4968cbf1b0b4e7530ca627088e1cfdeda [INFO] running `Command { std: "docker" "start" "-a" "f9de75f88cdad11d193a84b11dd4fcc4968cbf1b0b4e7530ca627088e1cfdeda", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `bdrck` dependency) [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Checking openssl-sys v0.9.103 [INFO] [stderr] Compiling prettyplease v0.2.22 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling gimli v0.29.0 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling adler v1.0.2 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling miniz_oxide v0.7.4 [INFO] [stderr] Compiling object v0.36.4 [INFO] [stderr] Compiling libloading v0.8.5 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling addr2line v0.22.0 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling bindgen v0.69.4 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling rustc-demangle v0.1.24 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling fastrand v2.1.1 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling curl-sys v0.4.74+curl-8.9.0 [INFO] [stderr] Compiling tempfile v3.12.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Compiling pcsc-sys v1.2.1 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Compiling curl v0.4.46 [INFO] [stderr] Checking errno v0.3.9 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking openssl v0.10.66 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking native-tls v0.2.12 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Compiling halite-sys v0.1.12 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking bdrck v0.20.5 [INFO] [stderr] Checking yubirs v0.9.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/otp/mod.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | Lazy::new(|| Regex::new(r"^[jxe.uidchtnbpygk]{32,48}$").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/otp/mod.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | Lazy::new(|| Regex::new(r"^[cbdefghijklnrtuv]{32,48}$").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/connection.rs:25:29 [INFO] [stdout] | [INFO] [stdout] 25 | Lazy::new(|| Mutex::new(HashMap::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/connection.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 35 | let cstr_reader = CString::new(reader)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let mut ref_counts = READER_REF_COUNTS.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let mut maybe_rc = weak.upgrade(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(PcscHardwareConnection { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | reader: cstr_reader, [INFO] [stdout] 86 | | card: card, [INFO] [stdout] 87 | | // Call `unwrap` so we panic if there is no refcount. The logic [INFO] [stdout] 88 | | // above guarantees this will never be the case. [INFO] [stdout] 89 | | refcount: Some(maybe_rc.unwrap()), [INFO] [stdout] 90 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/hal.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | Err(SmartCardError::new(pcsc_sys::SCARD_E_UNKNOWN_READER) [INFO] [stdout] | _____________^ [INFO] [stdout] 85 | | .err() [INFO] [stdout] 86 | | .unwrap() [INFO] [stdout] 87 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/hal.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 109 | let mut sw: StatusWord = StatusWord::success(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | Ok((sw, out_data)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/hal.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 178 | recording: Option>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok(PcscHardware { [INFO] [stdout] | ____________^ [INFO] [stdout] 182 | | context: PcscHardwareContext::establish()?, [INFO] [stdout] 183 | | card: None, [INFO] [stdout] 184 | | recording: recording, [INFO] [stdout] 185 | | output_recording: output_recording, [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/hal.rs:191:13 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn new_with_recording>(output: P) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | Self::new_impl( [INFO] [stdout] 191 | Some(Mutex::new(Recording::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/hal.rs:242:12 [INFO] [stdout] | [INFO] [stdout] 240 | let sw = StatusWord::new(recv_buffer.as_slice(), recv_length as usize); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | recv_buffer.truncate(recv_length as usize - 2); [INFO] [stdout] 242 | Ok((sw, recv_buffer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/handle.rs:1198:12 [INFO] [stdout] | [INFO] [stdout] 1186 | input: P, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1193 | let key = PrivateKey::from_pem(input, encrypted, passphrase)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1198 | Ok(key.to_public_key()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/handle.rs:1219:12 [INFO] [stdout] | [INFO] [stdout] 1207 | let (sw, recv) = self.hal.send_data( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1219 | Ok(PublicKeyCertificate::from_der(recv.as_slice())?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/handle.rs:1248:12 [INFO] [stdout] | [INFO] [stdout] 1248 | Ok(PublicKeyCertificate::from_der(&der[0..len])?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/key.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 49 | fn new_impl(metadata: KeyMetadata, public_key: Option) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut handle: Handle = Handle::new()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Ok(Key { [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | handle: Mutex::new(handle), [INFO] [stdout] 55 | | public_key: match public_key { [INFO] [stdout] 56 | | Some(pk) => pk, [INFO] [stdout] ... | [INFO] [stdout] 63 | | metadata: metadata, [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/key.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 80 | public_key: PublicKey, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Some(public_key), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/key.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 138 | fn deserialize(data: Secret) -> std::result::Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/otp/mod.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | Lazy::new(|| Regex::new(r"^[jxe.uidchtnbpygk]{32,48}$").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/otp/mod.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | Lazy::new(|| Regex::new(r"^[cbdefghijklnrtuv]{32,48}$").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/connection.rs:25:29 [INFO] [stdout] | [INFO] [stdout] 25 | Lazy::new(|| Mutex::new(HashMap::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/connection.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 35 | let cstr_reader = CString::new(reader)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let mut ref_counts = READER_REF_COUNTS.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let mut maybe_rc = weak.upgrade(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(PcscHardwareConnection { [INFO] [stdout] | ____________^ [INFO] [stdout] 85 | | reader: cstr_reader, [INFO] [stdout] 86 | | card: card, [INFO] [stdout] 87 | | // Call `unwrap` so we panic if there is no refcount. The logic [INFO] [stdout] 88 | | // above guarantees this will never be the case. [INFO] [stdout] 89 | | refcount: Some(maybe_rc.unwrap()), [INFO] [stdout] 90 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/hal.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | Err(SmartCardError::new(pcsc_sys::SCARD_E_UNKNOWN_READER) [INFO] [stdout] | _____________^ [INFO] [stdout] 85 | | .err() [INFO] [stdout] 86 | | .unwrap() [INFO] [stdout] 87 | | .into()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/pkey.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn from_pem(mut r: R) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let data = read_at_most(&mut r, MEGABYTE)?; [INFO] [stdout] 117 | Ok(PublicKey { [INFO] [stdout] | ____________^ [INFO] [stdout] 118 | | inner: openssl::pkey::PKey::public_key_from_pem(data.as_slice())?, [INFO] [stdout] 119 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/pkey.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 146 | let n = openssl::bn::BigNum::from_slice(&data[0..len])?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let e = openssl::bn::BigNum::from_slice(&data[0..len])?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | [INFO] [stdout] 158 | Ok(PublicKey { [INFO] [stdout] | ____________^ [INFO] [stdout] 159 | | inner: openssl::pkey::PKey::from_rsa(openssl::rsa::Rsa::from_public_components(n, e)?)?, [INFO] [stdout] 160 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/pkey.rs:203:12 [INFO] [stdout] | [INFO] [stdout] 186 | let mut group = openssl::ec::EcGroup::from_curve_name(nid)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let mut ctx = openssl::bn::BigNumContext::new()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let point = openssl::ec::EcPoint::from_bytes(&group, &data[0..len], &mut ctx)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | [INFO] [stdout] 203 | Ok(PublicKey { [INFO] [stdout] | ____________^ [INFO] [stdout] 204 | | inner: openssl::pkey::PKey::from_ec_key(openssl::ec::EcKey::from_public_key( [INFO] [stdout] 205 | | &group, &point, [INFO] [stdout] 206 | | )?)?, [INFO] [stdout] 207 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/pkey.rs:305:12 [INFO] [stdout] | [INFO] [stdout] 290 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | Ok(PrivateKey { [INFO] [stdout] | ____________^ [INFO] [stdout] 306 | | inner: match encrypted { [INFO] [stdout] 307 | | false => openssl::pkey::PKey::private_key_from_pem(data.as_slice())?, [INFO] [stdout] 308 | | true => { [INFO] [stdout] ... | [INFO] [stdout] 316 | | }, [INFO] [stdout] 317 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/pkey.rs:326:12 [INFO] [stdout] | [INFO] [stdout] 326 | Ok(PublicKey { [INFO] [stdout] | ____________^ [INFO] [stdout] 327 | | inner: openssl::pkey::PKey::public_key_from_der(der.as_slice())?, [INFO] [stdout] 328 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/util.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 44 | Ok(MaybePromptedCString { [INFO] [stdout] | ____________^ [INFO] [stdout] 45 | | value: CString::new(string)?, [INFO] [stdout] 46 | | length: length, [INFO] [stdout] 47 | | was_provided: was_provided, [INFO] [stdout] 48 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/hal.rs:164:12 [INFO] [stdout] | [INFO] [stdout] 109 | let mut sw: StatusWord = StatusWord::success(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | Ok((sw, out_data)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/hal.rs:181:12 [INFO] [stdout] | [INFO] [stdout] 178 | recording: Option>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 181 | Ok(PcscHardware { [INFO] [stdout] | ____________^ [INFO] [stdout] 182 | | context: PcscHardwareContext::establish()?, [INFO] [stdout] 183 | | card: None, [INFO] [stdout] 184 | | recording: recording, [INFO] [stdout] 185 | | output_recording: output_recording, [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/hal.rs:191:13 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn new_with_recording>(output: P) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | Self::new_impl( [INFO] [stdout] 191 | Some(Mutex::new(Recording::default())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/hal.rs:242:12 [INFO] [stdout] | [INFO] [stdout] 240 | let sw = StatusWord::new(recv_buffer.as_slice(), recv_length as usize); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | recv_buffer.truncate(recv_length as usize - 2); [INFO] [stdout] 242 | Ok((sw, recv_buffer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/handle.rs:1198:12 [INFO] [stdout] | [INFO] [stdout] 1186 | input: P, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1193 | let key = PrivateKey::from_pem(input, encrypted, passphrase)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1198 | Ok(key.to_public_key()?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/handle.rs:1219:12 [INFO] [stdout] | [INFO] [stdout] 1207 | let (sw, recv) = self.hal.send_data( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1219 | Ok(PublicKeyCertificate::from_der(recv.as_slice())?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/handle.rs:1248:12 [INFO] [stdout] | [INFO] [stdout] 1248 | Ok(PublicKeyCertificate::from_der(&der[0..len])?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/key.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 49 | fn new_impl(metadata: KeyMetadata, public_key: Option) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut handle: Handle = Handle::new()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | Ok(Key { [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | handle: Mutex::new(handle), [INFO] [stdout] 55 | | public_key: match public_key { [INFO] [stdout] 56 | | Some(pk) => pk, [INFO] [stdout] ... | [INFO] [stdout] 63 | | metadata: metadata, [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/key.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 80 | public_key: PublicKey, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Some(public_key), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/key.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 138 | fn deserialize(data: Secret) -> std::result::Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 143 | None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/pkey.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn from_pem(mut r: R) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | let data = read_at_most(&mut r, MEGABYTE)?; [INFO] [stdout] 117 | Ok(PublicKey { [INFO] [stdout] | ____________^ [INFO] [stdout] 118 | | inner: openssl::pkey::PKey::public_key_from_pem(data.as_slice())?, [INFO] [stdout] 119 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/pkey.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 146 | let n = openssl::bn::BigNum::from_slice(&data[0..len])?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let e = openssl::bn::BigNum::from_slice(&data[0..len])?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | [INFO] [stdout] 158 | Ok(PublicKey { [INFO] [stdout] | ____________^ [INFO] [stdout] 159 | | inner: openssl::pkey::PKey::from_rsa(openssl::rsa::Rsa::from_public_components(n, e)?)?, [INFO] [stdout] 160 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/pkey.rs:203:12 [INFO] [stdout] | [INFO] [stdout] 186 | let mut group = openssl::ec::EcGroup::from_curve_name(nid)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let mut ctx = openssl::bn::BigNumContext::new()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | let point = openssl::ec::EcPoint::from_bytes(&group, &data[0..len], &mut ctx)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | [INFO] [stdout] 203 | Ok(PublicKey { [INFO] [stdout] | ____________^ [INFO] [stdout] 204 | | inner: openssl::pkey::PKey::from_ec_key(openssl::ec::EcKey::from_public_key( [INFO] [stdout] 205 | | &group, &point, [INFO] [stdout] 206 | | )?)?, [INFO] [stdout] 207 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/pkey.rs:305:12 [INFO] [stdout] | [INFO] [stdout] 290 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | Ok(PrivateKey { [INFO] [stdout] | ____________^ [INFO] [stdout] 306 | | inner: match encrypted { [INFO] [stdout] 307 | | false => openssl::pkey::PKey::private_key_from_pem(data.as_slice())?, [INFO] [stdout] 308 | | true => { [INFO] [stdout] ... | [INFO] [stdout] 316 | | }, [INFO] [stdout] 317 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/pkey.rs:326:12 [INFO] [stdout] | [INFO] [stdout] 326 | Ok(PublicKey { [INFO] [stdout] | ____________^ [INFO] [stdout] 327 | | inner: openssl::pkey::PKey::public_key_from_der(der.as_slice())?, [INFO] [stdout] 328 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/piv/util.rs:44:12 [INFO] [stdout] | [INFO] [stdout] 44 | Ok(MaybePromptedCString { [INFO] [stdout] | ____________^ [INFO] [stdout] 45 | | value: CString::new(string)?, [INFO] [stdout] 46 | | length: length, [INFO] [stdout] 47 | | was_provided: was_provided, [INFO] [stdout] 48 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/otp/request.rs:37:54 [INFO] [stdout] | [INFO] [stdout] 37 | static VALID_NONCE_REGEX: Lazy = Lazy::new(|| Regex::new(r"^[a-zA-Z0-9]{16,40}$").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests/piv/hal.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 92 | let entry: RecordingEntry; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let pop: bool; [INFO] [stdout] 94 | let mut recordings = self.recordings.lock().unwrap(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(match entry.received { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | Ok(v) => v, [INFO] [stdout] 123 | | Err(msg) => return Err(Error::Internal(format!("{}", msg))), [INFO] [stdout] 124 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 23 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yubirs` (lib) due to 22 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `yubirs` (lib test) due to 24 previous errors [INFO] running `Command { std: "docker" "inspect" "f9de75f88cdad11d193a84b11dd4fcc4968cbf1b0b4e7530ca627088e1cfdeda", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9de75f88cdad11d193a84b11dd4fcc4968cbf1b0b4e7530ca627088e1cfdeda", kill_on_drop: false }` [INFO] [stdout] f9de75f88cdad11d193a84b11dd4fcc4968cbf1b0b4e7530ca627088e1cfdeda