[INFO] fetching crate yubikey 0.8.0... [INFO] checking yubikey-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate yubikey 0.8.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate yubikey 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate yubikey 0.8.0 [INFO] finished tweaking crates.io crate yubikey 0.8.0 [INFO] tweaked toml for crates.io crate yubikey 0.8.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 102 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 424bc12cb0df63a90d2775637844fc74ed8be050868871d3c7a1e7a7054ed7e7 [INFO] running `Command { std: "docker" "start" "-a" "424bc12cb0df63a90d2775637844fc74ed8be050868871d3c7a1e7a7054ed7e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "424bc12cb0df63a90d2775637844fc74ed8be050868871d3c7a1e7a7054ed7e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "424bc12cb0df63a90d2775637844fc74ed8be050868871d3c7a1e7a7054ed7e7", kill_on_drop: false }` [INFO] [stdout] 424bc12cb0df63a90d2775637844fc74ed8be050868871d3c7a1e7a7054ed7e7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a2ea295e84825876646b400a5c86cc8e48c086cc265e81a92fe32978e3d93a88 [INFO] running `Command { std: "docker" "start" "-a" "a2ea295e84825876646b400a5c86cc8e48c086cc265e81a92fe32978e3d93a88", kill_on_drop: false }` [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking const-oid v0.9.6 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking flagset v0.4.6 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling pcsc-sys v1.2.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling num-bigint-dig v0.8.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking pcsc v2.8.2 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking des v0.8.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling der_derive v0.7.3 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking der v0.7.9 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking x509-cert v0.2.5 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking p384 v0.13.0 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking rsa v0.9.6 [INFO] [stderr] Checking yubikey v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/error.rs:195:11 [INFO] [stdout] | [INFO] [stdout] 195 | impl From for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | unused_qualifications [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 195 - impl From for Error { [INFO] [stdout] 195 + impl From for Error { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/error.rs:196:19 [INFO] [stdout] | [INFO] [stdout] 196 | fn from(_err: x509_cert::der::Error) -> Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 196 - fn from(_err: x509_cert::der::Error) -> Error { [INFO] [stdout] 196 + fn from(_err: der::Error) -> Error { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:201:50 [INFO] [stdout] | [INFO] [stdout] 201 | let _ = yk_stored.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 201 - let _ = yk_stored.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] 201 + let _ = yk_stored.disconnect(Disposition::LeaveCard); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:202:49 [INFO] [stdout] | [INFO] [stdout] 202 | let _ = yk_found.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 202 - let _ = yk_found.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] 202 + let _ = yk_found.disconnect(Disposition::LeaveCard); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:249:44 [INFO] [stdout] | [INFO] [stdout] 249 | let _ = yubikey.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 249 - let _ = yubikey.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] 249 + let _ = yubikey.disconnect(Disposition::LeaveCard); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:730:54 [INFO] [stdout] | [INFO] [stdout] 730 | if let Err((_, e)) = card.disconnect(pcsc::Disposition::LeaveCard) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 730 - if let Err((_, e)) = card.disconnect(pcsc::Disposition::LeaveCard) { [INFO] [stdout] 730 + if let Err((_, e)) = card.disconnect(Disposition::LeaveCard) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/error.rs:195:11 [INFO] [stdout] | [INFO] [stdout] 195 | impl From for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | unused_qualifications [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 195 - impl From for Error { [INFO] [stdout] 195 + impl From for Error { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/error.rs:196:19 [INFO] [stdout] | [INFO] [stdout] 196 | fn from(_err: x509_cert::der::Error) -> Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 196 - fn from(_err: x509_cert::der::Error) -> Error { [INFO] [stdout] 196 + fn from(_err: der::Error) -> Error { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:201:50 [INFO] [stdout] | [INFO] [stdout] 201 | let _ = yk_stored.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 201 - let _ = yk_stored.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] 201 + let _ = yk_stored.disconnect(Disposition::LeaveCard); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:202:49 [INFO] [stdout] | [INFO] [stdout] 202 | let _ = yk_found.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 202 - let _ = yk_found.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] 202 + let _ = yk_found.disconnect(Disposition::LeaveCard); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:249:44 [INFO] [stdout] | [INFO] [stdout] 249 | let _ = yubikey.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 249 - let _ = yubikey.disconnect(pcsc::Disposition::LeaveCard); [INFO] [stdout] 249 + let _ = yubikey.disconnect(Disposition::LeaveCard); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary qualification [INFO] [stdout] --> src/yubikey.rs:730:54 [INFO] [stdout] | [INFO] [stdout] 730 | if let Err((_, e)) = card.disconnect(pcsc::Disposition::LeaveCard) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: remove the unnecessary path segments [INFO] [stdout] | [INFO] [stdout] 730 - if let Err((_, e)) = card.disconnect(pcsc::Disposition::LeaveCard) { [INFO] [stdout] 730 + if let Err((_, e)) = card.disconnect(Disposition::LeaveCard) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/certificate.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 162 | pub fn from_bytes(cert: impl Into) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let cert = cert.into(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | / x509_cert::Certificate::from_der(&cert) [INFO] [stdout] 171 | | .map(|cert| Self { cert }) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/certificate.rs:423:16 [INFO] [stdout] | [INFO] [stdout] 420 | let public_key = KT::PublicKey::try_from(subject_pki).map_err(|_| Error::ParseError)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | let public_key = public_key.into(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 422 | [INFO] [stdout] 423 | Ok(Self { [INFO] [stdout] | ________________^ [INFO] [stdout] 424 | | yubikey: RefCell::new(yubikey), [INFO] [stdout] 425 | | key, [INFO] [stdout] 426 | | public_key, [INFO] [stdout] 427 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 82 | let data = txn.fetch_object(T::obj_id())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Ok(Metadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 84 | | inner: Tlv::parse_single(data, T::tag())?, [INFO] [stdout] 85 | | _marker: PhantomData, [INFO] [stdout] 86 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 33 | let ctx = pcsc::Context::establish(pcsc::Scope::System)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let reader_names = vec![0u8; ctx.list_readers_len()?]; [INFO] [stdout] 35 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | ctx: Arc::new(Mutex::new(ctx)), [INFO] [stdout] 37 | | reader_names, [INFO] [stdout] 38 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 47 | let c = ctx.lock().map_err(|_| Error::GenericError)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let readers: Vec<_> = reader_cstrs [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(readers.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:58:43 [INFO] [stdout] | [INFO] [stdout] 58 | .map(|name| Reader::new(name, Arc::clone(ctx))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 95 | let ctx = self.ctx.lock().map_err(|_| Error::GenericError)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Ok(ctx.connect(self.name, pcsc::ShareMode::Shared, pcsc::Protocols::T1)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:369:12 [INFO] [stdout] | [INFO] [stdout] 336 | let response = self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | Ok(Buffer::new(inner_tlv.value.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:483:12 [INFO] [stdout] | [INFO] [stdout] 461 | let response = self.transfer_data(&templ, &indata[..inlen], CB_BUF_MAX)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 483 | Ok(Zeroizing::new(tlv.value.to_vec())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/yubikey.rs:305:9 [INFO] [stdout] | [INFO] [stdout] 296 | pub fn disconnect(self, disposition: Disposition) -> core::result::Result<(), (Self, Error)> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | let Self { [INFO] [stdout] 298 | card, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | name, [INFO] [stdout] 300 | pin, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | card.disconnect(disposition).map_err(|(card, e)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/yubikey.rs:305:46 [INFO] [stdout] | [INFO] [stdout] 296 | pub fn disconnect(self, disposition: Disposition) -> core::result::Result<(), (Self, Error)> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | let Self { [INFO] [stdout] 298 | card, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | name, [INFO] [stdout] 300 | pin, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | card.disconnect(disposition).map_err(|(card, e)| { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 306 | | ( [INFO] [stdout] 307 | | Self { [INFO] [stdout] 308 | | card, [INFO] [stdout] ... | [INFO] [stdout] 315 | | ) [INFO] [stdout] 316 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/yubikey.rs:307:17 [INFO] [stdout] | [INFO] [stdout] 300 | pin, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | card.disconnect(disposition).map_err(|(card, e)| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | ( [INFO] [stdout] 307 | / Self { [INFO] [stdout] 308 | | card, [INFO] [stdout] 309 | | name, [INFO] [stdout] 310 | | pin, [INFO] [stdout] 311 | | version, [INFO] [stdout] 312 | | serial, [INFO] [stdout] 313 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yubikey` (lib test) due to 13 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/certificate.rs:170:9 [INFO] [stdout] | [INFO] [stdout] 162 | pub fn from_bytes(cert: impl Into) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | let cert = cert.into(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | / x509_cert::Certificate::from_der(&cert) [INFO] [stdout] 171 | | .map(|cert| Self { cert }) [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/certificate.rs:423:16 [INFO] [stdout] | [INFO] [stdout] 420 | let public_key = KT::PublicKey::try_from(subject_pki).map_err(|_| Error::ParseError)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 421 | let public_key = public_key.into(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 422 | [INFO] [stdout] 423 | Ok(Self { [INFO] [stdout] | ________________^ [INFO] [stdout] 424 | | yubikey: RefCell::new(yubikey), [INFO] [stdout] 425 | | key, [INFO] [stdout] 426 | | public_key, [INFO] [stdout] 427 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:83:12 [INFO] [stdout] | [INFO] [stdout] 82 | let data = txn.fetch_object(T::obj_id())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | Ok(Metadata { [INFO] [stdout] | ____________^ [INFO] [stdout] 84 | | inner: Tlv::parse_single(data, T::tag())?, [INFO] [stdout] 85 | | _marker: PhantomData, [INFO] [stdout] 86 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 33 | let ctx = pcsc::Context::establish(pcsc::Scope::System)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let reader_names = vec![0u8; ctx.list_readers_len()?]; [INFO] [stdout] 35 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 36 | | ctx: Arc::new(Mutex::new(ctx)), [INFO] [stdout] 37 | | reader_names, [INFO] [stdout] 38 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 47 | let c = ctx.lock().map_err(|_| Error::GenericError)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let readers: Vec<_> = reader_cstrs [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(readers.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:58:43 [INFO] [stdout] | [INFO] [stdout] 58 | .map(|name| Reader::new(name, Arc::clone(ctx))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:96:12 [INFO] [stdout] | [INFO] [stdout] 95 | let ctx = self.ctx.lock().map_err(|_| Error::GenericError)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | Ok(ctx.connect(self.name, pcsc::ShareMode::Shared, pcsc::Protocols::T1)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:369:12 [INFO] [stdout] | [INFO] [stdout] 336 | let response = self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 369 | Ok(Buffer::new(inner_tlv.value.into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:483:12 [INFO] [stdout] | [INFO] [stdout] 461 | let response = self.transfer_data(&templ, &indata[..inlen], CB_BUF_MAX)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 483 | Ok(Zeroizing::new(tlv.value.to_vec())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/yubikey.rs:305:9 [INFO] [stdout] | [INFO] [stdout] 296 | pub fn disconnect(self, disposition: Disposition) -> core::result::Result<(), (Self, Error)> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | let Self { [INFO] [stdout] 298 | card, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | name, [INFO] [stdout] 300 | pin, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | card.disconnect(disposition).map_err(|(card, e)| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/yubikey.rs:305:46 [INFO] [stdout] | [INFO] [stdout] 296 | pub fn disconnect(self, disposition: Disposition) -> core::result::Result<(), (Self, Error)> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 297 | let Self { [INFO] [stdout] 298 | card, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | name, [INFO] [stdout] 300 | pin, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | card.disconnect(disposition).map_err(|(card, e)| { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 306 | | ( [INFO] [stdout] 307 | | Self { [INFO] [stdout] 308 | | card, [INFO] [stdout] ... | [INFO] [stdout] 315 | | ) [INFO] [stdout] 316 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/yubikey.rs:307:17 [INFO] [stdout] | [INFO] [stdout] 300 | pin, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | card.disconnect(disposition).map_err(|(card, e)| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | ( [INFO] [stdout] 307 | / Self { [INFO] [stdout] 308 | | card, [INFO] [stdout] 309 | | name, [INFO] [stdout] 310 | | pin, [INFO] [stdout] 311 | | version, [INFO] [stdout] 312 | | serial, [INFO] [stdout] 313 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yubikey` (lib) due to 13 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a2ea295e84825876646b400a5c86cc8e48c086cc265e81a92fe32978e3d93a88", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2ea295e84825876646b400a5c86cc8e48c086cc265e81a92fe32978e3d93a88", kill_on_drop: false }` [INFO] [stdout] a2ea295e84825876646b400a5c86cc8e48c086cc265e81a92fe32978e3d93a88