[INFO] fetching crate yrs-warp 0.8.0... [INFO] checking yrs-warp-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate yrs-warp 0.8.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate yrs-warp 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate yrs-warp 0.8.0 [INFO] finished tweaking crates.io crate yrs-warp 0.8.0 [INFO] tweaked toml for crates.io crate yrs-warp 0.8.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate yrs-warp 0.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9e24fa3a517c43cff138ce73de2925dd9c267b18a5b8d16bf96b53314914469b [INFO] running `Command { std: "docker" "start" "-a" "9e24fa3a517c43cff138ce73de2925dd9c267b18a5b8d16bf96b53314914469b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9e24fa3a517c43cff138ce73de2925dd9c267b18a5b8d16bf96b53314914469b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9e24fa3a517c43cff138ce73de2925dd9c267b18a5b8d16bf96b53314914469b", kill_on_drop: false }` [INFO] [stdout] 9e24fa3a517c43cff138ce73de2925dd9c267b18a5b8d16bf96b53314914469b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] def7bebb6136453cefda22e9e6513f074f80b29d6a6ae86500895571ec00dacc [INFO] running `Command { std: "docker" "start" "-a" "def7bebb6136453cefda22e9e6513f074f80b29d6a6ae86500895571ec00dacc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Compiling multer v2.1.0 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking smallstr v0.3.0 [INFO] [stderr] Checking atomic_refcell v0.1.13 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling syn v2.0.55 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tungstenite v0.20.1 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-tungstenite v0.20.1 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking h2 v0.3.25 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking yrs v0.18.2 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking warp v0.3.6 [INFO] [stderr] Checking yrs-warp v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broadcast.rs:173:80 [INFO] [stdout] | [INFO] [stdout] 173 | let msg = Message::decode_v1(&res.map_err(|e| Error::Other(Box::new(e)))?)?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broadcast.rs:181:59 [INFO] [stdout] | [INFO] [stdout] 181 | ... .map_err(|e| Error::Other(Box::new(e)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broadcast.rs:263:38 [INFO] [stdout] | [INFO] [stdout] 263 | res.map_err(|e| Error::Other(e.into()))? [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signaling.rs:125:16 [INFO] [stdout] | [INFO] [stdout] 124 | fn new(sink: SplitSink) -> Self { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | WsSink(Arc::new(Mutex::new(sink))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yrs-warp` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broadcast.rs:173:80 [INFO] [stdout] | [INFO] [stdout] 173 | let msg = Message::decode_v1(&res.map_err(|e| Error::Other(Box::new(e)))?)?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broadcast.rs:181:59 [INFO] [stdout] | [INFO] [stdout] 181 | ... .map_err(|e| Error::Other(Box::new(e)))?; [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broadcast.rs:263:38 [INFO] [stdout] | [INFO] [stdout] 263 | res.map_err(|e| Error::Other(e.into()))? [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broadcast.rs:330:31 [INFO] [stdout] | [INFO] [stdout] 330 | let msg = msg.map(|x| Message::decode_v1(&x.unwrap()).unwrap()); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broadcast.rs:345:31 [INFO] [stdout] | [INFO] [stdout] 345 | let msg = msg.map(|x| Message::decode_v1(&x.unwrap()).unwrap()); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broadcast.rs:365:35 [INFO] [stdout] | [INFO] [stdout] 365 | let msg = msg.map(|x| Message::decode_v1(&x.unwrap()).unwrap()); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signaling.rs:125:16 [INFO] [stdout] | [INFO] [stdout] 124 | fn new(sink: SplitSink) -> Self { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | WsSink(Arc::new(Mutex::new(sink))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yrs-warp` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "def7bebb6136453cefda22e9e6513f074f80b29d6a6ae86500895571ec00dacc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "def7bebb6136453cefda22e9e6513f074f80b29d6a6ae86500895571ec00dacc", kill_on_drop: false }` [INFO] [stdout] def7bebb6136453cefda22e9e6513f074f80b29d6a6ae86500895571ec00dacc