[INFO] fetching crate yogurt 0.3.1... [INFO] checking yogurt-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate yogurt 0.3.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate yogurt 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate yogurt 0.3.1 [INFO] finished tweaking crates.io crate yogurt 0.3.1 [INFO] tweaked toml for crates.io crate yogurt 0.3.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate yogurt 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 554804734d844282d7a7088d03461d656e33f489dc0dd253ad0d6cecd453649b [INFO] running `Command { std: "docker" "start" "-a" "554804734d844282d7a7088d03461d656e33f489dc0dd253ad0d6cecd453649b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "554804734d844282d7a7088d03461d656e33f489dc0dd253ad0d6cecd453649b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "554804734d844282d7a7088d03461d656e33f489dc0dd253ad0d6cecd453649b", kill_on_drop: false }` [INFO] [stdout] 554804734d844282d7a7088d03461d656e33f489dc0dd253ad0d6cecd453649b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b5d3f7c67e39ecbc82ee23864cb5accb40660f63d8d3bd8acc67eb3dc8c779e [INFO] running `Command { std: "docker" "start" "-a" "0b5d3f7c67e39ecbc82ee23864cb5accb40660f63d8d3bd8acc67eb3dc8c779e", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking yogurt v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatcher/mod.rs:145:38 [INFO] [stdout] | [INFO] [stdout] 143 | context: Box C>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | ) -> Result> { [INFO] [stdout] 145 | self.command_in_ctx(command, Some(context)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatcher/mod.rs:188:15 [INFO] [stdout] | [INFO] [stdout] 181 | fn execute_command(&self, tokens: Vec, context: C) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | match self.root.execute( [INFO] [stdout] | _______________^ [INFO] [stdout] 189 | | 0, [INFO] [stdout] 190 | | tokens.as_slice(), [INFO] [stdout] 191 | | &mut named_args, [INFO] [stdout] 192 | | &mut ExecContext::new(context), [INFO] [stdout] 193 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatcher/builder.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn build(self) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Ok(Dispatcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 100 | | root: self.root.build(), [INFO] [stdout] 101 | | prefix: self.prefix.unwrap_or_default(), [INFO] [stdout] 102 | | context_factory: self.context_factory.ok_or(Error::IncompleteBuilder)?, [INFO] [stdout] 103 | | base_context: self.base_context.ok_or(Error::IncompleteBuilder)?, [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers/escaped_string.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 14 | let parse_hex = take_while_m_n(1, 6, |c: char| c.is_ascii_hexdigit()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | [INFO] [stdout] 16 | let parse_delimited_hex = preceded(nchar('u'), delimited(nchar('{'), parse_hex, nchar('}'))); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | [INFO] [stdout] 18 | let parse_u32 = map_res(parse_delimited_hex, move |hex| u32::from_str_radix(hex, 16)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | map_opt(parse_u32, std::char::from_u32)(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers/escaped_string.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 50 | let not_quote_slash = is_not("\"\\"); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | [INFO] [stdout] 52 | verify(not_quote_slash, |s: &str| !s.is_empty())(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers/escaped_string.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 77 | let build_string = fold_many0(parse_fragment, String::new, |mut string, fragment| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | delimited(nchar('"'), build_string, nchar('"'))(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yogurt` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatcher/mod.rs:145:38 [INFO] [stdout] | [INFO] [stdout] 143 | context: Box C>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 144 | ) -> Result> { [INFO] [stdout] 145 | self.command_in_ctx(command, Some(context)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatcher/mod.rs:188:15 [INFO] [stdout] | [INFO] [stdout] 181 | fn execute_command(&self, tokens: Vec, context: C) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 188 | match self.root.execute( [INFO] [stdout] | _______________^ [INFO] [stdout] 189 | | 0, [INFO] [stdout] 190 | | tokens.as_slice(), [INFO] [stdout] 191 | | &mut named_args, [INFO] [stdout] 192 | | &mut ExecContext::new(context), [INFO] [stdout] 193 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatcher/builder.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn build(self) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Ok(Dispatcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 100 | | root: self.root.build(), [INFO] [stdout] 101 | | prefix: self.prefix.unwrap_or_default(), [INFO] [stdout] 102 | | context_factory: self.context_factory.ok_or(Error::IncompleteBuilder)?, [INFO] [stdout] 103 | | base_context: self.base_context.ok_or(Error::IncompleteBuilder)?, [INFO] [stdout] 104 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers/escaped_string.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 14 | let parse_hex = take_while_m_n(1, 6, |c: char| c.is_ascii_hexdigit()); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | [INFO] [stdout] 16 | let parse_delimited_hex = preceded(nchar('u'), delimited(nchar('{'), parse_hex, nchar('}'))); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | [INFO] [stdout] 18 | let parse_u32 = map_res(parse_delimited_hex, move |hex| u32::from_str_radix(hex, 16)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | map_opt(parse_u32, std::char::from_u32)(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers/escaped_string.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 50 | let not_quote_slash = is_not("\"\\"); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | [INFO] [stdout] 52 | verify(not_quote_slash, |s: &str| !s.is_empty())(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsers/escaped_string.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 77 | let build_string = fold_many0(parse_fragment, String::new, |mut string, fragment| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | delimited(nchar('"'), build_string, nchar('"'))(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yogurt` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "0b5d3f7c67e39ecbc82ee23864cb5accb40660f63d8d3bd8acc67eb3dc8c779e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b5d3f7c67e39ecbc82ee23864cb5accb40660f63d8d3bd8acc67eb3dc8c779e", kill_on_drop: false }` [INFO] [stdout] 0b5d3f7c67e39ecbc82ee23864cb5accb40660f63d8d3bd8acc67eb3dc8c779e