[INFO] fetching crate yggit 0.0.6... [INFO] checking yggit-0.0.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate yggit 0.0.6 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate yggit 0.0.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-0-tc2/source/rust-toolchain [INFO] started tweaking crates.io crate yggit 0.0.6 [INFO] finished tweaking crates.io crate yggit 0.0.6 [INFO] tweaked toml for crates.io crate yggit 0.0.6 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate yggit 0.0.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 550e855b41aa27e9798814ec930a151d11ec7ad6792375f28ce2698f1b6e9983 [INFO] running `Command { std: "docker" "start" "-a" "550e855b41aa27e9798814ec930a151d11ec7ad6792375f28ce2698f1b6e9983", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "550e855b41aa27e9798814ec930a151d11ec7ad6792375f28ce2698f1b6e9983", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "550e855b41aa27e9798814ec930a151d11ec7ad6792375f28ce2698f1b6e9983", kill_on_drop: false }` [INFO] [stdout] 550e855b41aa27e9798814ec930a151d11ec7ad6792375f28ce2698f1b6e9983 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9ca1db07daf3cc74f4b057c142f216a11dc63036d26b370af345c9602a5ac114 [INFO] running `Command { std: "docker" "start" "-a" "9ca1db07daf3cc74f4b057c142f216a11dc63036d26b370af345c9602a5ac114", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking terminal-prompt v0.2.3 [INFO] [stderr] Checking anstream v0.6.11 [INFO] [stderr] Checking rust_fzf v0.1.2 [INFO] [stderr] Compiling jobserver v0.1.28 [INFO] [stderr] Checking clap_builder v4.5.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling libz-sys v1.1.15 [INFO] [stderr] Compiling openssl-sys v0.9.99 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Compiling pest v2.7.7 [INFO] [stderr] Checking clap v4.5.0 [INFO] [stderr] Compiling pest_meta v2.7.7 [INFO] [stderr] Compiling pest_generator v2.7.7 [INFO] [stderr] Checking git2 v0.18.2 [INFO] [stderr] Compiling pest_derive v2.7.7 [INFO] [stderr] Checking auth-git2 v0.5.3 [INFO] [stderr] Checking yggit v0.0.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `description` is never read [INFO] [stdout] --> src/git/git.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct EnhancedCommit { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | pub description: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EnhancedCommit` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/git.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 35 | let repository = Repository::discover(path).expect("repository not found"); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let signature = Signature::now(&gitconfig.user.name, &gitconfig.user.email) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | auth: GitAuthenticator::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/git.rs:139:55 [INFO] [stdout] | [INFO] [stdout] 139 | ... .and_then(|reference| reference.peel_to_commit().ok()) [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/git.rs:230:14 [INFO] [stdout] | [INFO] [stdout] 206 | let commit = self.repository.find_commit(oid).ok()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | // Get the associated note [INFO] [stdout] 208 | let note: Option = self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | Some(EnhancedCommit { [INFO] [stdout] | ______________^ [INFO] [stdout] 231 | | id: oid, [INFO] [stdout] 232 | | title, [INFO] [stdout] 233 | | description, [INFO] [stdout] 234 | | note, [INFO] [stdout] 235 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/git.rs:221:29 [INFO] [stdout] | [INFO] [stdout] 221 | .and_then(|str| serde_json::from_str(&str).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yggit` (bin "yggit") due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `description` is never read [INFO] [stdout] --> src/git/git.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct EnhancedCommit { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | pub description: Option, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EnhancedCommit` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/git.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 35 | let repository = Repository::discover(path).expect("repository not found"); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let signature = Signature::now(&gitconfig.user.name, &gitconfig.user.email) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | auth: GitAuthenticator::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/git.rs:139:55 [INFO] [stdout] | [INFO] [stdout] 139 | ... .and_then(|reference| reference.peel_to_commit().ok()) [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/git.rs:230:14 [INFO] [stdout] | [INFO] [stdout] 206 | let commit = self.repository.find_commit(oid).ok()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | // Get the associated note [INFO] [stdout] 208 | let note: Option = self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | Some(EnhancedCommit { [INFO] [stdout] | ______________^ [INFO] [stdout] 231 | | id: oid, [INFO] [stdout] 232 | | title, [INFO] [stdout] 233 | | description, [INFO] [stdout] 234 | | note, [INFO] [stdout] 235 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git/git.rs:221:29 [INFO] [stdout] | [INFO] [stdout] 221 | .and_then(|str| serde_json::from_str(&str).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yggit` (bin "yggit" test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9ca1db07daf3cc74f4b057c142f216a11dc63036d26b370af345c9602a5ac114", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ca1db07daf3cc74f4b057c142f216a11dc63036d26b370af345c9602a5ac114", kill_on_drop: false }` [INFO] [stdout] 9ca1db07daf3cc74f4b057c142f216a11dc63036d26b370af345c9602a5ac114