[INFO] fetching crate yfelo 0.1.1... [INFO] checking yfelo-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate yfelo 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate yfelo 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate yfelo 0.1.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate yfelo 0.1.1 [INFO] tweaked toml for crates.io crate yfelo 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 57 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 80d48698b1538d39be990f20fcb9730542fd318621eeb2aac69f07df9bf05469 [INFO] running `Command { std: "docker" "start" "-a" "80d48698b1538d39be990f20fcb9730542fd318621eeb2aac69f07df9bf05469", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "80d48698b1538d39be990f20fcb9730542fd318621eeb2aac69f07df9bf05469", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "80d48698b1538d39be990f20fcb9730542fd318621eeb2aac69f07df9bf05469", kill_on_drop: false }` [INFO] [stdout] 80d48698b1538d39be990f20fcb9730542fd318621eeb2aac69f07df9bf05469 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 527ab9f39d425b5a5cc499847e7ca44943b4f0a5bd4af653b3ce649ce26701bd [INFO] running `Command { std: "docker" "start" "-a" "527ab9f39d425b5a5cc499847e7ca44943b4f0a5bd4af653b3ce649ce26701bd", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling dyn_std v0.3.3 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling dyn_derive v0.3.4 [INFO] [stderr] Checking yfelo_core v0.1.1 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling pest v2.7.11 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Checking pest_vm v2.7.11 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking yfelo v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default/context.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 29 | fn set(&self, key: String, value: Value) -> Result<(), RuntimeError> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | match self.store.borrow_mut().entry(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default/context.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 95 | init(&mut inst).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | e.as_any_box().downcast::>().unwrap().0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default/context.rs:183:29 [INFO] [stdout] | [INFO] [stdout] 182 | ... &str, args: Vec, init: &mut dyn FnMut(&mut dyn yfelo_core::Context) -> Result>) -> Re... [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | ..., &self.0.get(name), args, init) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default/operator.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn eval(&self, value: Value) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | Self::Not => Value::Bool(!value.as_bool()?), [INFO] [stdout] 23 | | Self::Pos => Value::Number(value.as_number()?), [INFO] [stdout] 24 | | Self::Neg => Value::Number(-value.as_number()?), [INFO] [stdout] 25 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default/operator.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn eval(&self, lhs: Value, rhs: Value) -> Result { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 72 | | Self::Pow => Value::Number(lhs.as_number()?.powf(rhs.as_number()?)), [INFO] [stdout] 73 | | Self::Mul => Value::Number(lhs.as_number()? * rhs.as_number()?), [INFO] [stdout] 74 | | Self::Div => Value::Number(lhs.as_number()? / rhs.as_number()?), [INFO] [stdout] ... | [INFO] [stdout] 96 | | Self::Or => Value::Bool(lhs.as_bool()? || rhs.as_bool()?), [INFO] [stdout] 97 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default/value.rs:222:18 [INFO] [stdout] | [INFO] [stdout] 221 | let k = Self::Number(k as f64); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | (Self::Ref(v.clone()), k) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default/value.rs:226:18 [INFO] [stdout] | [INFO] [stdout] 225 | let k = Self::String(k.clone()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | (Self::Ref(v.clone()), k) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default/context.rs:30:15 [INFO] [stdout] | [INFO] [stdout] 29 | fn set(&self, key: String, value: Value) -> Result<(), RuntimeError> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | match self.store.borrow_mut().entry(key) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default/context.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 95 | init(&mut inst).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | e.as_any_box().downcast::>().unwrap().0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default/context.rs:183:29 [INFO] [stdout] | [INFO] [stdout] 182 | ... &str, args: Vec, init: &mut dyn FnMut(&mut dyn yfelo_core::Context) -> Result>) -> Re... [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | ..., &self.0.get(name), args, init) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default/operator.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn eval(&self, value: Value) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | Self::Not => Value::Bool(!value.as_bool()?), [INFO] [stdout] 23 | | Self::Pos => Value::Number(value.as_number()?), [INFO] [stdout] 24 | | Self::Neg => Value::Number(-value.as_number()?), [INFO] [stdout] 25 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default/operator.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn eval(&self, lhs: Value, rhs: Value) -> Result { [INFO] [stdout] | ---------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok(match self { [INFO] [stdout] | ____________^ [INFO] [stdout] 72 | | Self::Pow => Value::Number(lhs.as_number()?.powf(rhs.as_number()?)), [INFO] [stdout] 73 | | Self::Mul => Value::Number(lhs.as_number()? * rhs.as_number()?), [INFO] [stdout] 74 | | Self::Div => Value::Number(lhs.as_number()? / rhs.as_number()?), [INFO] [stdout] ... | [INFO] [stdout] 96 | | Self::Or => Value::Bool(lhs.as_bool()? || rhs.as_bool()?), [INFO] [stdout] 97 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default/value.rs:222:18 [INFO] [stdout] | [INFO] [stdout] 221 | let k = Self::Number(k as f64); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 222 | (Self::Ref(v.clone()), k) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/default/value.rs:226:18 [INFO] [stdout] | [INFO] [stdout] 225 | let k = Self::String(k.clone()); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | (Self::Ref(v.clone()), k) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yfelo` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `yfelo` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "527ab9f39d425b5a5cc499847e7ca44943b4f0a5bd4af653b3ce649ce26701bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "527ab9f39d425b5a5cc499847e7ca44943b4f0a5bd4af653b3ce649ce26701bd", kill_on_drop: false }` [INFO] [stdout] 527ab9f39d425b5a5cc499847e7ca44943b4f0a5bd4af653b3ce649ce26701bd