[INFO] fetching crate yatima-rustyline 0.2.0... [INFO] checking yatima-rustyline-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate yatima-rustyline 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate yatima-rustyline 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate yatima-rustyline 0.2.0 [INFO] finished tweaking crates.io crate yatima-rustyline 0.2.0 [INFO] tweaked toml for crates.io crate yatima-rustyline 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate yatima-rustyline 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cdbb618e8cbe452a05a3c063cf2fad31add5b7ca30711862c9cf8b399c2530c3 [INFO] running `Command { std: "docker" "start" "-a" "cdbb618e8cbe452a05a3c063cf2fad31add5b7ca30711862c9cf8b399c2530c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cdbb618e8cbe452a05a3c063cf2fad31add5b7ca30711862c9cf8b399c2530c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cdbb618e8cbe452a05a3c063cf2fad31add5b7ca30711862c9cf8b399c2530c3", kill_on_drop: false }` [INFO] [stdout] cdbb618e8cbe452a05a3c063cf2fad31add5b7ca30711862c9cf8b399c2530c3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 004886d73184241f890ccfb035f4f1c129081518a9443e21e2d315e119e48a87 [INFO] running `Command { std: "docker" "start" "-a" "004886d73184241f890ccfb035f4f1c129081518a9443e21e2d315e119e48a87", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling io-lifetimes v0.7.3 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling rustix v0.35.9 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking linux-raw-sys v0.0.46 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking unicode-segmentation v1.9.0 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking nix v0.24.2 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking fd-lock v3.0.6 [INFO] [stderr] Checking yatima-rustyline v0.2.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling yatima-rustyline-derive v0.1.0 [INFO] [stdout] warning: unused import: `self::unix::*` [INFO] [stdout] --> src/tty/mod.rs:266:9 [INFO] [stdout] | [INFO] [stdout] 266 | pub use self::unix::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:603:12 [INFO] [stdout] | [INFO] [stdout] 596 | let term = Terminal::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 603 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 604 | | term, [INFO] [stdout] 605 | | history: History::with_config(config), [INFO] [stdout] 606 | | helper: None, [INFO] [stdout] ... | [INFO] [stdout] 609 | | custom_bindings: Bindings::new(), [INFO] [stdout] 610 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:839:55 [INFO] [stdout] | [INFO] [stdout] 835 | key_seq: E, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 836 | handler: R, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 839 | .insert(Event::normalize(key_seq.into()), handler.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/line_buffer.rs:242:23 [INFO] [stdout] | [INFO] [stdout] 242 | for cl in &self.cl { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 242 | while let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 242 | if let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/line_buffer.rs:845:19 [INFO] [stdout] | [INFO] [stdout] 845 | for cl in &self.cl { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 845 | while let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 845 | if let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/line_buffer.rs:863:19 [INFO] [stdout] | [INFO] [stdout] 863 | for cl in &self.cl { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 863 | while let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 863 | if let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/line_buffer.rs:885:19 [INFO] [stdout] | [INFO] [stdout] 885 | for dl in &self.dl { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 885 | while let Some(dl) = &self.dl { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 885 | if let Some(dl) = &self.dl { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/line_buffer.rs:891:19 [INFO] [stdout] | [INFO] [stdout] 891 | for cl in &self.cl { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 891 | while let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 891 | if let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:233:21 [INFO] [stdout] | [INFO] [stdout] 230 | pipe_reader: Option, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | tty_in: BufReader::with_capacity(1024, TtyIn { fd, sigwinch_pipe }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:708:23 [INFO] [stdout] | [INFO] [stdout] 708 | .map(|pr| pr.lock().unwrap().0.as_raw_fd()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:1291:12 [INFO] [stdout] | [INFO] [stdout] 1261 | let tty = OpenOptions::new().read(true).write(true).open("/dev/tty"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1262 | if let Ok(tty) = tty { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1291 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1292 | | unsupported, [INFO] [stdout] 1293 | | tty_in, [INFO] [stdout] 1294 | | is_in_a_tty, [INFO] [stdout] ... | [INFO] [stdout] 1305 | | sigwinch, [INFO] [stdout] 1306 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:1437:12 [INFO] [stdout] | [INFO] [stdout] 1428 | let (sender, receiver) = mpsc::sync_channel(1); // TODO validate: bound [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1429 | let (r, w) = pipe()?; [INFO] [stdout] 1430 | let reader = Arc::new(Mutex::new((unsafe { File::from_raw_fd(r) }, receiver))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1431 | let writer = ( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1437 | Ok(ExternalPrinter { [INFO] [stdout] | ____________^ [INFO] [stdout] 1438 | | writer, [INFO] [stdout] 1439 | | raw_mode: self.raw_mode.clone(), [INFO] [stdout] 1440 | | tty_out: self.tty_out, [INFO] [stdout] 1441 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yatima-rustyline` (lib) due to 7 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:603:12 [INFO] [stdout] | [INFO] [stdout] 603 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 604 | | term, [INFO] [stdout] 605 | | history: History::with_config(config), [INFO] [stdout] 606 | | helper: None, [INFO] [stdout] ... | [INFO] [stdout] 609 | | custom_bindings: Bindings::new(), [INFO] [stdout] 610 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:839:55 [INFO] [stdout] | [INFO] [stdout] 835 | key_seq: E, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 836 | handler: R, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 839 | .insert(Event::normalize(key_seq.into()), handler.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/line_buffer.rs:242:23 [INFO] [stdout] | [INFO] [stdout] 242 | for cl in &self.cl { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 242 | while let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 242 | if let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/line_buffer.rs:845:19 [INFO] [stdout] | [INFO] [stdout] 845 | for cl in &self.cl { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 845 | while let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 845 | if let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/line_buffer.rs:863:19 [INFO] [stdout] | [INFO] [stdout] 863 | for cl in &self.cl { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 863 | while let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 863 | if let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/line_buffer.rs:885:19 [INFO] [stdout] | [INFO] [stdout] 885 | for dl in &self.dl { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 885 | while let Some(dl) = &self.dl { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 885 | if let Some(dl) = &self.dl { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/line_buffer.rs:891:19 [INFO] [stdout] | [INFO] [stdout] 891 | for cl in &self.cl { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 891 | while let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 891 | if let Some(cl) = &self.cl { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:233:21 [INFO] [stdout] | [INFO] [stdout] 230 | pipe_reader: Option, [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | tty_in: BufReader::with_capacity(1024, TtyIn { fd, sigwinch_pipe }), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:708:23 [INFO] [stdout] | [INFO] [stdout] 708 | .map(|pr| pr.lock().unwrap().0.as_raw_fd()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:1291:12 [INFO] [stdout] | [INFO] [stdout] 1261 | let tty = OpenOptions::new().read(true).write(true).open("/dev/tty"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1262 | if let Ok(tty) = tty { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1291 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1292 | | unsupported, [INFO] [stdout] 1293 | | tty_in, [INFO] [stdout] 1294 | | is_in_a_tty, [INFO] [stdout] ... | [INFO] [stdout] 1305 | | sigwinch, [INFO] [stdout] 1306 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tty/unix.rs:1437:12 [INFO] [stdout] | [INFO] [stdout] 1428 | let (sender, receiver) = mpsc::sync_channel(1); // TODO validate: bound [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1429 | let (r, w) = pipe()?; [INFO] [stdout] 1430 | let reader = Arc::new(Mutex::new((unsafe { File::from_raw_fd(r) }, receiver))); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1431 | let writer = ( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1437 | Ok(ExternalPrinter { [INFO] [stdout] | ____________^ [INFO] [stdout] 1438 | | writer, [INFO] [stdout] 1439 | | raw_mode: self.raw_mode.clone(), [INFO] [stdout] 1440 | | tty_out: self.tty_out, [INFO] [stdout] 1441 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yatima-rustyline` (lib test) due to 7 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "004886d73184241f890ccfb035f4f1c129081518a9443e21e2d315e119e48a87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "004886d73184241f890ccfb035f4f1c129081518a9443e21e2d315e119e48a87", kill_on_drop: false }` [INFO] [stdout] 004886d73184241f890ccfb035f4f1c129081518a9443e21e2d315e119e48a87