[INFO] fetching crate yash-semantics 0.3.0... [INFO] checking yash-semantics-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate yash-semantics 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate yash-semantics 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate yash-semantics 0.3.0 [INFO] finished tweaking crates.io crate yash-semantics 0.3.0 [INFO] tweaked toml for crates.io crate yash-semantics 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 67 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding nix v0.27.1 (latest: v0.29.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding yash-env v0.2.1 (latest: v0.3.0) [INFO] [stderr] Adding yash-syntax v0.10.0 (latest: v0.11.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4905e976931904b381bf98ead0a3c07a645270296857d7d5adcda12fc3b0c6a7 [INFO] running `Command { std: "docker" "start" "-a" "4905e976931904b381bf98ead0a3c07a645270296857d7d5adcda12fc3b0c6a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4905e976931904b381bf98ead0a3c07a645270296857d7d5adcda12fc3b0c6a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4905e976931904b381bf98ead0a3c07a645270296857d7d5adcda12fc3b0c6a7", kill_on_drop: false }` [INFO] [stdout] 4905e976931904b381bf98ead0a3c07a645270296857d7d5adcda12fc3b0c6a7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f758d818954cafea8884860a07703985b063871c8074da024c8c93990b59ff59 [INFO] running `Command { std: "docker" "start" "-a" "f758d818954cafea8884860a07703985b063871c8074da024c8c93990b59ff59", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking annotate-snippets v0.11.4 [INFO] [stderr] Checking yash-quote v1.1.1 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking yash-arith v0.2.1 [INFO] [stderr] Checking yash-fnmatch v1.1.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling enumset_derive v0.10.0 [INFO] [stderr] Checking yash-syntax v0.10.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking enumset v1.1.5 [INFO] [stderr] Checking yash-env v0.2.1 [INFO] [stderr] Checking yash-env-test-helper v0.1.0 [INFO] [stderr] Checking yash-semantics v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/compound_command/subshell.rs:37:67 [INFO] [stdout] | [INFO] [stdout] 37 | let subshell = Subshell::new(|sub_env, _job_control| Box::pin(subshell_main(sub_env, body_2))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/simple_command/external.rs:108:18 [INFO] [stdout] | [INFO] [stdout] 95 | path: CString, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let args = to_c_strings(fields); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let subshell = Subshell::new(move |env, _job_control| { [INFO] [stdout] 108 | Box::pin(replace_current_process(env, path, args, location)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion/initial/command_subst.rs:59:18 [INFO] [stdout] | [INFO] [stdout] 40 | pub async fn expand(command: C, location: Location, env: &mut Env<'_>) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 60 | | let result = subshell_body(env, reader, writer, original, command).await; [INFO] [stdout] 61 | | env.apply_result(result); [INFO] [stdout] 62 | | run_exit_trap(env).await; [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion/initial/tilde.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 25 | fn into_attr_chars(i: I) -> Vec [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | / i.into_iter() [INFO] [stdout] 30 | | .map(|c| AttrChar { [INFO] [stdout] 31 | | value: c, [INFO] [stdout] 32 | | origin: Origin::HardExpansion, [INFO] [stdout] 33 | | is_quoted: false, [INFO] [stdout] 34 | | is_quoting: false, [INFO] [stdout] 35 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion/quote_removal.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn skip_quotes(iter: I) -> impl Iterator [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | iter.into_iter().filter(|c| !c.is_quoting) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion/split/ranges.rs:59:20 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn ranges(&'a self, field_chars: I) -> Ranges<'a, I::IntoIter> [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | inner: field_chars.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redir.rs:387:13 [INFO] [stdout] | [INFO] [stdout] 381 | let cause = match expected_mode { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 387 | Err(Error { cause, location }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yash-semantics` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/compound_command/subshell.rs:37:67 [INFO] [stdout] | [INFO] [stdout] 37 | let subshell = Subshell::new(|sub_env, _job_control| Box::pin(subshell_main(sub_env, body_2))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/simple_command/external.rs:108:18 [INFO] [stdout] | [INFO] [stdout] 95 | path: CString, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let args = to_c_strings(fields); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let subshell = Subshell::new(move |env, _job_control| { [INFO] [stdout] 108 | Box::pin(replace_current_process(env, path, args, location)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion/glob.rs:325:26 [INFO] [stdout] | [INFO] [stdout] 314 | fn env_with_dummy_files(paths: I) -> Env [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | let system = VirtualSystem::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 320 | let mut state = system.state.borrow_mut(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 325 | Env::with_system(Box::new(system)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion/initial/command_subst.rs:59:18 [INFO] [stdout] | [INFO] [stdout] 40 | pub async fn expand(command: C, location: Location, env: &mut Env<'_>) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Box::pin(async move { [INFO] [stdout] | __________________^ [INFO] [stdout] 60 | | let result = subshell_body(env, reader, writer, original, command).await; [INFO] [stdout] 61 | | env.apply_result(result); [INFO] [stdout] 62 | | run_exit_trap(env).await; [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion/initial/tilde.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 25 | fn into_attr_chars(i: I) -> Vec [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | / i.into_iter() [INFO] [stdout] 30 | | .map(|c| AttrChar { [INFO] [stdout] 31 | | value: c, [INFO] [stdout] 32 | | origin: Origin::HardExpansion, [INFO] [stdout] 33 | | is_quoted: false, [INFO] [stdout] 34 | | is_quoting: false, [INFO] [stdout] 35 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion/quote_removal.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn skip_quotes(iter: I) -> impl Iterator [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | iter.into_iter().filter(|c| !c.is_quoting) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expansion/split/ranges.rs:59:20 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn ranges(&'a self, field_chars: I) -> Ranges<'a, I::IntoIter> [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | inner: field_chars.into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redir.rs:387:13 [INFO] [stdout] | [INFO] [stdout] 381 | let cause = match expected_mode { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 387 | Err(Error { cause, location }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yash-semantics` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "f758d818954cafea8884860a07703985b063871c8074da024c8c93990b59ff59", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f758d818954cafea8884860a07703985b063871c8074da024c8c93990b59ff59", kill_on_drop: false }` [INFO] [stdout] f758d818954cafea8884860a07703985b063871c8074da024c8c93990b59ff59