[INFO] fetching crate yarte_helpers 0.15.8... [INFO] checking yarte_helpers-0.15.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate yarte_helpers 0.15.8 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate yarte_helpers 0.15.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate yarte_helpers 0.15.8 [INFO] finished tweaking crates.io crate yarte_helpers 0.15.8 [INFO] tweaked toml for crates.io crate yarte_helpers 0.15.8 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 52 packages to latest compatible versions [INFO] [stderr] Adding prettyplease v0.1.25 (latest: v0.2.22) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 941fb79e60bdd9f3aafa026f6c165c8f5c2f09f626a4ce010c994094c7b85091 [INFO] running `Command { std: "docker" "start" "-a" "941fb79e60bdd9f3aafa026f6c165c8f5c2f09f626a4ce010c994094c7b85091", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "941fb79e60bdd9f3aafa026f6c165c8f5c2f09f626a4ce010c994094c7b85091", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "941fb79e60bdd9f3aafa026f6c165c8f5c2f09f626a4ce010c994094c7b85091", kill_on_drop: false }` [INFO] [stdout] 941fb79e60bdd9f3aafa026f6c165c8f5c2f09f626a4ce010c994094c7b85091 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 14101a251a98913e5c2fe2a46d2b03cea6ee5da072050d7564a3086e859d1eaf [INFO] running `Command { std: "docker" "start" "-a" "14101a251a98913e5c2fe2a46d2b03cea6ee5da072050d7564a3086e859d1eaf", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling v_htmlescape v0.15.8 [INFO] [stderr] Compiling random-trait v0.1.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking dtoa v1.0.9 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling prettyplease v0.1.25 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking random-fast-rng v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking yarte_helpers v0.15.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `fixed` [INFO] [stdout] --> src/helpers/mod.rs:26:7 [INFO] [stdout] | [INFO] [stdout] 26 | #[cfg(feature = "fixed")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `big-num-32`, `buf-min`, `bytes-buf`, `chrono`, `config`, `default`, `display-fn`, `dtoa`, `extra-renders`, `itoa`, `json`, `logger`, `markup`, `prettyplease`, `render-uuid`, `ryu`, `ryu-ad`, `serde`, `serde_json`, `syn`, `toml`, `uuid`, `v_htmlescape`, and `v_jsonescape` [INFO] [stdout] = help: consider adding `fixed` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `fixed` [INFO] [stdout] --> src/helpers/mod.rs:26:7 [INFO] [stdout] | [INFO] [stdout] 26 | #[cfg(feature = "fixed")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `big-num-32`, `buf-min`, `bytes-buf`, `chrono`, `config`, `default`, `display-fn`, `dtoa`, `extra-renders`, `itoa`, `json`, `logger`, `markup`, `prettyplease`, `render-uuid`, `ryu`, `ryu-ad`, `serde`, `serde_json`, `syn`, `toml`, `uuid`, `v_htmlescape`, and `v_jsonescape` [INFO] [stdout] = help: consider adding `fixed` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/helpers/integers/mod.rs:311:27 [INFO] [stdout] | [INFO] [stdout] 311 | let slot = &*(&FN as *const _ as *const AtomicUsize); [INFO] [stdout] | ^^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 319 | detect_fn!(write_u32, u32); [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `detect_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 311 | let slot = &*(addr_of!(FN) as *const _ as *const AtomicUsize); [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/helpers/integers/mod.rs:306:40 [INFO] [stdout] | [INFO] [stdout] 306 | let slot = unsafe { &*(&FN as *const _ as *const AtomicUsize) }; [INFO] [stdout] | ^^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 319 | detect_fn!(write_u32, u32); [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] = note: this warning originates in the macro `detect_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 306 | let slot = unsafe { &*(addr_of!(FN) as *const _ as *const AtomicUsize) }; [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/helpers/integers/mod.rs:311:27 [INFO] [stdout] | [INFO] [stdout] 311 | let slot = &*(&FN as *const _ as *const AtomicUsize); [INFO] [stdout] | ^^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 321 | detect_fn!(write_u64, u64); [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] = note: this warning originates in the macro `detect_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 311 | let slot = &*(addr_of!(FN) as *const _ as *const AtomicUsize); [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/helpers/integers/mod.rs:306:40 [INFO] [stdout] | [INFO] [stdout] 306 | let slot = unsafe { &*(&FN as *const _ as *const AtomicUsize) }; [INFO] [stdout] | ^^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 321 | detect_fn!(write_u64, u64); [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] = note: this warning originates in the macro `detect_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 306 | let slot = unsafe { &*(addr_of!(FN) as *const _ as *const AtomicUsize) }; [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/helpers/integers/mod.rs:311:27 [INFO] [stdout] | [INFO] [stdout] 311 | let slot = &*(&FN as *const _ as *const AtomicUsize); [INFO] [stdout] | ^^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 319 | detect_fn!(write_u32, u32); [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `detect_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 311 | let slot = &*(addr_of!(FN) as *const _ as *const AtomicUsize); [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/helpers/integers/mod.rs:306:40 [INFO] [stdout] | [INFO] [stdout] 306 | let slot = unsafe { &*(&FN as *const _ as *const AtomicUsize) }; [INFO] [stdout] | ^^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 319 | detect_fn!(write_u32, u32); [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] = note: this warning originates in the macro `detect_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 306 | let slot = unsafe { &*(addr_of!(FN) as *const _ as *const AtomicUsize) }; [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/helpers/integers/mod.rs:311:27 [INFO] [stdout] | [INFO] [stdout] 311 | let slot = &*(&FN as *const _ as *const AtomicUsize); [INFO] [stdout] | ^^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 321 | detect_fn!(write_u64, u64); [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] = note: this warning originates in the macro `detect_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 311 | let slot = &*(addr_of!(FN) as *const _ as *const AtomicUsize); [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/helpers/integers/mod.rs:306:40 [INFO] [stdout] | [INFO] [stdout] 306 | let slot = unsafe { &*(&FN as *const _ as *const AtomicUsize) }; [INFO] [stdout] | ^^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 321 | detect_fn!(write_u64, u64); [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] = note: this warning originates in the macro `detect_fn` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 306 | let slot = unsafe { &*(addr_of!(FN) as *const _ as *const AtomicUsize) }; [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/io_fmt.rs:42:32 [INFO] [stdout] | [INFO] [stdout] 42 | DisplayFn::new(|f| serde_json::to_writer(IoFmt::new(f), &j).map_err(|_| fmt::Error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/io_fmt.rs:49:21 [INFO] [stdout] | [INFO] [stdout] 49 | |f| serde_json::to_writer_pretty(IoFmt::new(f), &j).map_err(|_| fmt::Error) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/display_fn.rs:14:14 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Self(Cell::new(Some(f))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers/display_fn.rs:14:14 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn new(f: F) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Self(Cell::new(Some(f))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yarte_helpers` (lib test) due to 4 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `yarte_helpers` (lib) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "14101a251a98913e5c2fe2a46d2b03cea6ee5da072050d7564a3086e859d1eaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14101a251a98913e5c2fe2a46d2b03cea6ee5da072050d7564a3086e859d1eaf", kill_on_drop: false }` [INFO] [stdout] 14101a251a98913e5c2fe2a46d2b03cea6ee5da072050d7564a3086e859d1eaf