[INFO] fetching crate yaml-subset 0.1.18... [INFO] checking yaml-subset-0.1.18 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate yaml-subset 0.1.18 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate yaml-subset 0.1.18 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate yaml-subset 0.1.18 [INFO] finished tweaking crates.io crate yaml-subset 0.1.18 [INFO] tweaked toml for crates.io crate yaml-subset 0.1.18 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 47 packages to latest compatible versions [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c1ee78139cda357f089ef9d35acc7aee1784c1d7a967df753f1d5a9810fc93b8 [INFO] running `Command { std: "docker" "start" "-a" "c1ee78139cda357f089ef9d35acc7aee1784c1d7a967df753f1d5a9810fc93b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c1ee78139cda357f089ef9d35acc7aee1784c1d7a967df753f1d5a9810fc93b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1ee78139cda357f089ef9d35acc7aee1784c1d7a967df753f1d5a9810fc93b8", kill_on_drop: false }` [INFO] [stdout] c1ee78139cda357f089ef9d35acc7aee1784c1d7a967df753f1d5a9810fc93b8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d909d42f5b8ebdc767c41debbf20e9f57bb2bff527d08610c6d042ea422ef0b3 [INFO] running `Command { std: "docker" "start" "-a" "d909d42f5b8ebdc767c41debbf20e9f57bb2bff527d08610c6d042ea422ef0b3", kill_on_drop: false }` [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking similar v2.6.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Compiling pest_consume_macros v1.1.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking pest v2.7.11 [INFO] [stderr] Checking insta v1.39.0 [INFO] [stderr] Compiling pest_meta v2.7.11 [INFO] [stderr] Compiling pest_generator v2.7.11 [INFO] [stderr] Compiling pest_derive v2.7.11 [INFO] [stderr] Checking pest_consume v1.1.3 [INFO] [stderr] Checking yaml-subset v0.1.18 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:98:9 [INFO] [stdout] | [INFO] [stdout] 98 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:273:9 [INFO] [stdout] | [INFO] [stdout] 273 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:291:9 [INFO] [stdout] | [INFO] [stdout] 291 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:302:9 [INFO] [stdout] | [INFO] [stdout] 302 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:316:9 [INFO] [stdout] | [INFO] [stdout] 316 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:330:9 [INFO] [stdout] | [INFO] [stdout] 330 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `insta::assert_display_snapshot`: use assert_snapshot!() instead [INFO] [stdout] --> src/lib.rs:816:9 [INFO] [stdout] | [INFO] [stdout] 816 | insta::assert_display_snapshot!(parsed.unwrap().format().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `should_write_literal` is never used [INFO] [stdout] --> src/utils.rs:5:4 [INFO] [stdout] | [INFO] [stdout] 5 | fn should_write_literal(s: &String) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `needs_quotes` is never used [INFO] [stdout] --> src/utils.rs:9:4 [INFO] [stdout] | [INFO] [stdout] 9 | fn needs_quotes(s: &String) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/yaml/mod.rs:475:9 [INFO] [stdout] | [INFO] [stdout] 474 | fn pretty(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 475 | self.into_iter().map(|x| x.pretty()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/yaml/insert.rs:23:14 [INFO] [stdout] | [INFO] [stdout] 22 | fn add(self, rhs: MyVec) -> Self::Output { [INFO] [stdout] | ---- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Self(self.0.into_iter().chain(rhs.0.into_iter()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yaml-subset` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `should_write_literal` is never used [INFO] [stdout] --> src/utils.rs:5:4 [INFO] [stdout] | [INFO] [stdout] 5 | fn should_write_literal(s: &String) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `needs_quotes` is never used [INFO] [stdout] --> src/utils.rs:9:4 [INFO] [stdout] | [INFO] [stdout] 9 | fn needs_quotes(s: &String) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/yaml/mod.rs:475:9 [INFO] [stdout] | [INFO] [stdout] 474 | fn pretty(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 475 | self.into_iter().map(|x| x.pretty()).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/yaml/insert.rs:23:14 [INFO] [stdout] | [INFO] [stdout] 22 | fn add(self, rhs: MyVec) -> Self::Output { [INFO] [stdout] | ---- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Self(self.0.into_iter().chain(rhs.0.into_iter()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yaml-subset` (lib test) due to 3 previous errors; 17 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d909d42f5b8ebdc767c41debbf20e9f57bb2bff527d08610c6d042ea422ef0b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d909d42f5b8ebdc767c41debbf20e9f57bb2bff527d08610c6d042ea422ef0b3", kill_on_drop: false }` [INFO] [stdout] d909d42f5b8ebdc767c41debbf20e9f57bb2bff527d08610c6d042ea422ef0b3