[INFO] fetching crate yaks 0.1.0... [INFO] checking yaks-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate yaks 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate yaks 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate yaks 0.1.0 [INFO] finished tweaking crates.io crate yaks 0.1.0 [INFO] tweaked toml for crates.io crate yaks 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate yaks 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 73c554d79ad44810e4c31752af5924384d065f6f658b45c803c780b49ed6313f [INFO] running `Command { std: "docker" "start" "-a" "73c554d79ad44810e4c31752af5924384d065f6f658b45c803c780b49ed6313f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "73c554d79ad44810e4c31752af5924384d065f6f658b45c803c780b49ed6313f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73c554d79ad44810e4c31752af5924384d065f6f658b45c803c780b49ed6313f", kill_on_drop: false }` [INFO] [stdout] 73c554d79ad44810e4c31752af5924384d065f6f658b45c803c780b49ed6313f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d3fc2b385fb9ccbf4def193c7c248a27969c7fc8b65303ef179996e6b752811 [INFO] running `Command { std: "docker" "start" "-a" "4d3fc2b385fb9ccbf4def193c7c248a27969c7fc8b65303ef179996e6b752811", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.7 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling syn v1.0.13 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Checking smallvec v1.1.0 [INFO] [stderr] Checking ahash v0.3.2 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking fixedbitset v0.3.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling hashbrown v0.7.0 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking hecs v0.2.12 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking crossbeam-channel v0.4.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Compiling paste-impl v0.1.16 [INFO] [stderr] Checking paste v0.1.16 [INFO] [stderr] Checking yaks v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 75 | pub(crate) fn build(builder: ExecutorBuilder<'closures, Resources, Handle>) -> Self { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | inner: ExecutorParallel::build(builder), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor_parallel.rs:119:38 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn build(builder: ExecutorBuilder<'closures, Resources, Handle>) -> Self { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | mut systems, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | mut all_component_types, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let mut systems: HashMap> = systems [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let (sender, receiver) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | ExecutorParallel::Scheduling(Scheduler { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 120 | | borrows: Resources::instantiate_borrows(), [INFO] [stdout] 121 | | systems, [INFO] [stdout] 122 | | archetypes_generation: None, [INFO] [stdout] ... | [INFO] [stdout] 129 | | receiver, [INFO] [stdout] 130 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor_parallel.rs:55:21 [INFO] [stdout] | [INFO] [stdout] 46 | .map(|(id, system)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | / System { [INFO] [stdout] 56 | | closure: Arc::new(Mutex::new(system.closure)), [INFO] [stdout] 57 | | resource_set: system.resource_set, [INFO] [stdout] 58 | | component_set: system.component_type_set.condense(&all_component_types), [INFO] [stdout] ... | [INFO] [stdout] 63 | | unsatisfied_dependencies: 0, [INFO] [stdout] 64 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yaks` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:78:20 [INFO] [stdout] | [INFO] [stdout] 75 | pub(crate) fn build(builder: ExecutorBuilder<'closures, Resources, Handle>) -> Self { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | inner: ExecutorParallel::build(builder), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor_parallel.rs:119:38 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn build(builder: ExecutorBuilder<'closures, Resources, Handle>) -> Self { [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | mut systems, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | mut all_component_types, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let mut systems: HashMap> = systems [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | let (sender, receiver) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | ExecutorParallel::Scheduling(Scheduler { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 120 | | borrows: Resources::instantiate_borrows(), [INFO] [stdout] 121 | | systems, [INFO] [stdout] 122 | | archetypes_generation: None, [INFO] [stdout] ... | [INFO] [stdout] 129 | | receiver, [INFO] [stdout] 130 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor_parallel.rs:55:21 [INFO] [stdout] | [INFO] [stdout] 46 | .map(|(id, system)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | / System { [INFO] [stdout] 56 | | closure: Arc::new(Mutex::new(system.closure)), [INFO] [stdout] 57 | | resource_set: system.resource_set, [INFO] [stdout] 58 | | component_set: system.component_type_set.condense(&all_component_types), [INFO] [stdout] ... | [INFO] [stdout] 63 | | unsatisfied_dependencies: 0, [INFO] [stdout] 64 | | }, [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yaks` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "4d3fc2b385fb9ccbf4def193c7c248a27969c7fc8b65303ef179996e6b752811", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d3fc2b385fb9ccbf4def193c7c248a27969c7fc8b65303ef179996e6b752811", kill_on_drop: false }` [INFO] [stdout] 4d3fc2b385fb9ccbf4def193c7c248a27969c7fc8b65303ef179996e6b752811