[INFO] fetching crate yake-rust 0.1.8... [INFO] checking yake-rust-0.1.8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate yake-rust 0.1.8 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate yake-rust 0.1.8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate yake-rust 0.1.8 [INFO] finished tweaking crates.io crate yake-rust 0.1.8 [INFO] tweaked toml for crates.io crate yake-rust 0.1.8 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 24 packages to latest compatible versions [INFO] [stderr] Adding natural v0.3.0 (latest: v0.5.0) [INFO] [stderr] Adding streaming-stats v0.1.29 (latest: v0.2.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29c8a5452b104e9660ab7ba97d034ab563446af479a9f0c991a405d6cb6cbde2 [INFO] running `Command { std: "docker" "start" "-a" "29c8a5452b104e9660ab7ba97d034ab563446af479a9f0c991a405d6cb6cbde2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29c8a5452b104e9660ab7ba97d034ab563446af479a9f0c991a405d6cb6cbde2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29c8a5452b104e9660ab7ba97d034ab563446af479a9f0c991a405d6cb6cbde2", kill_on_drop: false }` [INFO] [stdout] 29c8a5452b104e9660ab7ba97d034ab563446af479a9f0c991a405d6cb6cbde2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a79dc6570389057e3d461daf9e6bd2bbebbeae321f8a557e3d84a299d53c5d6d [INFO] running `Command { std: "docker" "start" "-a" "a79dc6570389057e3d461daf9e6bd2bbebbeae321f8a557e3d84a299d53c5d6d", kill_on_drop: false }` [INFO] [stderr] Checking natural v0.3.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking streaming-stats v0.1.29 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_regex v1.1.0 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking contractions v0.5.4 [INFO] [stderr] Checking yake-rust v0.1.8 (/opt/rustwide/workdir) [INFO] [stdout] warning: value assigned to `distance` is never read [INFO] [stdout] --> src/levenshtein.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | let mut distance = 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `distance` is never read [INFO] [stdout] --> src/levenshtein.rs:8:17 [INFO] [stdout] | [INFO] [stdout] 8 | let mut distance = 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `ignore_urls` and `expand_contractions` are never read [INFO] [stdout] --> src/preprocessor.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Preprocessor { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 4 | pub text: String, [INFO] [stdout] 5 | pub ignore_urls: bool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 6 | pub expand_contractions: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:21 [INFO] [stdout] | [INFO] [stdout] 111 | let default_stopwords = stopwords::StopWords::new().words; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let default_punctuation = HashSet::from_iter( vec!["!", "\"", "#", "$", "%", "&", "'", "(", ")", "*", "+", ",", "-", ".", "/", ":... [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | config: Config { [INFO] [stdout] | _____________________^ [INFO] [stdout] 117 | | window_size: 2, [INFO] [stdout] 118 | | ngram: default_ngram, [INFO] [stdout] 119 | | dedupe_lim: 0.8, [INFO] [stdout] ... | [INFO] [stdout] 122 | | remove_duplicates: default_remove_duplicates, [INFO] [stdout] 123 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&Vec` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:276:35 [INFO] [stdout] | [INFO] [stdout] 276 | for occurrence in word.clone() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:421:45 [INFO] [stdout] | [INFO] [stdout] 421 | if words.clone().iter().any(|w| HashSet::from_iter(vec![w.to_owned()]).is_subset(&self.config.punctuation)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yake-rust` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `ignore_urls` and `expand_contractions` are never read [INFO] [stdout] --> src/preprocessor.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Preprocessor { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 4 | pub text: String, [INFO] [stdout] 5 | pub ignore_urls: bool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 6 | pub expand_contractions: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Results` is never used [INFO] [stdout] --> src/lib.rs:482:10 [INFO] [stdout] | [INFO] [stdout] 482 | type Results = Vec; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `keywords` is never used [INFO] [stdout] --> src/lib.rs:485:8 [INFO] [stdout] | [INFO] [stdout] 485 | fn keywords() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:116:21 [INFO] [stdout] | [INFO] [stdout] 111 | let default_stopwords = stopwords::StopWords::new().words; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let default_punctuation = HashSet::from_iter( vec!["!", "\"", "#", "$", "%", "&", "'", "(", ")", "*", "+", ",", "-", ".", "/", ":... [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | config: Config { [INFO] [stdout] | _____________________^ [INFO] [stdout] 117 | | window_size: 2, [INFO] [stdout] 118 | | ngram: default_ngram, [INFO] [stdout] 119 | | dedupe_lim: 0.8, [INFO] [stdout] ... | [INFO] [stdout] 122 | | remove_duplicates: default_remove_duplicates, [INFO] [stdout] 123 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&Vec` instead of cloning the inner type [INFO] [stdout] --> src/lib.rs:276:35 [INFO] [stdout] | [INFO] [stdout] 276 | for occurrence in word.clone() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:421:45 [INFO] [stdout] | [INFO] [stdout] 421 | if words.clone().iter().any(|w| HashSet::from_iter(vec![w.to_owned()]).is_subset(&self.config.punctuation)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `yake-rust` (lib test) due to 3 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a79dc6570389057e3d461daf9e6bd2bbebbeae321f8a557e3d84a299d53c5d6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a79dc6570389057e3d461daf9e6bd2bbebbeae321f8a557e3d84a299d53c5d6d", kill_on_drop: false }` [INFO] [stdout] a79dc6570389057e3d461daf9e6bd2bbebbeae321f8a557e3d84a299d53c5d6d