[INFO] fetching crate xxv 0.1.2... [INFO] checking xxv-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xxv 0.1.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate xxv 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xxv 0.1.2 [INFO] finished tweaking crates.io crate xxv 0.1.2 [INFO] tweaked toml for crates.io crate xxv 0.1.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate xxv 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e0027b2482db807aee1683cbd246d791a4e723bbf3f6f55d167a8c2a2ff48fba [INFO] running `Command { std: "docker" "start" "-a" "e0027b2482db807aee1683cbd246d791a4e723bbf3f6f55d167a8c2a2ff48fba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e0027b2482db807aee1683cbd246d791a4e723bbf3f6f55d167a8c2a2ff48fba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e0027b2482db807aee1683cbd246d791a4e723bbf3f6f55d167a8c2a2ff48fba", kill_on_drop: false }` [INFO] [stdout] e0027b2482db807aee1683cbd246d791a4e723bbf3f6f55d167a8c2a2ff48fba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 689c4a022df57056c2a3db72ae94bbc3350d38498cc907abfdb2f7073a3e70d3 [INFO] running `Command { std: "docker" "start" "-a" "689c4a022df57056c2a3db72ae94bbc3350d38498cc907abfdb2f7073a3e70d3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Compiling fnv v1.0.6 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Checking arc-swap v0.4.4 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Compiling num-rational v0.2.3 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-iter v0.1.40 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling memchr v2.3.2 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking array-macro v1.0.4 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking xi-unicode v0.2.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking unicode-segmentation v1.6.0 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking bstr v0.2.11 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Compiling ncurses v5.99.0 [INFO] [stderr] Checking crossbeam-channel v0.4.0 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking signal-hook-registry v1.2.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking rio v0.9.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking directories v2.0.2 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking signal-hook v0.1.13 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rmp v0.8.9 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking chrono v0.4.10 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking backtrace v0.3.44 [INFO] [stderr] Checking rmp-serde v0.13.7 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Compiling enum-map-derive v0.4.3 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Checking enum-map v0.6.2 [INFO] [stderr] Compiling const-random-macro v0.1.8 [INFO] [stderr] Checking const-random v0.1.8 [INFO] [stderr] Checking ahash v0.2.18 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling enumset_derive v0.4.4 [INFO] [stderr] Checking enumset v0.4.5 [INFO] [stderr] Checking cursive v0.14.0 [INFO] [stderr] Checking xxv v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/panic_hook.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | use std::panic::PanicInfo; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/panic_hook.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | panic::set_hook(Box::new(|info: &PanicInfo| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/panic_hook.rs:41:24 [INFO] [stdout] | [INFO] [stdout] 41 | fn report_crash(info: &PanicInfo) -> std::fmt::Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/panic_hook.rs:6:17 [INFO] [stdout] | [INFO] [stdout] 6 | use std::panic::PanicInfo; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/panic_hook.rs:18:38 [INFO] [stdout] | [INFO] [stdout] 18 | panic::set_hook(Box::new(|info: &PanicInfo| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/panic_hook.rs:41:24 [INFO] [stdout] | [INFO] [stdout] 41 | fn report_crash(info: &PanicInfo) -> std::fmt::Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xxv_state.rs:130:15 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn open_reader>(&mut self, file_name: P) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let b_reader = TilingByteReader::new(file_name)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | match HexReader::new(b_reader) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_reader.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new>(file_name: P) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let file = File::open(file_name)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Ok(TilingByteReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | file, [INFO] [stdout] 28 | | path: path_buf, [INFO] [stdout] 29 | | length: file_len, [INFO] [stdout] 30 | | use_large_addresses: file_len > u64::from(std::u32::MAX), [INFO] [stdout] 31 | | display_name [INFO] [stdout] 32 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hex_reader.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn new(reader: TilingByteReader) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | Ok(HexReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 93 | | reader, [INFO] [stdout] 94 | | line_width: 16, [INFO] [stdout] 95 | | group: 8, [INFO] [stdout] ... | [INFO] [stdout] 101 | | vis_mode: VisualMode::Unicode [INFO] [stdout] 102 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/status_bar.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 29 | let hints_bar = TextView::new(hints_bar_string); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | LinearLayout::horizontal().child(hints_bar.full_width()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xxv_state.rs:130:15 [INFO] [stdout] | [INFO] [stdout] 128 | pub fn open_reader>(&mut self, file_name: P) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let b_reader = TilingByteReader::new(file_name)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | match HexReader::new(b_reader) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/byte_reader.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn new>(file_name: P) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let file = File::open(file_name)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | Ok(TilingByteReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | file, [INFO] [stdout] 28 | | path: path_buf, [INFO] [stdout] 29 | | length: file_len, [INFO] [stdout] 30 | | use_large_addresses: file_len > u64::from(std::u32::MAX), [INFO] [stdout] 31 | | display_name [INFO] [stdout] 32 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hex_reader.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn new(reader: TilingByteReader) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | Ok(HexReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 93 | | reader, [INFO] [stdout] 94 | | line_width: 16, [INFO] [stdout] 95 | | group: 8, [INFO] [stdout] ... | [INFO] [stdout] 101 | | vis_mode: VisualMode::Unicode [INFO] [stdout] 102 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/status_bar.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 29 | let hints_bar = TextView::new(hints_bar_string); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | LinearLayout::horizontal().child(hints_bar.full_width()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xxv` (bin "xxv") due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xxv` (bin "xxv" test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "689c4a022df57056c2a3db72ae94bbc3350d38498cc907abfdb2f7073a3e70d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "689c4a022df57056c2a3db72ae94bbc3350d38498cc907abfdb2f7073a3e70d3", kill_on_drop: false }` [INFO] [stdout] 689c4a022df57056c2a3db72ae94bbc3350d38498cc907abfdb2f7073a3e70d3