[INFO] fetching crate xvc-file 0.6.10... [INFO] checking xvc-file-0.6.10 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xvc-file 0.6.10 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate xvc-file 0.6.10 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xvc-file 0.6.10 [INFO] finished tweaking crates.io crate xvc-file 0.6.10 [INFO] tweaked toml for crates.io crate xvc-file 0.6.10 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate xvc-file 0.6.10 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a8fb64683cea270e13423104dc81f66ed98f2ae5883415c9e2b66432b28e8c1f [INFO] running `Command { std: "docker" "start" "-a" "a8fb64683cea270e13423104dc81f66ed98f2ae5883415c9e2b66432b28e8c1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a8fb64683cea270e13423104dc81f66ed98f2ae5883415c9e2b66432b28e8c1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8fb64683cea270e13423104dc81f66ed98f2ae5883415c9e2b66432b28e8c1f", kill_on_drop: false }` [INFO] [stdout] a8fb64683cea270e13423104dc81f66ed98f2ae5883415c9e2b66432b28e8c1f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bc4d6c7bef6dbfdeb8f5acdada69e0b14d3a72cba3d95dd48632fa09c70f1ec0 [INFO] running `Command { std: "docker" "start" "-a" "bc4d6c7bef6dbfdeb8f5acdada69e0b14d3a72cba3d95dd48632fa09c70f1ec0", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.1.7 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking fern v0.6.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking xvc-logging v0.6.10 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking flate2 v1.0.31 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling blake3 v1.5.3 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking directories-next v2.0.0 [INFO] [stderr] Checking path-dedot v3.1.1 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking cached_proc_macro_types v0.1.1 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking path-absolutize v3.1.1 [INFO] [stderr] Checking jwalk v0.8.1 [INFO] [stderr] Checking seahash v4.1.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Compiling itertools v0.8.2 [INFO] [stderr] Checking subprocess v0.2.9 [INFO] [stderr] Checking tempfile v3.11.0 [INFO] [stderr] Checking which v6.0.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling shellfn-core v0.1.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Compiling darling_core v0.8.6 [INFO] [stderr] Compiling cached_proc_macro v0.23.0 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Compiling shellwords v1.1.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking reflink v0.1.3 [INFO] [stderr] Checking parse-size v1.0.0 [INFO] [stderr] Checking cached v0.53.1 [INFO] [stderr] Checking xvc-test-helper v0.6.10 [INFO] [stderr] Checking serde v1.0.204 [INFO] [stderr] Compiling darling_macro v0.8.6 [INFO] [stderr] Compiling darling v0.8.6 [INFO] [stderr] Compiling shellfn-attribute v0.1.1 [INFO] [stderr] Checking shellfn v0.1.1 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking dashmap v6.0.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking xvc-walker v0.6.10 [INFO] [stderr] Checking relative-path v1.9.3 [INFO] [stderr] Checking xvc-ecs v0.6.10 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking xvc-config v0.6.10 [INFO] [stderr] Checking xvc-core v0.6.10 [INFO] [stderr] Checking xvc-storage v0.6.10 [INFO] [stderr] Checking xvc-file v0.6.10 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:303:26 [INFO] [stdout] | [INFO] [stdout] 278 | let xvc_root = match load_xvc_root(xvc_config_params) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | let (output_snd, output_rec) = bounded::>(CHANNEL_BOUND); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | s.spawn(move |_| run(&output_snd, xvc_root.as_ref(), cli_opts).map_err(|e| e.error())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/mod.rs:449:5 [INFO] [stdout] | [INFO] [stdout] 449 | / path_sync [INFO] [stdout] 450 | | .with_sync_abs_path(path, |path| { [INFO] [stdout] 451 | | path_sync.with_sync_abs_path(cache_path, |cache_path| { [INFO] [stdout] 452 | | if !cache_dir.exists() { [INFO] [stdout] ... | [INFO] [stdout] 471 | | }) [INFO] [stdout] 472 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/compare.rs:343:8 [INFO] [stdout] | [INFO] [stdout] 269 | let (diff_request_snd, diff_request_rcv) = [INFO] [stdout] | ---------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | crossbeam_channel::bounded::>(crate::CHANNEL_CAPACITY); [INFO] [stdout] 271 | let (diff_result_snd, diff_result_rcv) = crossbeam_channel::bounded(crate::CHANNEL_CAPACITY); [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | [INFO] [stdout] 273 | let output_snd = output_snd.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | let xvc_root = xvc_root.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | let stored_xvc_path_store = stored_xvc_path_store.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | let stored_xvc_metadata_store = stored_xvc_metadata_store.clone(); [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | let stored_content_digest_store = stored_content_digest_store.clone(); [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | let stored_text_or_binary_store = stored_text_or_binary_store.clone(); [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | [INFO] [stdout] 280 | let handle = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | Ok((diff_request_snd, diff_result_rcv, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/compare.rs:501:36 [INFO] [stdout] | [INFO] [stdout] 501 | .filter_map(|xe| match diff_file(*xe) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/compare.rs:513:27 [INFO] [stdout] | [INFO] [stdout] 513 | |e| match diff_dir(e, &dir_entities, &file_content_digest_diff_store) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/compare.rs:530:36 [INFO] [stdout] | [INFO] [stdout] 530 | .filter_map(|xe| match diff_file(*xe) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/compare.rs:542:27 [INFO] [stdout] | [INFO] [stdout] 542 | |e| match diff_dir(e, &dir_entities, &file_content_digest_diff_store) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/gitignore.rs:91:8 [INFO] [stdout] | [INFO] [stdout] 42 | let (sender, receiver) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let output_snd = output_snd.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let handle = std::thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Ok((sender, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/carry_in/mod.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | Ok(Box::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 74 | | targets: self.targets.clone(), [INFO] [stdout] 75 | | force, [INFO] [stdout] 76 | | no_parallel, [INFO] [stdout] 77 | | text_or_binary, [INFO] [stdout] 78 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list/mod.rs:497:12 [INFO] [stdout] | [INFO] [stdout] 497 | Ok(Box::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 498 | | no_summary, [INFO] [stdout] 499 | | show_dot_files, [INFO] [stdout] 500 | | format: Some(format), [INFO] [stdout] 501 | | sort: Some(sort_criteria), [INFO] [stdout] 502 | | ..self [INFO] [stdout] 503 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list/mod.rs:703:32 [INFO] [stdout] | [INFO] [stdout] 703 | .filter_map(|pm| match ListRow::new(path_prefix, pm) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recheck/mod.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 70 | Ok(Box::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | targets: self.targets, [INFO] [stdout] 72 | | recheck_method: Some(recheck_method), [INFO] [stdout] 73 | | force, [INFO] [stdout] 74 | | no_parallel, [INFO] [stdout] 75 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recheck/mod.rs:279:8 [INFO] [stdout] | [INFO] [stdout] 249 | let (recheck_op_snd, recheck_op_rvc) = crossbeam_channel::bounded(crate::CHANNEL_CAPACITY); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | let output_snd = output_snd.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | let xvc_root = xvc_root.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | let ignore_handler = ignore_writer.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | [INFO] [stdout] 254 | let handle = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | Ok((recheck_op_snd, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/mod.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | Ok(Box::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | targets: self.targets.clone(), [INFO] [stdout] 81 | | recheck_method: Some(recheck_method), [INFO] [stdout] 82 | | no_commit, [INFO] [stdout] ... | [INFO] [stdout] 85 | | text_or_binary, [INFO] [stdout] 86 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/mod.rs:271:36 [INFO] [stdout] | [INFO] [stdout] 271 | .and_then(|xp| XvcCachePath::new(xp, cd).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xvc-file` (lib test) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:303:26 [INFO] [stdout] | [INFO] [stdout] 278 | let xvc_root = match load_xvc_root(xvc_config_params) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 287 | let (output_snd, output_rec) = bounded::>(CHANNEL_BOUND); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | s.spawn(move |_| run(&output_snd, xvc_root.as_ref(), cli_opts).map_err(|e| e.error())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/mod.rs:449:5 [INFO] [stdout] | [INFO] [stdout] 449 | / path_sync [INFO] [stdout] 450 | | .with_sync_abs_path(path, |path| { [INFO] [stdout] 451 | | path_sync.with_sync_abs_path(cache_path, |cache_path| { [INFO] [stdout] 452 | | if !cache_dir.exists() { [INFO] [stdout] ... | [INFO] [stdout] 471 | | }) [INFO] [stdout] 472 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/compare.rs:343:8 [INFO] [stdout] | [INFO] [stdout] 269 | let (diff_request_snd, diff_request_rcv) = [INFO] [stdout] | ---------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 270 | crossbeam_channel::bounded::>(crate::CHANNEL_CAPACITY); [INFO] [stdout] 271 | let (diff_result_snd, diff_result_rcv) = crossbeam_channel::bounded(crate::CHANNEL_CAPACITY); [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 272 | [INFO] [stdout] 273 | let output_snd = output_snd.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | let xvc_root = xvc_root.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | let stored_xvc_path_store = stored_xvc_path_store.clone(); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | let stored_xvc_metadata_store = stored_xvc_metadata_store.clone(); [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 277 | let stored_content_digest_store = stored_content_digest_store.clone(); [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 278 | let stored_text_or_binary_store = stored_text_or_binary_store.clone(); [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | [INFO] [stdout] 280 | let handle = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | Ok((diff_request_snd, diff_result_rcv, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/compare.rs:501:36 [INFO] [stdout] | [INFO] [stdout] 501 | .filter_map(|xe| match diff_file(*xe) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/compare.rs:513:27 [INFO] [stdout] | [INFO] [stdout] 513 | |e| match diff_dir(e, &dir_entities, &file_content_digest_diff_store) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/compare.rs:530:36 [INFO] [stdout] | [INFO] [stdout] 530 | .filter_map(|xe| match diff_file(*xe) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/compare.rs:542:27 [INFO] [stdout] | [INFO] [stdout] 542 | |e| match diff_dir(e, &dir_entities, &file_content_digest_diff_store) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common/gitignore.rs:91:8 [INFO] [stdout] | [INFO] [stdout] 42 | let (sender, receiver) = crossbeam_channel::unbounded(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let output_snd = output_snd.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let handle = std::thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Ok((sender, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/carry_in/mod.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | Ok(Box::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 74 | | targets: self.targets.clone(), [INFO] [stdout] 75 | | force, [INFO] [stdout] 76 | | no_parallel, [INFO] [stdout] 77 | | text_or_binary, [INFO] [stdout] 78 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list/mod.rs:497:12 [INFO] [stdout] | [INFO] [stdout] 497 | Ok(Box::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 498 | | no_summary, [INFO] [stdout] 499 | | show_dot_files, [INFO] [stdout] 500 | | format: Some(format), [INFO] [stdout] 501 | | sort: Some(sort_criteria), [INFO] [stdout] 502 | | ..self [INFO] [stdout] 503 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/list/mod.rs:703:32 [INFO] [stdout] | [INFO] [stdout] 703 | .filter_map(|pm| match ListRow::new(path_prefix, pm) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recheck/mod.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 70 | Ok(Box::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | targets: self.targets, [INFO] [stdout] 72 | | recheck_method: Some(recheck_method), [INFO] [stdout] 73 | | force, [INFO] [stdout] 74 | | no_parallel, [INFO] [stdout] 75 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recheck/mod.rs:279:8 [INFO] [stdout] | [INFO] [stdout] 249 | let (recheck_op_snd, recheck_op_rvc) = crossbeam_channel::bounded(crate::CHANNEL_CAPACITY); [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 250 | let output_snd = output_snd.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | let xvc_root = xvc_root.clone(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | let ignore_handler = ignore_writer.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | [INFO] [stdout] 254 | let handle = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | Ok((recheck_op_snd, handle)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/mod.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | Ok(Box::new(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | targets: self.targets.clone(), [INFO] [stdout] 81 | | recheck_method: Some(recheck_method), [INFO] [stdout] 82 | | no_commit, [INFO] [stdout] ... | [INFO] [stdout] 85 | | text_or_binary, [INFO] [stdout] 86 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/mod.rs:271:36 [INFO] [stdout] | [INFO] [stdout] 271 | .and_then(|xp| XvcCachePath::new(xp, cd).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xvc-file` (lib) due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "bc4d6c7bef6dbfdeb8f5acdada69e0b14d3a72cba3d95dd48632fa09c70f1ec0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc4d6c7bef6dbfdeb8f5acdada69e0b14d3a72cba3d95dd48632fa09c70f1ec0", kill_on_drop: false }` [INFO] [stdout] bc4d6c7bef6dbfdeb8f5acdada69e0b14d3a72cba3d95dd48632fa09c70f1ec0