[INFO] fetching crate xtra-addons 0.0.2... [INFO] checking xtra-addons-0.0.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xtra-addons 0.0.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate xtra-addons 0.0.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xtra-addons 0.0.2 [INFO] finished tweaking crates.io crate xtra-addons 0.0.2 [INFO] tweaked toml for crates.io crate xtra-addons 0.0.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 118 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (latest: v2.3.1) [INFO] [stderr] Adding async-io v1.13.0 (latest: v2.3.4) [INFO] [stderr] Adding async-lock v2.8.0 (latest: v3.4.0) [INFO] [stderr] Adding async-process v1.8.1 (latest: v2.2.4) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding concurrent-queue v1.2.4 (latest: v2.5.0) [INFO] [stderr] Adding event-listener v2.5.3 (latest: v5.3.1) [INFO] [stderr] Adding event-listener v3.1.0 (latest: v5.3.1) [INFO] [stderr] Adding fastrand v1.9.0 (latest: v2.1.1) [INFO] [stderr] Adding flume v0.10.14 (latest: v0.11.0) [INFO] [stderr] Adding futures-lite v1.13.0 (latest: v2.3.0) [INFO] [stderr] Adding gloo-timers v0.2.6 (latest: v0.3.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding io-lifetimes v1.0.11 (latest: v2.0.3) [INFO] [stderr] Adding linux-raw-sys v0.3.8 (latest: v0.6.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding polling v2.8.0 (latest: v3.7.3) [INFO] [stderr] Adding pollster v0.2.5 (latest: v0.3.0) [INFO] [stderr] Adding rustix v0.37.27 (latest: v0.38.35) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding xtra v0.5.2 (latest: v0.6.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 478c02a8db57dc43388f9fd033445d64b396066573d47799d68e64f617d46b96 [INFO] running `Command { std: "docker" "start" "-a" "478c02a8db57dc43388f9fd033445d64b396066573d47799d68e64f617d46b96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "478c02a8db57dc43388f9fd033445d64b396066573d47799d68e64f617d46b96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "478c02a8db57dc43388f9fd033445d64b396066573d47799d68e64f617d46b96", kill_on_drop: false }` [INFO] [stdout] 478c02a8db57dc43388f9fd033445d64b396066573d47799d68e64f617d46b96 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cf48f3e5864016bb0a8c3e79b5939ad22af9d01fa704b00a0bd8d5e6d21b1b47 [INFO] running `Command { std: "docker" "start" "-a" "cf48f3e5864016bb0a8c3e79b5939ad22af9d01fa704b00a0bd8d5e6d21b1b47", kill_on_drop: false }` [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking cache-padded v1.3.0 [INFO] [stderr] Checking concurrent-queue v1.2.4 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Checking catty v0.1.5 [INFO] [stderr] Checking pollster v0.2.5 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking barrage v0.2.3 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking event-listener v3.1.0 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking polling v3.7.3 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking async-io v2.3.4 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking async-signal v0.2.10 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-process v1.8.1 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking xtra v0.5.2 [INFO] [stderr] Checking xtra-addons v0.0.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broker.rs:126:44 [INFO] [stdout] | [INFO] [stdout] 124 | message: Subscribe, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | ctx: &mut Context, [INFO] [stdout] 126 | ) -> as Message>::Result { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 127 | | let broker_addr = ctx.address().map_err(|_| ())?; [INFO] [stdout] 128 | | [INFO] [stdout] 129 | | let id = SubscriptionId(self.next_id); [INFO] [stdout] ... | [INFO] [stdout] 134 | | Ok(Subscription { id, broker_addr }) [INFO] [stdout] 135 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broker.rs:160:88 [INFO] [stdout] | [INFO] [stdout] 160 | async fn handle(&mut self, Publish(message): Publish, _ctx: &mut Context) { [INFO] [stdout] | ________________________________----------------________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | | let mut disconnected: Vec = Vec::new(); [INFO] [stdout] 162 | | [INFO] [stdout] 163 | | for (&id, subscriber) in &self.subscriptions { [INFO] [stdout] ... | [INFO] [stdout] 174 | | } [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broker.rs:192:90 [INFO] [stdout] | [INFO] [stdout] 192 | async fn subscribe(&self, broker: Address>) -> Result, ()> { [INFO] [stdout] | _______________________________--------------------------_________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | | broker [INFO] [stdout] 194 | | .send(Subscribe { [INFO] [stdout] 195 | | channel: Box::new(self.clone()), [INFO] [stdout] ... | [INFO] [stdout] 198 | | .map_err(|_| ())? [INFO] [stdout] 199 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broker.rs:215:75 [INFO] [stdout] | [INFO] [stdout] 215 | async fn publish(&self, message: M) -> Result<(), xtra::Disconnected> { [INFO] [stdout] | _____________________________----------____________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | | self.send(Publish(message)).await [INFO] [stdout] 217 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xtra-addons` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `msg` is never read [INFO] [stdout] --> src/broker.rs:403:9 [INFO] [stdout] | [INFO] [stdout] 402 | struct Msg { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 403 | msg: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Msg` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broker.rs:126:44 [INFO] [stdout] | [INFO] [stdout] 124 | message: Subscribe, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | ctx: &mut Context, [INFO] [stdout] 126 | ) -> as Message>::Result { [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 127 | | let broker_addr = ctx.address().map_err(|_| ())?; [INFO] [stdout] 128 | | [INFO] [stdout] 129 | | let id = SubscriptionId(self.next_id); [INFO] [stdout] ... | [INFO] [stdout] 134 | | Ok(Subscription { id, broker_addr }) [INFO] [stdout] 135 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broker.rs:160:88 [INFO] [stdout] | [INFO] [stdout] 160 | async fn handle(&mut self, Publish(message): Publish, _ctx: &mut Context) { [INFO] [stdout] | ________________________________----------------________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | | let mut disconnected: Vec = Vec::new(); [INFO] [stdout] 162 | | [INFO] [stdout] 163 | | for (&id, subscriber) in &self.subscriptions { [INFO] [stdout] ... | [INFO] [stdout] 174 | | } [INFO] [stdout] 175 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broker.rs:192:90 [INFO] [stdout] | [INFO] [stdout] 192 | async fn subscribe(&self, broker: Address>) -> Result, ()> { [INFO] [stdout] | _______________________________--------------------------_________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | | broker [INFO] [stdout] 194 | | .send(Subscribe { [INFO] [stdout] 195 | | channel: Box::new(self.clone()), [INFO] [stdout] ... | [INFO] [stdout] 198 | | .map_err(|_| ())? [INFO] [stdout] 199 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/broker.rs:215:75 [INFO] [stdout] | [INFO] [stdout] 215 | async fn publish(&self, message: M) -> Result<(), xtra::Disconnected> { [INFO] [stdout] | _____________________________----------____________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 216 | | self.send(Publish(message)).await [INFO] [stdout] 217 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xtra-addons` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "cf48f3e5864016bb0a8c3e79b5939ad22af9d01fa704b00a0bd8d5e6d21b1b47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf48f3e5864016bb0a8c3e79b5939ad22af9d01fa704b00a0bd8d5e6d21b1b47", kill_on_drop: false }` [INFO] [stdout] cf48f3e5864016bb0a8c3e79b5939ad22af9d01fa704b00a0bd8d5e6d21b1b47