[INFO] fetching crate xtra 0.6.0... [INFO] checking xtra-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xtra 0.6.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate xtra 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xtra 0.6.0 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate xtra 0.6.0 [INFO] tweaked toml for crates.io crate xtra 0.6.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate xtra 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] db1e71879518cd95758152a15148354cdc615c4c336d1ec14bc3da8a1e228e3f [INFO] running `Command { std: "docker" "start" "-a" "db1e71879518cd95758152a15148354cdc615c4c336d1ec14bc3da8a1e228e3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "db1e71879518cd95758152a15148354cdc615c4c336d1ec14bc3da8a1e228e3f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db1e71879518cd95758152a15148354cdc615c4c336d1ec14bc3da8a1e228e3f", kill_on_drop: false }` [INFO] [stdout] db1e71879518cd95758152a15148354cdc615c4c336d1ec14bc3da8a1e228e3f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0a168f1210fb6a73a9279d5d52852a60f8a784d77a35e3eed9d0cbb926e31246 [INFO] running `Command { std: "docker" "start" "-a" "0a168f1210fb6a73a9279d5d52852a60f8a784d77a35e3eed9d0cbb926e31246", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Checking parking v2.1.1 [INFO] [stderr] Checking value-bag v1.4.1 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking waker-fn v1.1.1 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling rustix v0.37.23 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Checking async-task v4.4.1 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Compiling rustix v0.38.14 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking concurrent-queue v2.3.0 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking linux-raw-sys v0.4.7 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking event-listener v3.0.0 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking async-executor v1.5.4 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking catty v0.1.5 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking regex-automata v0.3.8 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking sharded-slab v0.1.6 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking pin-project-lite v0.1.12 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking csv v1.2.2 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.9.5 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Compiling smol-potat-macro v0.6.0 [INFO] [stderr] Checking async-signal v0.2.1 [INFO] [stderr] Checking smol-timeout v0.6.0 [INFO] [stderr] Checking smol-potat v1.1.2 [INFO] [stderr] Checking async-process v1.8.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling tracing-attributes v0.1.26 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking blocking v1.4.0 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Checking async-net v1.8.0 [INFO] [stderr] Checking async-global-executor v2.3.1 [INFO] [stderr] Checking smol v1.3.0 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking xtra v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/address.rs:191:44 [INFO] [stdout] | [INFO] [stdout] 185 | message: M, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | SendFuture::sending_named(message, self.0.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/address.rs:204:42 [INFO] [stdout] | [INFO] [stdout] 199 | pub fn broadcast(&self, msg: M) -> SendFuture, Broadcast> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | SendFuture::broadcast_named(msg, self.0.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `finish` that must be used [INFO] [stdout] --> src/address.rs:313:9 [INFO] [stdout] | [INFO] [stdout] 313 | state.finish(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 313 | let _ = state.finish(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chan.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 107 | mut message: MessageToOne, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let mut inner = self.chan.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | [INFO] [stdout] 117 | let unfulfilled_msg = if let Err(msg) = inner.try_fulfill_receiver(message) { [INFO] [stdout] | --------------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | Ok(Ok(())) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chan.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 137 | mut message: MessageToAll, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | let mut inner = self.chan.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | Ok(Ok(())) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chan.rs:370:52 [INFO] [stdout] | [INFO] [stdout] 370 | self.broadcast_queues.retain(|queue| match queue.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chan/waiting_receiver.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn notify_new_broadcast(self) -> Result<(), ()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | self.0.send(CtrlMsg::NewBroadcast).map_err(|_| ()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chan/waiting_receiver.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn notify_new_message(self, msg: MessageToOne) -> Result<(), MessageToOne> { [INFO] [stdout] | ---- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | / self.0 [INFO] [stdout] 41 | | .send(CtrlMsg::NewMessage(msg)) [INFO] [stdout] | |___________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chan/waiting_receiver.rs:53:10 [INFO] [stdout] | [INFO] [stdout] 51 | let (sender, receiver) = catty::oneshot(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | [INFO] [stdout] 53 | (WaitingReceiver(receiver), Handle(sender)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chan/waiting_receiver.rs:53:37 [INFO] [stdout] | [INFO] [stdout] 51 | let (sender, receiver) = catty::oneshot(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | [INFO] [stdout] 53 | (WaitingReceiver(receiver), Handle(sender)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chan/waiting_receiver.rs:95:21 [INFO] [stdout] | [INFO] [stdout] 81 | let ctrl_msg = match futures_util::ready!(self.0.poll_unpin(cx)) { [INFO] [stdout] | -------- ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | Ok(reason) => reason, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | let actor_message = match ctrl_msg { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | CtrlMsg::NewMessage(msg) => ActorMessage::ToOneActor(msg), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | Some(msg) => ActorMessage::ToAllActors(msg), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Poll::Ready(Some(actor_message)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chan/waiting_sender.rs:19:10 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(msg: M) -> (Handle, WaitingSender) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let inner = Arc::new(spin::Mutex::new(Inner::new(msg))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | (Handle(Arc::downgrade(&inner)), WaitingSender(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chan/waiting_sender.rs:19:42 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(msg: M) -> (Handle, WaitingSender) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let inner = Arc::new(spin::Mutex::new(Inner::new(msg))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | (Handle(Arc::downgrade(&inner)), WaitingSender(inner)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chan/waiting_sender.rs:35:15 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn take_message(self) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let inner = self.0.upgrade()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let mut this = inner.lock(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | [INFO] [stdout] 35 | match mem::replace(&mut *this, Inner::Delivered) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/chan/waiting_sender.rs:108:20 [INFO] [stdout] | [INFO] [stdout] 106 | fn new(message: M) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | Inner::Active { [INFO] [stdout] 108 | waker: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatch_future.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn dispatch_to(self, actor: &mut A) -> DispatchFuture<'_, A> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | Mailbox::from_parts(self.channel, self.broadcast_mailbox), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatch_future.rs:96:20 [INFO] [stdout] | [INFO] [stdout] 88 | fn running(msg: ActorMessage, act: &'a mut A, mailbox: Mailbox) -> DispatchFuture<'a, A> { [INFO] [stdout] | -------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let (fut, span) = match msg { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | ActorMessage::ToOneActor(msg) => msg.handle(act, mailbox), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | ActorMessage::ToAllActors(msg) => msg.handle(act, mailbox), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | state: State::Running { [INFO] [stdout] | ____________________^ [INFO] [stdout] 97 | | fut, [INFO] [stdout] 98 | | phantom: PhantomData, [INFO] [stdout] 99 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dispatch_future.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn new(msg: ActorMessage, act: &'a mut A, mailbox: Mailbox) -> Self { [INFO] [stdout] | -------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | DispatchFuture { [INFO] [stdout] 121 | state: State::New { msg, act, mailbox }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/envelope.rs:209:10 [INFO] [stdout] | [INFO] [stdout] 189 | self: Arc, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | act: &mut Self::Actor, [INFO] [stdout] 191 | mailbox: Mailbox, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | ) -> (BoxFuture>, Span) { [INFO] [stdout] 193 | let (msg, instrumentation) = (self.message.clone(), self.instrumentation.clone()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | drop(self); // Drop ASAP to end the message waiting for actor span [INFO] [stdout] 195 | let fut = async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | let (fut, span) = instrumentation.apply::<_>(fut); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | (Box::pin(fut), span) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel.rs:86:20 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn new(address: Address) -> Self [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | inner: Box::new(address), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/message_channel.rs:322:45 [INFO] [stdout] | [INFO] [stdout] 321 | fn send(&self, message: M) -> SendFuture> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 322 | SendFuture::sending_erased(message, self.0.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/recv_future.rs:42:14 [INFO] [stdout] | [INFO] [stdout] 39 | channel: chan::Ptr, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | broadcast_mailbox: Arc>, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | ) -> Self { [INFO] [stdout] 42 | Self(Receiving::New { [INFO] [stdout] | ______________^ [INFO] [stdout] 43 | | channel, [INFO] [stdout] 44 | | broadcast_mailbox, [INFO] [stdout] 45 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scoped_task.rs:17:22 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn scoped(address: &Address, task: F) -> ScopedTask [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 17 | join_handle: address.join(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/send_future.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn detach(self) -> SendFuture> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | state: self.state.resolve_to_receiver(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/send_future.rs:100:22 [INFO] [stdout] | [INFO] [stdout] 92 | pub(crate) fn sending_named(message: M, sender: chan::Ptr) -> Self [INFO] [stdout] | ---------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let (envelope, receiver) = ReturningEnvelope::::new(message, 0); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | sending: ActorNamedSending(Sending::New { [INFO] [stdout] | ______________________^ [INFO] [stdout] 101 | | msg: Box::new(envelope) as MessageToOne, [INFO] [stdout] 102 | | sender, [INFO] [stdout] 103 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/send_future.rs:104:20 [INFO] [stdout] | [INFO] [stdout] 92 | pub(crate) fn sending_named(message: M, sender: chan::Ptr) -> Self [INFO] [stdout] | ---------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | let (envelope, receiver) = ReturningEnvelope::::new(message, 0); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | state: ResolveToHandlerReturn::new(receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/send_future.rs:120:22 [INFO] [stdout] | [INFO] [stdout] 110 | pub(crate) fn sending_erased(message: M, sender: chan::Ptr) -> Self [INFO] [stdout] | ---------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let (envelope, receiver) = ReturningEnvelope::::new(message, 0); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | sending: ActorErasedSending(Box::new(Sending::New { [INFO] [stdout] | ______________________^ [INFO] [stdout] 121 | | msg: Box::new(envelope) as MessageToOne, [INFO] [stdout] 122 | | sender, [INFO] [stdout] 123 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/send_future.rs:124:20 [INFO] [stdout] | [INFO] [stdout] 110 | pub(crate) fn sending_erased(message: M, sender: chan::Ptr) -> Self [INFO] [stdout] | ---------- ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let (envelope, receiver) = ReturningEnvelope::::new(message, 0); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | state: ResolveToHandlerReturn::new(receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/send_future.rs:141:22 [INFO] [stdout] | [INFO] [stdout] 133 | pub(crate) fn broadcast_named(msg: M, sender: chan::Ptr) -> Self [INFO] [stdout] | ------ ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | let envelope = BroadcastEnvelopeConcrete::new(msg, 0); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 141 | sending: ActorNamedBroadcasting(Sending::New { [INFO] [stdout] | ______________________^ [INFO] [stdout] 142 | | msg: Arc::new(envelope) as MessageToAll, [INFO] [stdout] 143 | | sender, [INFO] [stdout] 144 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/send_future.rs:161:22 [INFO] [stdout] | [INFO] [stdout] 152 | pub(crate) fn broadcast_erased(msg: M, sender: chan::Ptr) -> Self [INFO] [stdout] | ------ ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | let envelope = BroadcastEnvelopeConcrete::new(msg, 0); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | sending: ActorErasedSending(Box::new(Sending::New { [INFO] [stdout] | ______________________^ [INFO] [stdout] 162 | | msg: Arc::new(envelope) as MessageToAll, [INFO] [stdout] 163 | | sender, [INFO] [stdout] 164 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/send_future.rs:317:21 [INFO] [stdout] | [INFO] [stdout] 315 | let receiver = this.state.0.take().expect("polled after completion"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | [INFO] [stdout] 317 | Poll::Ready(Ok(receiver)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/send_future.rs:367:14 [INFO] [stdout] | [INFO] [stdout] 366 | fn new(receiver: catty::Receiver) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 367 | Self(Receiver(receiver)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/send_future.rs:371:27 [INFO] [stdout] | [INFO] [stdout] 370 | fn resolve_to_receiver(self) -> ResolveToReceiver { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 371 | ResolveToReceiver(Some(self.0)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 32 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xtra` (lib) due to 33 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "0a168f1210fb6a73a9279d5d52852a60f8a784d77a35e3eed9d0cbb926e31246", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a168f1210fb6a73a9279d5d52852a60f8a784d77a35e3eed9d0cbb926e31246", kill_on_drop: false }` [INFO] [stdout] 0a168f1210fb6a73a9279d5d52852a60f8a784d77a35e3eed9d0cbb926e31246