[INFO] fetching crate xsynth-core 0.3.1... [INFO] checking xsynth-core-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xsynth-core 0.3.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate xsynth-core 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xsynth-core 0.3.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate xsynth-core 0.3.1 [INFO] tweaked toml for crates.io crate xsynth-core 0.3.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate xsynth-core 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 61bfed543407dc371c526d0188a9b89d7e62570d1c9b32c9eddb0464543a42ea [INFO] running `Command { std: "docker" "start" "-a" "61bfed543407dc371c526d0188a9b89d7e62570d1c9b32c9eddb0464543a42ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "61bfed543407dc371c526d0188a9b89d7e62570d1c9b32c9eddb0464543a42ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "61bfed543407dc371c526d0188a9b89d7e62570d1c9b32c9eddb0464543a42ea", kill_on_drop: false }` [INFO] [stdout] 61bfed543407dc371c526d0188a9b89d7e62570d1c9b32c9eddb0464543a42ea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1d36c6a790a40fa934292d0c487b3d08fb7bfdb92adf127dbb56a2ca4c8964f1 [INFO] running `Command { std: "docker" "start" "-a" "1d36c6a790a40fa934292d0c487b3d08fb7bfdb92adf127dbb56a2ca4c8964f1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.8 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking arrayvec v0.7.2 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking bytemuck v1.16.3 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Checking aho-corasick v1.0.1 [INFO] [stderr] Compiling memchr v2.6.4 [INFO] [stderr] Compiling rustfft v6.2.0 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking symphonia-core v0.5.4 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Compiling paste v1.0.12 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libm v0.1.4 [INFO] [stderr] Checking once_cell v1.17.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking symphonia-metadata v0.5.4 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking primal-check v0.3.3 [INFO] [stderr] Checking transpose v0.2.3 [INFO] [stderr] Checking symphonia-utils-xiph v0.5.4 [INFO] [stderr] Checking getrandom v0.2.9 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking ciborium-io v0.2.0 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking plotters-backend v0.3.4 [INFO] [stderr] Checking extended v0.1.0 [INFO] [stderr] Checking riff v1.0.1 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking soundfont v0.0.3 [INFO] [stderr] Checking plotters-svg v0.3.3 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking symphonia-format-riff v0.5.4 [INFO] [stderr] Checking ciborium-ll v0.2.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking simdeez v2.0.0-dev3 [INFO] [stderr] Compiling regex-bnf-macro v0.1.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking symphonia-bundle-flac v0.5.4 [INFO] [stderr] Checking symphonia-format-mkv v0.5.4 [INFO] [stderr] Checking symphonia-codec-vorbis v0.5.4 [INFO] [stderr] Checking symphonia-format-ogg v0.5.4 [INFO] [stderr] Checking symphonia-codec-adpcm v0.5.4 [INFO] [stderr] Checking symphonia-codec-pcm v0.5.4 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking walkdir v2.3.3 [INFO] [stderr] Compiling midi-toolkit-rs-derive v0.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking symphonia v0.5.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking plotters v0.3.4 [INFO] [stderr] Checking biquad v0.4.2 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking atomic_refcell v0.1.13 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking realfft v3.3.0 [INFO] [stderr] Checking to_vec v0.1.0 [INFO] [stderr] Checking spin_sleep v1.2.1 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking rubato v0.15.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.2.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking regex-bnf v0.1.2 [INFO] [stderr] Checking midi-toolkit-rs v0.1.0 [INFO] [stderr] Checking lazy-regex v3.2.0 [INFO] [stderr] Checking xsynth-soundfonts v0.3.1 [INFO] [stderr] Checking xsynth-core v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffered_renderer.rs:190:20 [INFO] [stdout] | [INFO] [stdout] 107 | mut render: F, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let (tx, rx) = unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | [INFO] [stdout] 113 | let samples = Arc::new(AtomicI64::new(0)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | let last_request_samples = Arc::new(AtomicI64::new(0)); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let render_size = Arc::new(AtomicUsize::new(render_size)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | [INFO] [stdout] 117 | let last_samples_after_read = Arc::new(AtomicI64::new(0)); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | [INFO] [stdout] 119 | let render_time = Arc::new(RwLock::new(VecDeque::new())); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | [INFO] [stdout] 121 | let killed = Arc::new(RwLock::new(false)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | [INFO] [stdout] 123 | let thread_handle = { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let samples = samples.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let last_request_samples = last_request_samples.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let render_size = render_size.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let render_time = render_time.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let killed = killed.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | stats: BufferedRendererStats { [INFO] [stdout] | ____________________^ [INFO] [stdout] 191 | | samples, [INFO] [stdout] 192 | | last_request_samples, [INFO] [stdout] 193 | | render_time, [INFO] [stdout] 194 | | render_size, [INFO] [stdout] 195 | | last_samples_after_read, [INFO] [stdout] 196 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffered_renderer.rs:200:28 [INFO] [stdout] | [INFO] [stdout] 107 | mut render: F, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let (tx, rx) = unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | [INFO] [stdout] 113 | let samples = Arc::new(AtomicI64::new(0)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | let last_request_samples = Arc::new(AtomicI64::new(0)); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let render_size = Arc::new(AtomicUsize::new(render_size)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | [INFO] [stdout] 117 | let last_samples_after_read = Arc::new(AtomicI64::new(0)); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | [INFO] [stdout] 119 | let render_time = Arc::new(RwLock::new(VecDeque::new())); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | [INFO] [stdout] 121 | let killed = Arc::new(RwLock::new(false)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | [INFO] [stdout] 123 | let thread_handle = { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let samples = samples.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | let last_request_samples = last_request_samples.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | let render_size = render_size.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let render_time = render_time.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let killed = killed.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | thread_handle: Some(thread_handle), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/mod.rs:72:19 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn new(key: u8, shared_voice_counter: Arc, options: ChannelInitOptions) -> Self { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Key { [INFO] [stdout] 72 | data: KeyData::new(key, shared_voice_counter, options), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/mod.rs:207:25 [INFO] [stdout] | [INFO] [stdout] 192 | threadpool: Option>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | let params = VoiceChannelParams::new(stream_params); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | let shared_voice_counter = params.stats.voice_counter.clone(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | key_voices: fill_key_array(|i| Key::new(i, shared_voice_counter.clone(), options)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/mod.rs:207:56 [INFO] [stdout] | [INFO] [stdout] 207 | key_voices: fill_key_array(|i| Key::new(i, shared_voice_counter.clone(), options)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/key.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 21 | shared_voice_counter: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | voices: VoiceBuffer::new(options), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel/params.rs:52:20 [INFO] [stdout] | [INFO] [stdout] 49 | let channel_sf = ChannelSoundfont::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | stats: VoiceChannelStats::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/voice/sampler.rs:71:29 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn new_f32(sample: Arc<[f32]>) -> BufferSamplers { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | BufferSamplers::F32(F32BufferSampler(sample)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/voice/sampler.rs:234:37 [INFO] [stdout] | [INFO] [stdout] 233 | pub fn nearest(reader: Reader) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | SIMDSampleGrabbers::Nearest(SIMDNearestSampleGrabber::new(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/voice/sampler.rs:238:36 [INFO] [stdout] | [INFO] [stdout] 237 | pub fn linear(reader: Reader) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | SIMDSampleGrabbers::Linear(SIMDLinearSampleGrabber::new(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/mod.rs:353:12 [INFO] [stdout] | [INFO] [stdout] 213 | sfz_path: impl Into, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | let unique_sample_params: HashSet<_> = regions [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | let samples: Result, _> = unique_sample_params [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | let samples = samples?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | let mut unique_envelope_params = [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 256 | let mut spawner_params_list = Vec::>>::new(); [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 353 | Ok(SampleSoundfont { [INFO] [stdout] | ____________^ [INFO] [stdout] 354 | | instruments: vec![SoundfontInstrument { [INFO] [stdout] 355 | | bank: options.bank.unwrap_or(0), [INFO] [stdout] 356 | | preset: options.preset.unwrap_or(0), [INFO] [stdout] ... | [INFO] [stdout] 359 | | stream_params, [INFO] [stdout] 360 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/mod.rs:230:20 [INFO] [stdout] | [INFO] [stdout] 229 | let sample = load_audio_file(¶ms.path, stream_params)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | Ok((params, sample)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/mod.rs:474:12 [INFO] [stdout] | [INFO] [stdout] 372 | sf2_path: impl Into, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 376 | let presets = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 379 | let mut instruments = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 474 | Ok(SampleSoundfont { [INFO] [stdout] | ____________^ [INFO] [stdout] 475 | | instruments, [INFO] [stdout] 476 | | stream_params, [INFO] [stdout] 477 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/audio.rs:101:15 [INFO] [stdout] | [INFO] [stdout] 84 | let packet = match format.next_packet() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | Err(symphonia::core::errors::Error::IoError(error)) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | Err(error) => return Err(AudioLoadError::AudioDecodingFailed(path.clone(), error)), [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | Ok(packet) => packet, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | match decoder.decode(&packet) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/audio.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 39 | let file = Box::new(File::open(path)?); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | let mss = MediaSourceStream::new(file, Default::default()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let probed = symphonia::default::get_probe() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let mut format = probed.format; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | let mut decoder = symphonia::default::get_codecs() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 111 | let built = builder.finish(sample_rate as f32, new_sample_rate, stream_params.channels); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | [INFO] [stdout] 113 | Ok((built, sample_rate)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/voice_spawners/mono.rs:84:39 [INFO] [stdout] | [INFO] [stdout] 80 | make_bs: impl Fn(Arc<[f32]>) -> BS, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | LoopMode::LoopContinuous => self.make_sample_grabber(control, move |s| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | SampleReaderLoop::new(make_bs(s), self.loop_params.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/voice_spawners/mono.rs:87:46 [INFO] [stdout] | [INFO] [stdout] 80 | make_bs: impl Fn(Arc<[f32]>) -> BS, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | LoopMode::LoopSustain => self.make_sample_grabber(control, move |s| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | SampleReaderLoopSustain::new(make_bs(s), self.loop_params.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/voice_spawners/mono.rs:90:41 [INFO] [stdout] | [INFO] [stdout] 80 | make_bs: impl Fn(Arc<[f32]>) -> BS, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | LoopMode::NoLoop | LoopMode::OneShot => self.make_sample_grabber(control, move |s| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | SampleReaderNoLoop::new(make_bs(s), self.loop_params.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/voice_spawners/mono.rs:102:82 [INFO] [stdout] | [INFO] [stdout] 102 | self.generate_sampler(control, |s| SIMDNearestSampleGrabber::new(make_bs(s))) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/voice_spawners/mono.rs:105:81 [INFO] [stdout] | [INFO] [stdout] 105 | self.generate_sampler(control, |s| SIMDLinearSampleGrabber::new(make_bs(s))) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/voice_spawners/stereo.rs:86:39 [INFO] [stdout] | [INFO] [stdout] 82 | make_bs: impl Fn(Arc<[f32]>) -> BS, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | LoopMode::LoopContinuous => self.make_sample_grabber(control, move |s| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | SampleReaderLoop::new(make_bs(s), self.loop_params.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/voice_spawners/stereo.rs:89:46 [INFO] [stdout] | [INFO] [stdout] 82 | make_bs: impl Fn(Arc<[f32]>) -> BS, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | LoopMode::LoopSustain => self.make_sample_grabber(control, move |s| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | SampleReaderLoopSustain::new(make_bs(s), self.loop_params.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/voice_spawners/stereo.rs:92:41 [INFO] [stdout] | [INFO] [stdout] 82 | make_bs: impl Fn(Arc<[f32]>) -> BS, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | LoopMode::NoLoop | LoopMode::OneShot => self.make_sample_grabber(control, move |s| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | SampleReaderNoLoop::new(make_bs(s), self.loop_params.clone()) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/voice_spawners/stereo.rs:104:82 [INFO] [stdout] | [INFO] [stdout] 104 | self.generate_sampler(control, |s| SIMDNearestSampleGrabber::new(make_bs(s))) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/soundfont/voice_spawners/stereo.rs:107:81 [INFO] [stdout] | [INFO] [stdout] 107 | self.generate_sampler(control, |s| SIMDLinearSampleGrabber::new(make_bs(s))) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel_group/mod.rs:86:35 [INFO] [stdout] | [INFO] [stdout] 34 | let mut channels = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let channel_pool = match config.parallelism.key { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let group_pool = match config.parallelism.channel { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | channel_events_cache: channel_events_cache.into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel_group/mod.rs:87:23 [INFO] [stdout] | [INFO] [stdout] 34 | let mut channels = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let channel_pool = match config.parallelism.key { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let group_pool = match config.parallelism.channel { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | channels: channels.into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel_group/mod.rs:88:32 [INFO] [stdout] | [INFO] [stdout] 34 | let mut channels = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let channel_pool = match config.parallelism.key { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let group_pool = match config.parallelism.channel { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | sample_cache_vecs: sample_cache_vecs.into_boxed_slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/channel_group/mod.rs:205:22 [INFO] [stdout] | [INFO] [stdout] 205 | .map(|c| c.get_channel_stats().voice_count()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 29 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xsynth-core` (lib) due to 30 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "1d36c6a790a40fa934292d0c487b3d08fb7bfdb92adf127dbb56a2ca4c8964f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d36c6a790a40fa934292d0c487b3d08fb7bfdb92adf127dbb56a2ca4c8964f1", kill_on_drop: false }` [INFO] [stdout] 1d36c6a790a40fa934292d0c487b3d08fb7bfdb92adf127dbb56a2ca4c8964f1