[INFO] fetching crate xrpicker 2.2.1... [INFO] checking xrpicker-2.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xrpicker 2.2.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate xrpicker 2.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xrpicker 2.2.1 [INFO] finished tweaking crates.io crate xrpicker 2.2.1 [INFO] tweaked toml for crates.io crate xrpicker 2.2.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate xrpicker 2.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3d5e027602bafcbed1e010ece03e0d42f5e25b2d46bcd6262e68937804f16e11 [INFO] running `Command { std: "docker" "start" "-a" "3d5e027602bafcbed1e010ece03e0d42f5e25b2d46bcd6262e68937804f16e11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3d5e027602bafcbed1e010ece03e0d42f5e25b2d46bcd6262e68937804f16e11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d5e027602bafcbed1e010ece03e0d42f5e25b2d46bcd6262e68937804f16e11", kill_on_drop: false }` [INFO] [stdout] 3d5e027602bafcbed1e010ece03e0d42f5e25b2d46bcd6262e68937804f16e11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b605b86b295c529a50226651dff2c30af44d8bd9b0863c003208c1c6d2e96a44 [INFO] running `Command { std: "docker" "start" "-a" "b605b86b295c529a50226651dff2c30af44d8bd9b0863c003208c1c6d2e96a44", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling thiserror-core v1.0.38 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking xdg v2.5.2 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking flate2 v1.0.27 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Compiling syn v2.0.38 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Compiling thiserror-core-impl v1.0.38 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Checking ruzstd v0.4.0 [INFO] [stderr] Checking object v0.32.1 [INFO] [stderr] Checking xrpicker v2.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app_state.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 70 | let (runtimes, nonfatal_errors) = [INFO] [stdout] | -------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | platform.find_available_runtimes(Box::new(iter::empty()))?; [INFO] [stdout] 72 | let active_data = platform.get_active_data(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 74 | | runtimes, [INFO] [stdout] 75 | | nonfatal_errors, [INFO] [stdout] 76 | | active_data, [INFO] [stdout] 77 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app_state.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 84 | let (runtimes, nonfatal_errors) = [INFO] [stdout] | -------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | platform.find_available_runtimes(persistent_state.iterate_extra_paths())?; [INFO] [stdout] 86 | let active_data = platform.get_active_data(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 88 | | runtimes, [INFO] [stdout] 89 | | nonfatal_errors, [INFO] [stdout] 90 | | active_data, [INFO] [stdout] 91 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app_state.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 97 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let (new_runtimes, new_nonfatal_errors) = [INFO] [stdout] | ------------ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let active_data = platform.get_active_data(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let runtimes = self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | runtimes, [INFO] [stdout] 123 | | nonfatal_errors: new_nonfatal_errors, [INFO] [stdout] 124 | | active_data, [INFO] [stdout] 125 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux.rs:197:25 [INFO] [stdout] | [INFO] [stdout] 197 | .filter_map(|p| p.canonicalize().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux.rs:245:12 [INFO] [stdout] | [INFO] [stdout] 206 | extra_paths: Box>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | ) -> Result<(Vec, Vec), Error> { [INFO] [stdout] 208 | let mut known_manifests: HashSet = HashSet::default(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | [INFO] [stdout] 210 | let manifest_files = find_potential_manifests_xdg(&self.path_suffix) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | let mut nonfatal_errors = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | Ok((runtimes, nonfatal_errors)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux.rs:214:29 [INFO] [stdout] | [INFO] [stdout] 214 | .filter_map(|p| p.canonicalize().ok().map(|canonical| (p, canonical))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app_state.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 70 | let (runtimes, nonfatal_errors) = [INFO] [stdout] | -------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | platform.find_available_runtimes(Box::new(iter::empty()))?; [INFO] [stdout] 72 | let active_data = platform.get_active_data(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 74 | | runtimes, [INFO] [stdout] 75 | | nonfatal_errors, [INFO] [stdout] 76 | | active_data, [INFO] [stdout] 77 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app_state.rs:87:12 [INFO] [stdout] | [INFO] [stdout] 84 | let (runtimes, nonfatal_errors) = [INFO] [stdout] | -------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | platform.find_available_runtimes(persistent_state.iterate_extra_paths())?; [INFO] [stdout] 86 | let active_data = platform.get_active_data(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 88 | | runtimes, [INFO] [stdout] 89 | | nonfatal_errors, [INFO] [stdout] 90 | | active_data, [INFO] [stdout] 91 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app_state.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 97 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let (new_runtimes, new_nonfatal_errors) = [INFO] [stdout] | ------------ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let active_data = platform.get_active_data(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let runtimes = self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | runtimes, [INFO] [stdout] 123 | | nonfatal_errors: new_nonfatal_errors, [INFO] [stdout] 124 | | active_data, [INFO] [stdout] 125 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux.rs:197:25 [INFO] [stdout] | [INFO] [stdout] 197 | .filter_map(|p| p.canonicalize().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux.rs:245:12 [INFO] [stdout] | [INFO] [stdout] 206 | extra_paths: Box>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | ) -> Result<(Vec, Vec), Error> { [INFO] [stdout] 208 | let mut known_manifests: HashSet = HashSet::default(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 209 | [INFO] [stdout] 210 | let manifest_files = find_potential_manifests_xdg(&self.path_suffix) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | let mut nonfatal_errors = vec![]; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | Ok((runtimes, nonfatal_errors)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/linux.rs:214:29 [INFO] [stdout] | [INFO] [stdout] 214 | .filter_map(|p| p.canonicalize().ok().map(|canonical| (p, canonical))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xrpicker` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `xrpicker` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "b605b86b295c529a50226651dff2c30af44d8bd9b0863c003208c1c6d2e96a44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b605b86b295c529a50226651dff2c30af44d8bd9b0863c003208c1c6d2e96a44", kill_on_drop: false }` [INFO] [stdout] b605b86b295c529a50226651dff2c30af44d8bd9b0863c003208c1c6d2e96a44