[INFO] fetching crate xray 0.1.1... [INFO] checking xray-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xray 0.1.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate xray 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xray 0.1.1 [INFO] finished tweaking crates.io crate xray 0.1.1 [INFO] tweaked toml for crates.io crate xray 0.1.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 34 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding deflate v0.7.20 (latest: v1.0.0) [INFO] [stderr] Adding gif v0.10.3 (latest: v0.13.1) [INFO] [stderr] Adding gl v0.10.0 (latest: v0.14.0) [INFO] [stderr] Adding gl_generator v0.9.0 (latest: v0.14.0) [INFO] [stderr] Adding image v0.19.0 (latest: v0.25.2) [INFO] [stderr] Adding jpeg-decoder v0.1.22 (latest: v0.3.1) [INFO] [stderr] Adding khronos_api v2.2.0 (latest: v3.1.0) [INFO] [stderr] Adding num-derive v0.2.5 (latest: v0.4.2) [INFO] [stderr] Adding num-rational v0.1.42 (latest: v0.4.2) [INFO] [stderr] Adding png v0.12.0 (latest: v0.17.13) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] [stderr] Adding xml-rs v0.7.0 (latest: v0.8.21) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f037d9431fc801997a6b8c7f1a24de9372cb2ca36b2ee6f0cafbe6d516abfffb [INFO] running `Command { std: "docker" "start" "-a" "f037d9431fc801997a6b8c7f1a24de9372cb2ca36b2ee6f0cafbe6d516abfffb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f037d9431fc801997a6b8c7f1a24de9372cb2ca36b2ee6f0cafbe6d516abfffb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f037d9431fc801997a6b8c7f1a24de9372cb2ca36b2ee6f0cafbe6d516abfffb", kill_on_drop: false }` [INFO] [stdout] f037d9431fc801997a6b8c7f1a24de9372cb2ca36b2ee6f0cafbe6d516abfffb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa754ae4b9b9bfa931fe54d6062c274287a134ee4471bead66ca0d6c70e5aade [INFO] running `Command { std: "docker" "start" "-a" "aa754ae4b9b9bfa931fe54d6062c274287a134ee4471bead66ca0d6c70e5aade", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling khronos_api v2.2.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling xml-rs v0.7.0 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking xray v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/lib.rs:91:28 [INFO] [stdout] | [INFO] [stdout] 91 | fn write_actual(&self, &DynamicImage) -> XrayResult<()>; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &DynamicImage` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/lib.rs:93:30 [INFO] [stdout] | [INFO] [stdout] 93 | fn write_expected(&self, &DynamicImage) -> XrayResult<()>; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &DynamicImage` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/lib.rs:96:26 [INFO] [stdout] | [INFO] [stdout] 96 | fn write_diff(&self, &DynamicImage) -> XrayResult<()>; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &DynamicImage` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/lib.rs:91:28 [INFO] [stdout] | [INFO] [stdout] 91 | fn write_actual(&self, &DynamicImage) -> XrayResult<()>; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &DynamicImage` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] = note: `#[warn(anonymous_parameters)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/lib.rs:93:30 [INFO] [stdout] | [INFO] [stdout] 93 | fn write_expected(&self, &DynamicImage) -> XrayResult<()>; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &DynamicImage` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: anonymous parameters are deprecated and will be removed in the next edition [INFO] [stdout] --> src/lib.rs:96:26 [INFO] [stdout] | [INFO] [stdout] 96 | fn write_diff(&self, &DynamicImage) -> XrayResult<()>; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try naming the parameter or explicitly ignoring it: `_: &DynamicImage` [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see issue #41686 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/lib.rs:391:33 [INFO] [stdout] | [INFO] [stdout] 391 | fn capture_image(&self, x: i32, y: i32, width: u32, height: u32) -> XrayResult { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> src/lib.rs:391:41 [INFO] [stdout] | [INFO] [stdout] 391 | fn capture_image(&self, x: i32, y: i32, width: u32, height: u32) -> XrayResult { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `width` [INFO] [stdout] --> src/lib.rs:391:49 [INFO] [stdout] | [INFO] [stdout] 391 | fn capture_image(&self, x: i32, y: i32, width: u32, height: u32) -> XrayResult { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_width` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `height` [INFO] [stdout] --> src/lib.rs:391:61 [INFO] [stdout] | [INFO] [stdout] 391 | fn capture_image(&self, x: i32, y: i32, width: u32, height: u32) -> XrayResult { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_height` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rbgw` [INFO] [stdout] --> src/lib.rs:435:13 [INFO] [stdout] | [INFO] [stdout] 435 | let rbgw = DynamicImage::ImageRgba8(ImageBuffer::from_vec(2, 2, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_rbgw` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expected` [INFO] [stdout] --> src/lib.rs:443:13 [INFO] [stdout] | [INFO] [stdout] 443 | let expected = DynamicImage::ImageRgba8(ImageBuffer::from_vec(2, 2, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_expected` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `expected` [INFO] [stdout] --> src/lib.rs:475:13 [INFO] [stdout] | [INFO] [stdout] 475 | let expected = DynamicImage::ImageRgba8(ImageBuffer::from_vec(2, 2, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_expected` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 187 | let mut file = File::create(&filename).or(Err(XrayError::Io(IoError::FailedWritingScreenshot( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | img.write_to(&mut file, ImageFormat::PNG).or_else( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:298:18 [INFO] [stdout] | [INFO] [stdout] 286 | pub fn screenshot_test(screenshot_io: S, screenshot_captor: C, x: i32, y: i32, width: u32, height: ... [INFO] [stdout] | ---------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 298 | .or_else(|err| handle_screenshot_error(screenshot_io, err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:310:16 [INFO] [stdout] | [INFO] [stdout] 310 | panic!(format!("{}", result.unwrap_err())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 310 - panic!(format!("{}", result.unwrap_err())) [INFO] [stdout] 310 + panic!("{}", result.unwrap_err()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xray` (lib test) due to 3 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 187 | let mut file = File::create(&filename).or(Err(XrayError::Io(IoError::FailedWritingScreenshot( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | img.write_to(&mut file, ImageFormat::PNG).or_else( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:298:18 [INFO] [stdout] | [INFO] [stdout] 286 | pub fn screenshot_test(screenshot_io: S, screenshot_captor: C, x: i32, y: i32, width: u32, height: ... [INFO] [stdout] | ---------------- -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 298 | .or_else(|err| handle_screenshot_error(screenshot_io, err)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/lib.rs:310:16 [INFO] [stdout] | [INFO] [stdout] 310 | panic!(format!("{}", result.unwrap_err())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 310 - panic!(format!("{}", result.unwrap_err())) [INFO] [stdout] 310 + panic!("{}", result.unwrap_err()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xray` (lib) due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "aa754ae4b9b9bfa931fe54d6062c274287a134ee4471bead66ca0d6c70e5aade", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa754ae4b9b9bfa931fe54d6062c274287a134ee4471bead66ca0d6c70e5aade", kill_on_drop: false }` [INFO] [stdout] aa754ae4b9b9bfa931fe54d6062c274287a134ee4471bead66ca0d6c70e5aade