[INFO] fetching crate xplm 0.4.1... [INFO] checking xplm-0.4.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xplm 0.4.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate xplm 0.4.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xplm 0.4.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate xplm 0.4.1 [INFO] tweaked toml for crates.io crate xplm 0.4.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate xplm 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b05f859a50b6820af43d8a8d9c357f7c553ca8e20d582d60ab3b96f10c8c9ad3 [INFO] running `Command { std: "docker" "start" "-a" "b05f859a50b6820af43d8a8d9c357f7c553ca8e20d582d60ab3b96f10c8c9ad3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b05f859a50b6820af43d8a8d9c357f7c553ca8e20d582d60ab3b96f10c8c9ad3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b05f859a50b6820af43d8a8d9c357f7c553ca8e20d582d60ab3b96f10c8c9ad3", kill_on_drop: false }` [INFO] [stdout] b05f859a50b6820af43d8a8d9c357f7c553ca8e20d582d60ab3b96f10c8c9ad3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f54c826bb1e01ebab0a4afa923218abb754558882d9fcca2af0a84c61dc87291 [INFO] running `Command { std: "docker" "start" "-a" "f54c826bb1e01ebab0a4afa923218abb754558882d9fcca2af0a84c61dc87291", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling prettyplease v0.2.16 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling linux-raw-sys v0.4.13 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling either v1.10.0 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling bitflags v2.4.2 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling bindgen v0.69.4 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling libloading v0.8.3 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling clang-sys v1.7.0 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling regex v1.10.3 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling xplm-sys v0.5.0 [INFO] [stderr] Checking xplm v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:49:11 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn debug>(message: S) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | match CString::new(message.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:94:11 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn find_symbol>(name: S) -> *mut std::os::raw::c_void { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | use std::ptr; [INFO] [stdout] 94 | match std::ffi::CString::new(name.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:102:11 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn speak>(msg: S) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | match std::ffi::CString::new(msg.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal.rs:11:54 [INFO] [stdout] | [INFO] [stdout] 11 | let src_c = CString::new(src).unwrap_or_else(|_| CString::new("").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 109 | handler: H, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | ) -> Result { [INFO] [stdout] 111 | let mut data = Box::new(OwnedCommandData::new(name, description, handler)?); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(OwnedCommand { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | data, [INFO] [stdout] 123 | | callback: Some(command_handler::), [INFO] [stdout] 124 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:154:12 [INFO] [stdout] | [INFO] [stdout] 149 | handler: H, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | ) -> Result { [INFO] [stdout] 151 | let name_c = CString::new(name)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let description_c = CString::new(description)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | Ok(OwnedCommandData { [INFO] [stdout] | ____________^ [INFO] [stdout] 155 | | id: unsafe { XPLMCreateCommand(name_c.as_ptr(), description_c.as_ptr()) }, [INFO] [stdout] 156 | | handler: Box::new(handler), [INFO] [stdout] 157 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/owned.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 37 | let name_c = CString::new(name)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let value = value.to_storage(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let mut value_box = Box::new(value); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(OwnedData { [INFO] [stdout] | ____________^ [INFO] [stdout] 72 | | id, [INFO] [stdout] 73 | | value: value_box, [INFO] [stdout] 74 | | access_phantom: PhantomData, [INFO] [stdout] 75 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/feature.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn find_feature>(name: S) -> Option { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | match CString::new(name.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flight_loop.rs:134:23 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn new(callback: C) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | callback: Box::new(callback), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/menu.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new>(name: S) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | Ok(Menu { [INFO] [stdout] | ____________^ [INFO] [stdout] 111 | | name: RefCell::new(name), [INFO] [stdout] 112 | | children: RefCell::new(Vec::new()), [INFO] [stdout] 113 | | state: Cell::new(MenuState::Free), [INFO] [stdout] 114 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/menu.rs:310:12 [INFO] [stdout] | [INFO] [stdout] 305 | name: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | handler: H, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | Ok(ActionItem { [INFO] [stdout] | ____________^ [INFO] [stdout] 311 | | name: RefCell::new(name), [INFO] [stdout] 312 | | in_menu: Cell::new(None), [INFO] [stdout] 313 | | handler: Box::new(RefCell::new(handler)), [INFO] [stdout] 314 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/menu.rs:436:12 [INFO] [stdout] | [INFO] [stdout] 430 | name: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 431 | checked: bool, [INFO] [stdout] 432 | handler: H, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | Ok(CheckItem { [INFO] [stdout] | ____________^ [INFO] [stdout] 437 | | name: RefCell::new(name), [INFO] [stdout] 438 | | checked: Cell::new(checked), [INFO] [stdout] 439 | | in_menu: Cell::new(None), [INFO] [stdout] 440 | | handler: Box::new(RefCell::new(handler)), [INFO] [stdout] 441 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/internal.rs:101:68 [INFO] [stdout] | [INFO] [stdout] 101 | let unwind = panic::catch_unwind(AssertUnwindSafe(|| match (*data.plugin).enable() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:49:11 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn debug>(message: S) { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | match CString::new(message.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:94:11 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn find_symbol>(name: S) -> *mut std::os::raw::c_void { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | use std::ptr; [INFO] [stdout] 94 | match std::ffi::CString::new(name.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:102:11 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn speak>(msg: S) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | match std::ffi::CString::new(msg.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/internal.rs:11:54 [INFO] [stdout] | [INFO] [stdout] 11 | let src_c = CString::new(src).unwrap_or_else(|_| CString::new("").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 109 | handler: H, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | ) -> Result { [INFO] [stdout] 111 | let mut data = Box::new(OwnedCommandData::new(name, description, handler)?); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(OwnedCommand { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | data, [INFO] [stdout] 123 | | callback: Some(command_handler::), [INFO] [stdout] 124 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command.rs:154:12 [INFO] [stdout] | [INFO] [stdout] 149 | handler: H, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | ) -> Result { [INFO] [stdout] 151 | let name_c = CString::new(name)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let description_c = CString::new(description)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | Ok(OwnedCommandData { [INFO] [stdout] | ____________^ [INFO] [stdout] 155 | | id: unsafe { XPLMCreateCommand(name_c.as_ptr(), description_c.as_ptr()) }, [INFO] [stdout] 156 | | handler: Box::new(handler), [INFO] [stdout] 157 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/owned.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 37 | let name_c = CString::new(name)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | let value = value.to_storage(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let mut value_box = Box::new(value); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | Ok(OwnedData { [INFO] [stdout] | ____________^ [INFO] [stdout] 72 | | id, [INFO] [stdout] 73 | | value: value_box, [INFO] [stdout] 74 | | access_phantom: PhantomData, [INFO] [stdout] 75 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/feature.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn find_feature>(name: S) -> Option { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | match CString::new(name.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flight_loop.rs:134:23 [INFO] [stdout] | [INFO] [stdout] 130 | pub fn new(callback: C) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | callback: Box::new(callback), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/menu.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 107 | pub fn new>(name: S) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | Ok(Menu { [INFO] [stdout] | ____________^ [INFO] [stdout] 111 | | name: RefCell::new(name), [INFO] [stdout] 112 | | children: RefCell::new(Vec::new()), [INFO] [stdout] 113 | | state: Cell::new(MenuState::Free), [INFO] [stdout] 114 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/menu.rs:310:12 [INFO] [stdout] | [INFO] [stdout] 305 | name: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | handler: H, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | Ok(ActionItem { [INFO] [stdout] | ____________^ [INFO] [stdout] 311 | | name: RefCell::new(name), [INFO] [stdout] 312 | | in_menu: Cell::new(None), [INFO] [stdout] 313 | | handler: Box::new(RefCell::new(handler)), [INFO] [stdout] 314 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/menu.rs:436:12 [INFO] [stdout] | [INFO] [stdout] 430 | name: S, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 431 | checked: bool, [INFO] [stdout] 432 | handler: H, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | Ok(CheckItem { [INFO] [stdout] | ____________^ [INFO] [stdout] 437 | | name: RefCell::new(name), [INFO] [stdout] 438 | | checked: Cell::new(checked), [INFO] [stdout] 439 | | in_menu: Cell::new(None), [INFO] [stdout] 440 | | handler: Box::new(RefCell::new(handler)), [INFO] [stdout] 441 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugin/internal.rs:101:68 [INFO] [stdout] | [INFO] [stdout] 101 | let unwind = panic::catch_unwind(AssertUnwindSafe(|| match (*data.plugin).enable() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xplm` (lib) due to 14 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `xplm` (lib test) due to 14 previous errors [INFO] running `Command { std: "docker" "inspect" "f54c826bb1e01ebab0a4afa923218abb754558882d9fcca2af0a84c61dc87291", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f54c826bb1e01ebab0a4afa923218abb754558882d9fcca2af0a84c61dc87291", kill_on_drop: false }` [INFO] [stdout] f54c826bb1e01ebab0a4afa923218abb754558882d9fcca2af0a84c61dc87291