[INFO] fetching crate xous 0.9.63... [INFO] checking xous-0.9.63 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xous 0.9.63 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate xous 0.9.63 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xous 0.9.63 [INFO] finished tweaking crates.io crate xous 0.9.63 [INFO] tweaked toml for crates.io crate xous 0.9.63 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 313d25083d93ad4ab459f04873ebc1f73f60f9f76000efb22e8135e36c61d9b6 [INFO] running `Command { std: "docker" "start" "-a" "313d25083d93ad4ab459f04873ebc1f73f60f9f76000efb22e8135e36c61d9b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "313d25083d93ad4ab459f04873ebc1f73f60f9f76000efb22e8135e36c61d9b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "313d25083d93ad4ab459f04873ebc1f73f60f9f76000efb22e8135e36c61d9b6", kill_on_drop: false }` [INFO] [stdout] 313d25083d93ad4ab459f04873ebc1f73f60f9f76000efb22e8135e36c61d9b6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 206fbabeceebb6bf85b91a3c6f9b4c9f4956a8459e0f76a4a92a355e730b5dce [INFO] running `Command { std: "docker" "start" "-a" "206fbabeceebb6bf85b91a3c6f9b4c9f4956a8459e0f76a4a92a355e730b5dce", kill_on_drop: false }` [INFO] [stderr] Checking xous v0.9.63 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arch/hosted/threading.rs:157:24 [INFO] [stdout] | [INFO] [stdout] 150 | arg: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | create_thread_post(move || f(arg), thread_id) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arch/hosted/threading.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn create_thread_post(f: F, thread_id: TID) -> core::result::Result, crate::Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | / std::thread::Builder::new() [INFO] [stdout] 177 | | .spawn(move || { [INFO] [stdout] 178 | | THREAD_ID.with(|tid| *tid.borrow_mut() = Some(thread_id)); [INFO] [stdout] 179 | | f() [INFO] [stdout] 180 | | }) [INFO] [stdout] 181 | | .map(WaitHandle) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arch/hosted/threading.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 185 | pub fn wait_thread(joiner: WaitHandle) -> crate::SysCallResult { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | joiner.0.join().map(|_| Result::Ok).map_err(|_| crate::Error::InternalError) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arch/hosted/process.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn wait_process(mut joiner: ProcessHandle) -> crate::SysCallResult { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | / joiner [INFO] [stdout] 156 | | .0 [INFO] [stdout] 157 | | .wait() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syscall.rs:1592:5 [INFO] [stdout] | [INFO] [stdout] 1585 | arg: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1592 | rsyscall(SysCall::CreateThread(thread_info)).and_then(|result| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syscall.rs:1592:59 [INFO] [stdout] | [INFO] [stdout] 1585 | arg: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1592 | rsyscall(SysCall::CreateThread(thread_info)).and_then(|result| { [INFO] [stdout] | ___________________________________________________________^ [INFO] [stdout] 1593 | | if let Result::ThreadID(thread_id) = result { [INFO] [stdout] 1594 | | crate::arch::create_thread_simple_post(f, arg, thread_id) [INFO] [stdout] 1595 | | } else { [INFO] [stdout] 1596 | | Err(Error::InternalError) [INFO] [stdout] 1597 | | } [INFO] [stdout] 1598 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syscall.rs:1697:5 [INFO] [stdout] | [INFO] [stdout] 1690 | pub fn create_thread(f: F) -> core::result::Result, Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1697 | rsyscall(SysCall::CreateThread(thread_info)).and_then(|result| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syscall.rs:1697:59 [INFO] [stdout] | [INFO] [stdout] 1690 | pub fn create_thread(f: F) -> core::result::Result, Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1697 | rsyscall(SysCall::CreateThread(thread_info)).and_then(|result| { [INFO] [stdout] | ___________________________________________________________^ [INFO] [stdout] 1698 | | if let Result::ThreadID(thread_id) = result { [INFO] [stdout] 1699 | | crate::arch::create_thread_post(f, thread_id) [INFO] [stdout] 1700 | | } else { [INFO] [stdout] 1701 | | Err(Error::InternalError) [INFO] [stdout] 1702 | | } [INFO] [stdout] 1703 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xous` (lib test) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arch/hosted/threading.rs:157:24 [INFO] [stdout] | [INFO] [stdout] 150 | arg: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | create_thread_post(move || f(arg), thread_id) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arch/hosted/threading.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn create_thread_post(f: F, thread_id: TID) -> core::result::Result, crate::Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | / std::thread::Builder::new() [INFO] [stdout] 177 | | .spawn(move || { [INFO] [stdout] 178 | | THREAD_ID.with(|tid| *tid.borrow_mut() = Some(thread_id)); [INFO] [stdout] 179 | | f() [INFO] [stdout] 180 | | }) [INFO] [stdout] 181 | | .map(WaitHandle) [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arch/hosted/threading.rs:186:5 [INFO] [stdout] | [INFO] [stdout] 185 | pub fn wait_thread(joiner: WaitHandle) -> crate::SysCallResult { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | joiner.0.join().map(|_| Result::Ok).map_err(|_| crate::Error::InternalError) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arch/hosted/process.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn wait_process(mut joiner: ProcessHandle) -> crate::SysCallResult { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | / joiner [INFO] [stdout] 156 | | .0 [INFO] [stdout] 157 | | .wait() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syscall.rs:1592:5 [INFO] [stdout] | [INFO] [stdout] 1585 | arg: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1592 | rsyscall(SysCall::CreateThread(thread_info)).and_then(|result| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syscall.rs:1592:59 [INFO] [stdout] | [INFO] [stdout] 1585 | arg: T, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1592 | rsyscall(SysCall::CreateThread(thread_info)).and_then(|result| { [INFO] [stdout] | ___________________________________________________________^ [INFO] [stdout] 1593 | | if let Result::ThreadID(thread_id) = result { [INFO] [stdout] 1594 | | crate::arch::create_thread_simple_post(f, arg, thread_id) [INFO] [stdout] 1595 | | } else { [INFO] [stdout] 1596 | | Err(Error::InternalError) [INFO] [stdout] 1597 | | } [INFO] [stdout] 1598 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syscall.rs:1697:5 [INFO] [stdout] | [INFO] [stdout] 1690 | pub fn create_thread(f: F) -> core::result::Result, Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1697 | rsyscall(SysCall::CreateThread(thread_info)).and_then(|result| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syscall.rs:1697:59 [INFO] [stdout] | [INFO] [stdout] 1690 | pub fn create_thread(f: F) -> core::result::Result, Error> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1697 | rsyscall(SysCall::CreateThread(thread_info)).and_then(|result| { [INFO] [stdout] | ___________________________________________________________^ [INFO] [stdout] 1698 | | if let Result::ThreadID(thread_id) = result { [INFO] [stdout] 1699 | | crate::arch::create_thread_post(f, thread_id) [INFO] [stdout] 1700 | | } else { [INFO] [stdout] 1701 | | Err(Error::InternalError) [INFO] [stdout] 1702 | | } [INFO] [stdout] 1703 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xous` (lib) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "206fbabeceebb6bf85b91a3c6f9b4c9f4956a8459e0f76a4a92a355e730b5dce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "206fbabeceebb6bf85b91a3c6f9b4c9f4956a8459e0f76a4a92a355e730b5dce", kill_on_drop: false }` [INFO] [stdout] 206fbabeceebb6bf85b91a3c6f9b4c9f4956a8459e0f76a4a92a355e730b5dce