[INFO] fetching crate xot 0.24.0... [INFO] checking xot-0.24.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xot 0.24.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate xot 0.24.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xot 0.24.0 [INFO] finished tweaking crates.io crate xot 0.24.0 [INFO] tweaked toml for crates.io crate xot 0.24.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 152 packages to latest compatible versions [INFO] [stderr] Adding bit-set v0.5.3 (latest: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (latest: v0.8.0) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding proc-macro-error v0.4.12 (latest: v1.0.4) [INFO] [stderr] Adding proc-macro-error-attr v0.4.12 (latest: v1.0.4) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding regex-automata v0.2.0 (latest: v0.4.7) [INFO] [stderr] Adding rstest v0.16.0 (latest: v0.22.0) [INFO] [stderr] Adding rstest_macros v0.16.0 (latest: v0.22.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding syn-mid v0.5.4 (latest: v0.6.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6ac54d6f3885294ca406104806e43e79b20c70dc7505a672b87a08972d5689b2 [INFO] running `Command { std: "docker" "start" "-a" "6ac54d6f3885294ca406104806e43e79b20c70dc7505a672b87a08972d5689b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6ac54d6f3885294ca406104806e43e79b20c70dc7505a672b87a08972d5689b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ac54d6f3885294ca406104806e43e79b20c70dc7505a672b87a08972d5689b2", kill_on_drop: false }` [INFO] [stdout] 6ac54d6f3885294ca406104806e43e79b20c70dc7505a672b87a08972d5689b2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] edbe4d47ecf21efaab90cbf5d169187e1f741382cbff7971fd8034206f057e27 [INFO] running `Command { std: "docker" "start" "-a" "edbe4d47ecf21efaab90cbf5d169187e1f741382cbff7971fd8034206f057e27", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.12 [INFO] [stderr] Compiling proc-macro-error v0.4.12 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling rstest_macros v0.16.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking genawaiter-macro v0.99.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking xhtmlchardet v2.2.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Compiling syn-mid v0.5.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling genawaiter-proc-macro v0.99.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking genawaiter v0.99.1 [INFO] [stderr] Compiling strum v0.26.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling indextree-macros v0.1.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking indextree v4.7.2 [INFO] [stderr] Checking xot v0.24.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stdout] warning: use of deprecated method `indextree::NodeId::reverse_children`: please, use `NodeId::children().rev()` instead if you want to iterate in reverse [INFO] [stdout] --> src/access.rs:410:14 [INFO] [stdout] | [INFO] [stdout] 410 | .reverse_children(self.arena()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nameaccess.rs:498:9 [INFO] [stdout] | [INFO] [stdout] 497 | let unresolved_namespaces = HashSet::from_iter(self.unresolved_namespaces(node)); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 498 | / prefixes [INFO] [stdout] 499 | | .into_iter() [INFO] [stdout] 500 | | .filter(|(_, ns)| unresolved_namespaces.contains(ns)) [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodemap/core.rs:108:38 [INFO] [stdout] | [INFO] [stdout] 108 | self.iter().map(|(k, v)| (k, v.clone())).collect() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodemap/core.rs:225:38 [INFO] [stdout] | [INFO] [stdout] 225 | self.iter().map(|(k, v)| (k, v.clone())).collect() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nodemap/entry.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn insert(&mut self, value: V) -> V { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | self.map.insert(self.key, value).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/html5elements.rs:47:20 [INFO] [stdout] | [INFO] [stdout] 33 | let mut ids = HashSet::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | names: names.iter().map(|name| name.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialize.rs:375:21 [INFO] [stdout] | [INFO] [stdout] 371 | normalizer: N, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 372 | ) -> impl Iterator + 'a { [INFO] [stdout] 373 | let outputs = gen_outputs(self, node); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 374 | let mut serializer = XmlSerializer::new(self, node, parameters, normalizer); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 375 | outputs.map(move |(node, output)| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 376 | | let rendered = serializer.render_output(node, &output).unwrap(); [INFO] [stdout] 377 | | (node, output, rendered) [INFO] [stdout] 378 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialize.rs:411:21 [INFO] [stdout] | [INFO] [stdout] 402 | normalizer: N, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 403 | ) -> impl Iterator + 'a { [INFO] [stdout] 404 | let outputs = gen_outputs(self, node); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 405 | let mut serializer = XmlSerializer::new(self, node, parameters, normalizer); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 411 | outputs.map(move |(node, output)| { [INFO] [stdout] | _____________________^ [INFO] [stdout] 412 | | let (indentation, newline) = pretty.prettify(node, &output); [INFO] [stdout] 413 | | let rendered = serializer.render_output(node, &output).unwrap(); [INFO] [stdout] 414 | | ( [INFO] [stdout] ... | [INFO] [stdout] 423 | | ) [INFO] [stdout] 424 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xot` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "edbe4d47ecf21efaab90cbf5d169187e1f741382cbff7971fd8034206f057e27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "edbe4d47ecf21efaab90cbf5d169187e1f741382cbff7971fd8034206f057e27", kill_on_drop: false }` [INFO] [stdout] edbe4d47ecf21efaab90cbf5d169187e1f741382cbff7971fd8034206f057e27