[INFO] fetching crate xml_oxide 0.3.0... [INFO] checking xml_oxide-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xml_oxide 0.3.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate xml_oxide 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xml_oxide 0.3.0 [INFO] finished tweaking crates.io crate xml_oxide 0.3.0 [INFO] tweaked toml for crates.io crate xml_oxide 0.3.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 884ad1f7c2eb5ef676a77270e32eaf0204975c1567d60330a87f34c52a27a908 [INFO] running `Command { std: "docker" "start" "-a" "884ad1f7c2eb5ef676a77270e32eaf0204975c1567d60330a87f34c52a27a908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "884ad1f7c2eb5ef676a77270e32eaf0204975c1567d60330a87f34c52a27a908", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "884ad1f7c2eb5ef676a77270e32eaf0204975c1567d60330a87f34c52a27a908", kill_on_drop: false }` [INFO] [stdout] 884ad1f7c2eb5ef676a77270e32eaf0204975c1567d60330a87f34c52a27a908 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ff9395637678f618ebaba01bb1e25a593b490d1752c011f9169477baccfb2def [INFO] running `Command { std: "docker" "start" "-a" "ff9395637678f618ebaba01bb1e25a593b490d1752c011f9169477baccfb2def", kill_on_drop: false }` [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking xml_oxide v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `multi::many0` [INFO] [stdout] --> src/sax/internal.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | multi::many0, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SAXAttribute2` [INFO] [stdout] --> src/sax/parser.rs:8:75 [INFO] [stdout] | [INFO] [stdout] 8 | InsideComment, Misc, MiscBeforeDoctype, MiscBeforeXmlDecl, QName, SAXAttribute2, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `vec` [INFO] [stdout] --> src/sax/parser.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | vec, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `multi::many0` [INFO] [stdout] --> src/sax/internal.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | multi::many0, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SAXAttribute2` [INFO] [stdout] --> src/sax/parser.rs:8:75 [INFO] [stdout] | [INFO] [stdout] 8 | InsideComment, Misc, MiscBeforeDoctype, MiscBeforeXmlDecl, QName, SAXAttribute2, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `vec` [INFO] [stdout] --> src/sax/parser.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | vec, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `borrow::BorrowMut` [INFO] [stdout] --> src/sax/parser.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | borrow::BorrowMut, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `borrow::BorrowMut` [INFO] [stdout] --> src/sax/parser.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | borrow::BorrowMut, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `namespace_strbuffer` [INFO] [stdout] --> src/sax/parser.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | namespace_strbuffer: &'a mut String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_namespace_strbuffer` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buffer3` [INFO] [stdout] --> src/sax/parser.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | buffer3: &circular::Buffer, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_buffer3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sax/parser.rs:385:5 [INFO] [stdout] | [INFO] [stdout] 385 | mut namespace_strbuffer: &'a mut String, [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/sax/circular.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 36 | impl Buffer { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 52 | pub fn from_slice(data: &[u8]) -> Buffer { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 90 | pub fn empty(&self) -> bool { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 113 | pub fn consume_noshift(&mut self, count: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 142 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 178 | pub fn delete_slice(&mut self, start: usize, length: usize) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 198 | pub fn replace_slice(&mut self, data: &[u8], start: usize, length: usize) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 244 | pub fn insert_slice(&mut self, data: &[u8], start: usize) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AttributeRanges` is never constructed [INFO] [stdout] --> src/sax/internal.rs:352:12 [INFO] [stdout] | [INFO] [stdout] 352 | pub struct AttributeRanges { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SAXAttributeNsAware` is never constructed [INFO] [stdout] --> src/sax/internal.rs:425:8 [INFO] [stdout] | [INFO] [stdout] 425 | struct SAXAttributeNsAware { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_data_splitted` is never used [INFO] [stdout] --> src/sax/parser.rs:337:4 [INFO] [stdout] | [INFO] [stdout] 337 | fn read_data_splitted( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_data_splitted_refcell` is never used [INFO] [stdout] --> src/sax/parser.rs:356:4 [INFO] [stdout] | [INFO] [stdout] 356 | fn read_data_splitted_refcell( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sax/internal.rs:250:27 [INFO] [stdout] | [INFO] [stdout] 244 | fn many1_custom(mut f: F) -> impl FnMut(I) -> IResult [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | move |mut i: I| match f.parse(i.clone()) { [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sax/parser.rs:1105:24 [INFO] [stdout] | [INFO] [stdout] 1102 | pub fn from_reader(reader: R) -> Parser { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1105 | bufreader: BufReader::with_capacity(8 * 1024, reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xml_oxide` (lib) due to 3 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `namespace_strbuffer` [INFO] [stdout] --> src/sax/parser.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | namespace_strbuffer: &'a mut String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_namespace_strbuffer` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `buffer3` [INFO] [stdout] --> src/sax/parser.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | buffer3: &circular::Buffer, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_buffer3` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sax/parser.rs:385:5 [INFO] [stdout] | [INFO] [stdout] 385 | mut namespace_strbuffer: &'a mut String, [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `from_slice`, `empty`, `reset`, and `insert_slice` are never used [INFO] [stdout] --> src/sax/circular.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 36 | impl Buffer { [INFO] [stdout] | ----------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 52 | pub fn from_slice(data: &[u8]) -> Buffer { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 90 | pub fn empty(&self) -> bool { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 142 | pub fn reset(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 244 | pub fn insert_slice(&mut self, data: &[u8], start: usize) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AttributeRanges` is never constructed [INFO] [stdout] --> src/sax/internal.rs:352:12 [INFO] [stdout] | [INFO] [stdout] 352 | pub struct AttributeRanges { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SAXAttributeNsAware` is never constructed [INFO] [stdout] --> src/sax/internal.rs:425:8 [INFO] [stdout] | [INFO] [stdout] 425 | struct SAXAttributeNsAware { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_data_splitted` is never used [INFO] [stdout] --> src/sax/parser.rs:337:4 [INFO] [stdout] | [INFO] [stdout] 337 | fn read_data_splitted( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `read_data_splitted_refcell` is never used [INFO] [stdout] --> src/sax/parser.rs:356:4 [INFO] [stdout] | [INFO] [stdout] 356 | fn read_data_splitted_refcell( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sax/internal.rs:250:27 [INFO] [stdout] | [INFO] [stdout] 244 | fn many1_custom(mut f: F) -> impl FnMut(I) -> IResult [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | move |mut i: I| match f.parse(i.clone()) { [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sax/parser.rs:1105:24 [INFO] [stdout] | [INFO] [stdout] 1102 | pub fn from_reader(reader: R) -> Parser { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1105 | bufreader: BufReader::with_capacity(8 * 1024, reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xml_oxide` (lib test) due to 3 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ff9395637678f618ebaba01bb1e25a593b490d1752c011f9169477baccfb2def", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ff9395637678f618ebaba01bb1e25a593b490d1752c011f9169477baccfb2def", kill_on_drop: false }` [INFO] [stdout] ff9395637678f618ebaba01bb1e25a593b490d1752c011f9169477baccfb2def