[INFO] fetching crate xml-no-std 0.8.19... [INFO] checking xml-no-std-0.8.19 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xml-no-std 0.8.19 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate xml-no-std 0.8.19 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xml-no-std 0.8.19 [INFO] finished tweaking crates.io crate xml-no-std 0.8.19 [INFO] tweaked toml for crates.io crate xml-no-std 0.8.19 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate xml-no-std 0.8.19 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3bc50242cde36e4066cc9a5012f94e0bfdc1b2df8fe2ea037a03cb045806b80f [INFO] running `Command { std: "docker" "start" "-a" "3bc50242cde36e4066cc9a5012f94e0bfdc1b2df8fe2ea037a03cb045806b80f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3bc50242cde36e4066cc9a5012f94e0bfdc1b2df8fe2ea037a03cb045806b80f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bc50242cde36e4066cc9a5012f94e0bfdc1b2df8fe2ea037a03cb045806b80f", kill_on_drop: false }` [INFO] [stdout] 3bc50242cde36e4066cc9a5012f94e0bfdc1b2df8fe2ea037a03cb045806b80f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b99411e24c6c9a6165b4417ca4151aa6f1c5fa90abafc1606e4f530776766a4a [INFO] running `Command { std: "docker" "start" "-a" "b99411e24c6c9a6165b4417ca4151aa6f1c5fa90abafc1606e4f530776766a4a", kill_on_drop: false }` [INFO] [stderr] Checking xml-no-std v0.8.19 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ToString` [INFO] [stdout] --> src/reader/error.rs:8:29 [INFO] [stdout] | [INFO] [stdout] 8 | use alloc::string::{String, ToString}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::borrow::Borrow` [INFO] [stdout] --> src/reader/error.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use core::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `CharReadError`, `CharReader`, and `Encoding` [INFO] [stdout] --> src/util.rs:210:17 [INFO] [stdout] | [INFO] [stdout] 210 | use super::{CharReadError, CharReader, Encoding}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ToString` [INFO] [stdout] --> src/reader/error.rs:8:29 [INFO] [stdout] | [INFO] [stdout] 8 | use alloc::string::{String, ToString}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::borrow::Borrow` [INFO] [stdout] --> src/reader/error.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use core::borrow::Borrow; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::fmt::Write` [INFO] [stdout] --> src/writer/emitter.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use core::fmt::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::fmt::Write` [INFO] [stdout] --> src/writer/emitter.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use core::fmt::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `reason` [INFO] [stdout] --> src/reader/error.rs:166:18 [INFO] [stdout] | [INFO] [stdout] 166 | Utf8(reason) => "UTF8 Error", [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_reason` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `reason` [INFO] [stdout] --> src/reader/error.rs:166:18 [INFO] [stdout] | [INFO] [stdout] 166 | Utf8(reason) => "UTF8 Error", [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_reason` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/parser/inside_reference.rs:65:93 [INFO] [stdout] | [INFO] [stdout] 65 | u32::from_str_radix(hex, 16).map_err(move |_| SyntaxError::InvalidNumericEntity(num_str.into()))? [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `disable_errors` is never used [INFO] [stdout] --> src/reader/lexer.rs:275:21 [INFO] [stdout] | [INFO] [stdout] 244 | impl Lexer { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 275 | #[cfg(test)] fn disable_errors(&mut self) { self.skip_errors = true; } [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/parser/inside_reference.rs:67:97 [INFO] [stdout] | [INFO] [stdout] 67 | u32::from_str_radix(num_str, 10).map_err(move |_| SyntaxError::InvalidNumericEntity(num_str.into()))? [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/parser/inside_reference.rs:65:93 [INFO] [stdout] | [INFO] [stdout] 65 | u32::from_str_radix(hex, 16).map_err(move |_| SyntaxError::InvalidNumericEntity(num_str.into()))? [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader/parser/inside_reference.rs:67:97 [INFO] [stdout] | [INFO] [stdout] 67 | u32::from_str_radix(num_str, 10).map_err(move |_| SyntaxError::InvalidNumericEntity(num_str.into()))? [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `core::result::Result` that must be used [INFO] [stdout] --> src/writer/emitter.rs:379:9 [INFO] [stdout] | [INFO] [stdout] 379 | self.check_document_started(target); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 379 | let _ = self.check_document_started(target); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/writer/emitter.rs:379:9 [INFO] [stdout] | [INFO] [stdout] 379 | self.check_document_started(target); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 379 | let _ = self.check_document_started(target); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xml-no-std` (lib) due to 3 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `xml-no-std` (lib test) due to 3 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b99411e24c6c9a6165b4417ca4151aa6f1c5fa90abafc1606e4f530776766a4a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b99411e24c6c9a6165b4417ca4151aa6f1c5fa90abafc1606e4f530776766a4a", kill_on_drop: false }` [INFO] [stdout] b99411e24c6c9a6165b4417ca4151aa6f1c5fa90abafc1606e4f530776766a4a