[INFO] fetching crate xloop_windows 0.1.1... [INFO] checking xloop_windows-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xloop_windows 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate xloop_windows 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xloop_windows 0.1.1 [INFO] finished tweaking crates.io crate xloop_windows 0.1.1 [INFO] tweaked toml for crates.io crate xloop_windows 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] [stderr] Adding windows v0.57.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-core v0.57.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-implement v0.57.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-interface v0.57.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-result v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e34f158360986ef7b6f35cdade88873545f6047bcbd17f5a0e289c2fc66732b3 [INFO] running `Command { std: "docker" "start" "-a" "e34f158360986ef7b6f35cdade88873545f6047bcbd17f5a0e289c2fc66732b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e34f158360986ef7b6f35cdade88873545f6047bcbd17f5a0e289c2fc66732b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e34f158360986ef7b6f35cdade88873545f6047bcbd17f5a0e289c2fc66732b3", kill_on_drop: false }` [INFO] [stdout] e34f158360986ef7b6f35cdade88873545f6047bcbd17f5a0e289c2fc66732b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e79ba27161d22dd12cefb01e7d19b26963498627ff7da494488523cb4504e2e2 [INFO] running `Command { std: "docker" "start" "-a" "e79ba27161d22dd12cefb01e7d19b26963498627ff7da494488523cb4504e2e2", kill_on_drop: false }` [INFO] [stderr] Compiling windows_x86_64_gnu v0.52.6 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking thunderdome v0.6.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking xloop_types v0.1.1 [INFO] [stderr] Checking windows-targets v0.52.6 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking windows-result v0.1.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling windows-implement v0.57.0 [INFO] [stderr] Compiling windows-interface v0.57.0 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking windows-core v0.57.0 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking windows v0.57.0 [INFO] [stderr] Checking xloop_windows v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> app.rs:85:47 [INFO] [stdout] | [INFO] [stdout] 85 | if let Some(path) = CACHE.with_borrow(|vars| vars.path.borrow().as_ref().cloned()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> win/win.rs:123:31 [INFO] [stdout] | [INFO] [stdout] 123 | CACHE.with_borrow_mut(|vars| vars.get_mut(key).map(|win| fun(win)).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> win/win.rs:126:27 [INFO] [stdout] | [INFO] [stdout] 126 | CACHE.with_borrow(|vars| vars.get(key).map(|win| fun(win)).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> win/win.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 155 | pub unsafe fn new(key: impl AsRef, delegate: impl types::WinDelegate + 'static) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | wins.insert(Win { [INFO] [stdout] | _________________________^ [INFO] [stdout] 163 | | _key: key.as_ref().to_string(), [INFO] [stdout] 164 | | delegate: Rc::new(delegate), [INFO] [stdout] 165 | | hwnd: Cell::new(HWND(0)), [INFO] [stdout] 166 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xloop_windows` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> app.rs:85:47 [INFO] [stdout] | [INFO] [stdout] 85 | if let Some(path) = CACHE.with_borrow(|vars| vars.path.borrow().as_ref().cloned()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> win/win.rs:123:31 [INFO] [stdout] | [INFO] [stdout] 123 | CACHE.with_borrow_mut(|vars| vars.get_mut(key).map(|win| fun(win)).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xloop_windows` (lib) due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> win/win.rs:126:27 [INFO] [stdout] | [INFO] [stdout] 126 | CACHE.with_borrow(|vars| vars.get(key).map(|win| fun(win)).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> win/win.rs:162:16 [INFO] [stdout] | [INFO] [stdout] 155 | pub unsafe fn new(key: impl AsRef, delegate: impl types::WinDelegate + 'static) -> Option { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | wins.insert(Win { [INFO] [stdout] | _________________________^ [INFO] [stdout] 163 | | _key: key.as_ref().to_string(), [INFO] [stdout] 164 | | delegate: Rc::new(delegate), [INFO] [stdout] 165 | | hwnd: Cell::new(HWND(0)), [INFO] [stdout] 166 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "e79ba27161d22dd12cefb01e7d19b26963498627ff7da494488523cb4504e2e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e79ba27161d22dd12cefb01e7d19b26963498627ff7da494488523cb4504e2e2", kill_on_drop: false }` [INFO] [stdout] e79ba27161d22dd12cefb01e7d19b26963498627ff7da494488523cb4504e2e2