[INFO] fetching crate xloop_android 0.1.1... [INFO] checking xloop_android-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xloop_android 0.1.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate xloop_android 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xloop_android 0.1.1 [INFO] finished tweaking crates.io crate xloop_android 0.1.1 [INFO] tweaked toml for crates.io crate xloop_android 0.1.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding android_logger v0.13.3 (latest: v0.14.1) [INFO] [stderr] Adding env_logger v0.10.2 (latest: v0.11.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 95e99fbb7c45618576b77416e1df0406a9bacc65935c79632fce8b26e09ec17a [INFO] running `Command { std: "docker" "start" "-a" "95e99fbb7c45618576b77416e1df0406a9bacc65935c79632fce8b26e09ec17a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "95e99fbb7c45618576b77416e1df0406a9bacc65935c79632fce8b26e09ec17a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95e99fbb7c45618576b77416e1df0406a9bacc65935c79632fce8b26e09ec17a", kill_on_drop: false }` [INFO] [stdout] 95e99fbb7c45618576b77416e1df0406a9bacc65935c79632fce8b26e09ec17a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bc3ac21a0f6149c6a844f3b455d0e8fe2e55107baaeda4597c52d3eacff1c750 [INFO] running `Command { std: "docker" "start" "-a" "bc3ac21a0f6149c6a844f3b455d0e8fe2e55107baaeda4597c52d3eacff1c750", kill_on_drop: false }` [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking jnim_sys v0.1.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking android_log-sys v0.3.1 [INFO] [stderr] Checking cesu8 v1.1.0 [INFO] [stderr] Checking thunderdome v0.6.1 [INFO] [stderr] Checking ndkm_sys v0.1.0 [INFO] [stderr] Checking jnim v0.1.1 [INFO] [stderr] Checking xloop_types v0.1.1 [INFO] [stderr] Checking ndkm v0.1.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking android_logger v0.13.3 [INFO] [stderr] Checking xloop_android v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:36:6 [INFO] [stdout] | [INFO] [stdout] 33 | fn run(delegate: impl types::AppDelegate + 'static) -> Result, Self::Error> { [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> app.rs:133:24 [INFO] [stdout] | [INFO] [stdout] 132 | pub(super) fn set_delegate(delegate: RcDynAppDelegate) { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | CACHE.with_borrow_mut(|cache| cache.delegate = Some(delegate)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> win/wins.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn reg_window(name: impl AsRef, delegate: RcDynWinDelegate) { [INFO] [stdout] | --------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | REG.with_borrow_mut(|regs| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 76 | | regs.insert(name.as_ref().to_string(), delegate); [INFO] [stdout] 77 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> win/wins.rs:83:24 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new_window(name: impl AsRef) -> Key { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | // TODO check main thread [INFO] [stdout] 81 | let delegate = REG.with_borrow(|regs| regs.get(name.as_ref()).cloned()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let key = name.as_ref(); [INFO] [stdout] 83 | CACHE.with_borrow_mut(|vars| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 84 | | for (idx, win) in vars.iter() { [INFO] [stdout] 85 | | if win.key_ == key.as_ref() { [INFO] [stdout] 86 | | log::warn!("Duplicated Activity with same Window"); [INFO] [stdout] ... | [INFO] [stdout] 105 | | key [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> win/wins.rs:125:31 [INFO] [stdout] | [INFO] [stdout] 125 | CACHE.with_borrow_mut(|vars| vars.get_mut(key).map(|win| fun(win)).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> win/wins.rs:128:27 [INFO] [stdout] | [INFO] [stdout] 128 | CACHE.with_borrow(|vars| vars.get(key).map(|win| fun(win)).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xloop_android` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib.rs:36:6 [INFO] [stdout] | [INFO] [stdout] 33 | fn run(delegate: impl types::AppDelegate + 'static) -> Result, Self::Error> { [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> app.rs:133:24 [INFO] [stdout] | [INFO] [stdout] 132 | pub(super) fn set_delegate(delegate: RcDynAppDelegate) { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | CACHE.with_borrow_mut(|cache| cache.delegate = Some(delegate)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> win/wins.rs:75:22 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn reg_window(name: impl AsRef, delegate: RcDynWinDelegate) { [INFO] [stdout] | --------------------- -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | REG.with_borrow_mut(|regs| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 76 | | regs.insert(name.as_ref().to_string(), delegate); [INFO] [stdout] 77 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> win/wins.rs:83:24 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn new_window(name: impl AsRef) -> Key { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | // TODO check main thread [INFO] [stdout] 81 | let delegate = REG.with_borrow(|regs| regs.get(name.as_ref()).cloned()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let key = name.as_ref(); [INFO] [stdout] 83 | CACHE.with_borrow_mut(|vars| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 84 | | for (idx, win) in vars.iter() { [INFO] [stdout] 85 | | if win.key_ == key.as_ref() { [INFO] [stdout] 86 | | log::warn!("Duplicated Activity with same Window"); [INFO] [stdout] ... | [INFO] [stdout] 105 | | key [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> win/wins.rs:125:31 [INFO] [stdout] | [INFO] [stdout] 125 | CACHE.with_borrow_mut(|vars| vars.get_mut(key).map(|win| fun(win)).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> win/wins.rs:128:27 [INFO] [stdout] | [INFO] [stdout] 128 | CACHE.with_borrow(|vars| vars.get(key).map(|win| fun(win)).flatten()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xloop_android` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "bc3ac21a0f6149c6a844f3b455d0e8fe2e55107baaeda4597c52d3eacff1c750", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bc3ac21a0f6149c6a844f3b455d0e8fe2e55107baaeda4597c52d3eacff1c750", kill_on_drop: false }` [INFO] [stdout] bc3ac21a0f6149c6a844f3b455d0e8fe2e55107baaeda4597c52d3eacff1c750