[INFO] fetching crate xl 0.1.7... [INFO] checking xl-0.1.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xl 0.1.7 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate xl 0.1.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xl 0.1.7 [INFO] finished tweaking crates.io crate xl 0.1.7 [INFO] tweaked toml for crates.io crate xl 0.1.7 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate xl 0.1.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 03dda1f8c648d668ef3079d6c471e97325ac851b9b5d643024e4ac69372ba5d6 [INFO] running `Command { std: "docker" "start" "-a" "03dda1f8c648d668ef3079d6c471e97325ac851b9b5d643024e4ac69372ba5d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "03dda1f8c648d668ef3079d6c471e97325ac851b9b5d643024e4ac69372ba5d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "03dda1f8c648d668ef3079d6c471e97325ac851b9b5d643024e4ac69372ba5d6", kill_on_drop: false }` [INFO] [stdout] 03dda1f8c648d668ef3079d6c471e97325ac851b9b5d643024e4ac69372ba5d6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 077aa1ceebfe5872b6e8f2b73c9f9a29b4077ca920a83f73fc35b058da0b60cd [INFO] running `Command { std: "docker" "start" "-a" "077aa1ceebfe5872b6e8f2b73c9f9a29b4077ca920a83f73fc35b058da0b60cd", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling cc v1.0.68 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking quick-xml v0.22.0 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking flate2 v1.0.20 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking bzip2 v0.4.3 [INFO] [stderr] Compiling thiserror-impl v1.0.26 [INFO] [stderr] Checking thiserror v1.0.26 [INFO] [stderr] Checking zip v0.5.13 [INFO] [stderr] Checking xl v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `encoding` is never read [INFO] [stdout] --> src/wb.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct Workbook { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 43 | encoding: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Workbook` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `relationship_id` and `sheet_id` are never read [INFO] [stdout] --> src/ws.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 85 | pub struct Worksheet { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 88 | relationship_id: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 91 | sheet_id: u8, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Worksheet` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wb.rs:314:15 [INFO] [stdout] | [INFO] [stdout] 310 | let zip_file = match fs::File::open(&path) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 311 | Ok(z) => z, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | Err(e) => return Err(e.to_string()), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | }; [INFO] [stdout] 314 | match zip::ZipArchive::new(zip_file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xl` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `encoding` is never read [INFO] [stdout] --> src/wb.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct Workbook { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 43 | encoding: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Workbook` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `relationship_id` and `sheet_id` are never read [INFO] [stdout] --> src/ws.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 85 | pub struct Worksheet { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 88 | relationship_id: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 91 | sheet_id: u8, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Worksheet` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wb.rs:314:15 [INFO] [stdout] | [INFO] [stdout] 310 | let zip_file = match fs::File::open(&path) { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 311 | Ok(z) => z, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | Err(e) => return Err(e.to_string()), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 313 | }; [INFO] [stdout] 314 | match zip::ZipArchive::new(zip_file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xl` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "077aa1ceebfe5872b6e8f2b73c9f9a29b4077ca920a83f73fc35b058da0b60cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "077aa1ceebfe5872b6e8f2b73c9f9a29b4077ca920a83f73fc35b058da0b60cd", kill_on_drop: false }` [INFO] [stdout] 077aa1ceebfe5872b6e8f2b73c9f9a29b4077ca920a83f73fc35b058da0b60cd