[INFO] fetching crate xio_common 0.12.0... [INFO] checking xio_common-0.12.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xio_common 0.12.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate xio_common 0.12.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xio_common 0.12.0 [INFO] finished tweaking crates.io crate xio_common 0.12.0 [INFO] tweaked toml for crates.io crate xio_common 0.12.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 65 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding autocfg v0.1.8 (latest: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding crossbeam-channel v0.3.9 (latest: v0.5.13) [INFO] [stderr] Adding crossbeam-utils v0.6.6 (latest: v0.8.20) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding libudev v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding mach v0.1.2 (latest: v0.3.2) [INFO] [stderr] Adding mach v0.2.3 (latest: v0.3.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nix v0.14.1 (latest: v0.29.0) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding rand v0.6.5 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (latest: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (latest: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (latest: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (latest: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding serialport v3.3.0 (latest: v4.5.0) [INFO] [stderr] Adding snafu v0.5.0 (latest: v0.8.4) [INFO] [stderr] Adding snafu-derive v0.5.0 (latest: v0.8.4) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] [stderr] Adding uuid v0.7.4 (latest: v1.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1d846d643363829bb5152c57a101355b7ae3855cbed1ce6633a8c28a0ce4a076 [INFO] running `Command { std: "docker" "start" "-a" "1d846d643363829bb5152c57a101355b7ae3855cbed1ce6633a8c28a0ce4a076", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1d846d643363829bb5152c57a101355b7ae3855cbed1ce6633a8c28a0ce4a076", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d846d643363829bb5152c57a101355b7ae3855cbed1ce6633a8c28a0ce4a076", kill_on_drop: false }` [INFO] [stdout] 1d846d643363829bb5152c57a101355b7ae3855cbed1ce6633a8c28a0ce4a076 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa6e33b490e8f827015e2734448fe57c3c6a75be34e5863eede0bdc153dc8ce9 [INFO] running `Command { std: "docker" "start" "-a" "aa6e33b490e8f827015e2734448fe57c3c6a75be34e5863eede0bdc153dc8ce9", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Checking backtrace v0.3.73 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking libudev v0.2.0 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking uuid v0.7.4 [INFO] [stderr] Compiling snafu-derive v0.5.0 [INFO] [stderr] Checking serialport v3.3.0 [INFO] [stderr] Checking snafu v0.5.0 [INFO] [stderr] Checking xio_base_datatypes v0.8.0 [INFO] [stderr] Checking ommui_broadcast v0.4.0 [INFO] [stderr] Checking xio_common v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::Message` [INFO] [stdout] --> src/messages/mod.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | pub use crate::Message; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::Message` [INFO] [stdout] --> src/messages/mod.rs:2:13 [INFO] [stdout] | [INFO] [stdout] 2 | pub use crate::Message; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RequestItem` is never constructed [INFO] [stdout] --> src/connection.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub(crate) struct RequestItem { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `write_data_types` is never used [INFO] [stdout] --> src/data_type.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) trait DataTypeWriterExt: Write { [INFO] [stdout] | ----------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 15 | fn write_data_types(&mut self, t: &[DataType]) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `DeviceCapabilityWriterExt` is never used [INFO] [stdout] --> src/device_capability.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | pub(crate) trait DeviceCapabilityWriterExt: Write { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `read_i8`, `read_i16`, `read_u32`, `read_i32`, and `read_i64` are never used [INFO] [stdout] --> src/io_helper.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) trait ReadExt: ReadBytesExt { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 12 | fn read_i8(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | fn read_i16(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | fn read_u32(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 28 | fn read_i32(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | fn read_i64(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `write_i8`, `write_i16`, `write_u32`, and `write_i32` are never used [INFO] [stdout] --> src/io_helper.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 43 | pub(crate) trait WriteExt: WriteBytesExt { [INFO] [stdout] | -------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 48 | fn write_i8(&mut self, n: i8) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 56 | fn write_i16(&mut self, n: i16) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | fn write_u32(&mut self, n: u32) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 64 | fn write_i32(&mut self, n: i32) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `JobSetInfoWriterExt` is never used [INFO] [stdout] --> src/job_set_info.rs:37:18 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) trait JobSetInfoWriterExt: Write { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 103 | let tx_port = serialport::open_with_settings(port, &settings) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let mut rx_port = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let mut response_broadcaster = Broadcaster::default(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let mut notification_broadcaster = Broadcaster::default(); [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let stale_connection_broadcaster = Broadcaster::default(); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let response_subscription_manager = [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | response_broadcaster.subscription_manager(); [INFO] [stdout] 114 | let notification_subscription_manager = [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | notification_broadcaster.subscription_manager(); [INFO] [stdout] 116 | let stale_connection_subscription_manager = [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let (rx_shutdown_sender, rx_shutdown_receiver) = bounded(1); [INFO] [stdout] | ------------------ -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | [INFO] [stdout] 121 | let rx_handle = { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let inner = Arc::new(RwLock::new(ConnectionInnerLocked { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok(Connection { [INFO] [stdout] | ____________^ [INFO] [stdout] 187 | | inner, [INFO] [stdout] 188 | | response_subscription_manager, [INFO] [stdout] 189 | | notification_subscription_manager, [INFO] [stdout] 190 | | stale_connection_subscription_manager, [INFO] [stdout] 191 | | stale_connection_broadcaster, [INFO] [stdout] 192 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:300:12 [INFO] [stdout] | [INFO] [stdout] 298 | fn send_and_receive(&mut self, request: Q) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | let response = self.send_and_receive(request.into())?; [INFO] [stdout] 300 | Ok(S::try_from_response(response)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_type.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | DataType::try_from(value).context(error::Io) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_capability.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | DeviceCapability::try_from(value).context(error::Io) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error_code.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | ErrorCode::try_from(value).context(error::Io) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job_stopped_reason.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | JobStoppedReason::try_from(value).context(error::Io) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module_state.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | ModuleState::try_from(value).context(error::Io) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xio_common` (lib) due to 8 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `RequestItem` is never constructed [INFO] [stdout] --> src/connection.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub(crate) struct RequestItem { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `write_data_types` is never used [INFO] [stdout] --> src/data_type.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) trait DataTypeWriterExt: Write { [INFO] [stdout] | ----------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 15 | fn write_data_types(&mut self, t: &[DataType]) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `DeviceCapabilityWriterExt` is never used [INFO] [stdout] --> src/device_capability.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | pub(crate) trait DeviceCapabilityWriterExt: Write { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `read_i8`, `read_i16`, `read_u32`, `read_i32`, and `read_i64` are never used [INFO] [stdout] --> src/io_helper.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) trait ReadExt: ReadBytesExt { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 12 | fn read_i8(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | fn read_i16(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 24 | fn read_u32(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 28 | fn read_i32(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | fn read_i64(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `write_i8`, `write_i16`, `write_u32`, and `write_i32` are never used [INFO] [stdout] --> src/io_helper.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 43 | pub(crate) trait WriteExt: WriteBytesExt { [INFO] [stdout] | -------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 48 | fn write_i8(&mut self, n: i8) -> Result<()> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 56 | fn write_i16(&mut self, n: i16) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | fn write_u32(&mut self, n: u32) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 64 | fn write_i32(&mut self, n: i32) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `JobSetInfoWriterExt` is never used [INFO] [stdout] --> src/job_set_info.rs:37:18 [INFO] [stdout] | [INFO] [stdout] 37 | pub(crate) trait JobSetInfoWriterExt: Write { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 103 | let tx_port = serialport::open_with_settings(port, &settings) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let mut rx_port = [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let mut response_broadcaster = Broadcaster::default(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let mut notification_broadcaster = Broadcaster::default(); [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | let stale_connection_broadcaster = Broadcaster::default(); [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let response_subscription_manager = [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | response_broadcaster.subscription_manager(); [INFO] [stdout] 114 | let notification_subscription_manager = [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | notification_broadcaster.subscription_manager(); [INFO] [stdout] 116 | let stale_connection_subscription_manager = [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let (rx_shutdown_sender, rx_shutdown_receiver) = bounded(1); [INFO] [stdout] | ------------------ -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | [INFO] [stdout] 121 | let rx_handle = { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let inner = Arc::new(RwLock::new(ConnectionInnerLocked { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok(Connection { [INFO] [stdout] | ____________^ [INFO] [stdout] 187 | | inner, [INFO] [stdout] 188 | | response_subscription_manager, [INFO] [stdout] 189 | | notification_subscription_manager, [INFO] [stdout] 190 | | stale_connection_subscription_manager, [INFO] [stdout] 191 | | stale_connection_broadcaster, [INFO] [stdout] 192 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:300:12 [INFO] [stdout] | [INFO] [stdout] 298 | fn send_and_receive(&mut self, request: Q) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | let response = self.send_and_receive(request.into())?; [INFO] [stdout] 300 | Ok(S::try_from_response(response)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data_type.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | DataType::try_from(value).context(error::Io) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/device_capability.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | DeviceCapability::try_from(value).context(error::Io) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error_code.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | ErrorCode::try_from(value).context(error::Io) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/job_stopped_reason.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | JobStoppedReason::try_from(value).context(error::Io) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/module_state.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | ModuleState::try_from(value).context(error::Io) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xio_common` (lib test) due to 8 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "aa6e33b490e8f827015e2734448fe57c3c6a75be34e5863eede0bdc153dc8ce9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa6e33b490e8f827015e2734448fe57c3c6a75be34e5863eede0bdc153dc8ce9", kill_on_drop: false }` [INFO] [stdout] aa6e33b490e8f827015e2734448fe57c3c6a75be34e5863eede0bdc153dc8ce9