[INFO] fetching crate xilo 0.3.1... [INFO] checking xilo-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xilo 0.3.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate xilo 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xilo 0.3.1 [INFO] finished tweaking crates.io crate xilo 0.3.1 [INFO] tweaked toml for crates.io crate xilo 0.3.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate xilo 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9267f702b3707966814939ee135797c06c1b9da9aab13ba400bcff9a197ada2 [INFO] running `Command { std: "docker" "start" "-a" "b9267f702b3707966814939ee135797c06c1b9da9aab13ba400bcff9a197ada2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9267f702b3707966814939ee135797c06c1b9da9aab13ba400bcff9a197ada2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9267f702b3707966814939ee135797c06c1b9da9aab13ba400bcff9a197ada2", kill_on_drop: false }` [INFO] [stdout] b9267f702b3707966814939ee135797c06c1b9da9aab13ba400bcff9a197ada2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ed31d771b1004edf16e352fe1c6d764ace9fb1adc129af520110c20e8bd732f1 [INFO] running `Command { std: "docker" "start" "-a" "ed31d771b1004edf16e352fe1c6d764ace9fb1adc129af520110c20e8bd732f1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling rustix v0.38.8 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling serde v1.0.183 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling thiserror v1.0.47 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Compiling serde_derive v1.0.183 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking clap_builder v4.3.22 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.7 [INFO] [stderr] Compiling thiserror-impl v1.0.47 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking clap v4.3.22 [INFO] [stderr] Checking xilo v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 20 | match File::open(xilo_config).map_err(|err| err.kind()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remover.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 68 | File => fs::remove_file(&self.name).map_err(|reason| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | / (XiloError::RemoveFilePermanentlyFailed { [INFO] [stdout] 70 | | filename: self.name.clone(), [INFO] [stdout] 71 | | reason, [INFO] [stdout] 72 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remover.rs:76:25 [INFO] [stdout] | [INFO] [stdout] 75 | Directory => fs::remove_dir_all(&self.name).map_err(|reason| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | / (XiloError::RemoveDirPermanentlyFailed { [INFO] [stdout] 77 | | dirname: self.name.clone(), [INFO] [stdout] 78 | | reason, [INFO] [stdout] 79 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remover.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 118 | fs::rename(&self.name, new_name).map_err(|reason| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | / match self.handle_type { [INFO] [stdout] 120 | | File => XiloError::RemoveFileFailed { [INFO] [stdout] 121 | | filename: self.name.clone(), [INFO] [stdout] 122 | | reason, [INFO] [stdout] ... | [INFO] [stdout] 127 | | }, [INFO] [stdout] 128 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xilo` (bin "xilo" test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 20 | match File::open(xilo_config).map_err(|err| err.kind()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remover.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 68 | File => fs::remove_file(&self.name).map_err(|reason| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | / (XiloError::RemoveFilePermanentlyFailed { [INFO] [stdout] 70 | | filename: self.name.clone(), [INFO] [stdout] 71 | | reason, [INFO] [stdout] 72 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remover.rs:76:25 [INFO] [stdout] | [INFO] [stdout] 75 | Directory => fs::remove_dir_all(&self.name).map_err(|reason| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | / (XiloError::RemoveDirPermanentlyFailed { [INFO] [stdout] 77 | | dirname: self.name.clone(), [INFO] [stdout] 78 | | reason, [INFO] [stdout] 79 | | }) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/remover.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 118 | fs::rename(&self.name, new_name).map_err(|reason| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | / match self.handle_type { [INFO] [stdout] 120 | | File => XiloError::RemoveFileFailed { [INFO] [stdout] 121 | | filename: self.name.clone(), [INFO] [stdout] 122 | | reason, [INFO] [stdout] ... | [INFO] [stdout] 127 | | }, [INFO] [stdout] 128 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xilo` (bin "xilo") due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "ed31d771b1004edf16e352fe1c6d764ace9fb1adc129af520110c20e8bd732f1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ed31d771b1004edf16e352fe1c6d764ace9fb1adc129af520110c20e8bd732f1", kill_on_drop: false }` [INFO] [stdout] ed31d771b1004edf16e352fe1c6d764ace9fb1adc129af520110c20e8bd732f1