[INFO] fetching crate xh 0.22.2... [INFO] checking xh-0.22.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xh 0.22.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate xh 0.22.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xh 0.22.2 [INFO] finished tweaking crates.io crate xh 0.22.2 [INFO] tweaked toml for crates.io crate xh 0.22.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate xh 0.22.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bbe7b298cb7b2d1bceb7b6d61741399b357cb13119e83064595d5a671c62fcaf [INFO] running `Command { std: "docker" "start" "-a" "bbe7b298cb7b2d1bceb7b6d61741399b357cb13119e83064595d5a671c62fcaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bbe7b298cb7b2d1bceb7b6d61741399b357cb13119e83064595d5a671c62fcaf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bbe7b298cb7b2d1bceb7b6d61741399b357cb13119e83064595d5a671c62fcaf", kill_on_drop: false }` [INFO] [stdout] bbe7b298cb7b2d1bceb7b6d61741399b357cb13119e83064595d5a671c62fcaf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0994f4f8b15c18f96e366da002643029d2e9cee92a23f8dda5f0b895176413dd [INFO] running `Command { std: "docker" "start" "-a" "0994f4f8b15c18f96e366da002643029d2e9cee92a23f8dda5f0b895176413dd", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling cc v1.0.92 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking rustls-pki-types v1.4.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling onig_sys v69.8.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Compiling powerfmt v0.2.0 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Compiling deranged v0.3.11 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling adler v1.0.2 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Compiling rustls v0.22.3 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling miniz_oxide v0.7.2 [INFO] [stderr] Compiling quick-xml v0.31.0 [INFO] [stderr] Compiling time v0.3.36 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking rustls-webpki v0.102.2 [INFO] [stderr] Compiling cookie v0.17.0 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Compiling base64 v0.21.7 [INFO] [stderr] Compiling line-wrap v0.2.0 [INFO] [stderr] Checking h2 v0.4.4 [INFO] [stderr] Compiling linked-hash-map v0.5.6 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling onig v6.4.0 [INFO] [stderr] Compiling yaml-rust v0.4.5 [INFO] [stderr] Compiling plist v1.6.1 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Compiling flate2 v1.0.28 [INFO] [stderr] Compiling bincode v1.3.3 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking psl-types v2.0.11 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking publicsuffix v2.2.3 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking tokio-socks v0.5.1 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking rustls-native-certs v0.7.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hyper v1.2.0 [INFO] [stderr] Checking brotli-decompressor v2.5.1 [INFO] [stderr] Compiling syntect v5.2.0 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking rtoolbox v0.0.2 [INFO] [stderr] Checking webpki-roots v0.26.1 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking digest_auth v0.3.1 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking brotli v3.5.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking rpassword v7.3.1 [INFO] [stderr] Checking jsonxf v1.1.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking chardetng v0.1.17 [INFO] [stderr] Checking encoding_rs_io v0.1.7 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Checking os_display v0.1.3 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking regex-lite v0.1.5 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking mime2ext v0.1.52 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde-transcode v1.1.1 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking hyper-rustls v0.26.0 [INFO] [stderr] Compiling xh v0.22.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking cookie_store v0.20.0 [INFO] [stderr] Checking reqwest v0.12.3 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:41:27 [INFO] [stdout] | [INFO] [stdout] 40 | fn body(self) -> Pin> + Send>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let fut = async { self.collect().await.unwrap().to_bytes().to_vec() }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:46:57 [INFO] [stdout] | [INFO] [stdout] 45 | fn body_as_string(self) -> Pin + Send>> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let fut = async { String::from_utf8(self.body().await).unwrap() }; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 127 | let server = server::http(|req| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | / hyper::Response::builder() [INFO] [stdout] 133 | | .header(hyper::header::CONTENT_TYPE, "application/json") [INFO] [stdout] 134 | | .body(r#"{"got":"name","status":"ok"}"#.into()) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 194 | let server = server::http(|req| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | assert_eq!(req.method(), "GET"); [INFO] [stdout] 196 | hyper::Response::builder().body("foobar\n".into()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 218 | let server = server::http(|req| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | assert_eq!(req.method(), "OPTIONS"); [INFO] [stdout] 220 | / hyper::Response::builder() [INFO] [stdout] 221 | | .header("Allow", "GET, HEAD, OPTIONS") [INFO] [stdout] 222 | | .body("".into()) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:409:9 [INFO] [stdout] | [INFO] [stdout] 403 | let server = server::http(|req| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 409 | / hyper::Response::builder() [INFO] [stdout] 410 | | .header("X-Foo", "Bar") [INFO] [stdout] 411 | | .header("Date", "N/A") [INFO] [stdout] 412 | | .body("a body".into()) [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:467:9 [INFO] [stdout] | [INFO] [stdout] 465 | let server = server::http(|req| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 466 | assert_eq!(req.headers()["accept-encoding"], "identity"); [INFO] [stdout] 467 | / hyper::Response::builder() [INFO] [stdout] 468 | | .body(r#"{"ids":[1,2,3]}"#.into()) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:1154:9 [INFO] [stdout] | [INFO] [stdout] 1152 | let server = server::http(|req| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1153 | assert_eq!(req.method(), "CONNECT"); [INFO] [stdout] 1154 | / hyper::Response::builder() [INFO] [stdout] 1155 | | .status(502) [INFO] [stdout] 1156 | | .body("".into()) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:1170:9 [INFO] [stdout] | [INFO] [stdout] 1168 | let server = server::http(|req| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1169 | assert_eq!(req.method(), "GET"); [INFO] [stdout] 1170 | / hyper::Response::builder() [INFO] [stdout] 1171 | | .status(502) [INFO] [stdout] 1172 | | .body("".into()) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:1186:9 [INFO] [stdout] | [INFO] [stdout] 1184 | let server = server::http(|req| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1185 | assert_eq!(req.method(), "CONNECT"); [INFO] [stdout] 1186 | / hyper::Response::builder() [INFO] [stdout] 1187 | | .status(502) [INFO] [stdout] 1188 | | .body("".into()) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:1202:9 [INFO] [stdout] | [INFO] [stdout] 1200 | let mut first_server = server::http(|req| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1201 | assert_eq!(req.headers()["host"], "example.test"); [INFO] [stdout] 1202 | / hyper::Response::builder() [INFO] [stdout] 1203 | | .status(500) [INFO] [stdout] 1204 | | .body("".into()) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:1210:9 [INFO] [stdout] | [INFO] [stdout] 1208 | let second_server = server::http(|req| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1209 | assert_eq!(req.headers()["host"], "example.test"); [INFO] [stdout] 1210 | / hyper::Response::builder() [INFO] [stdout] 1211 | | .status(200) [INFO] [stdout] 1212 | | .body("".into()) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:1327:9 [INFO] [stdout] | [INFO] [stdout] 1323 | let server = server::http(|req| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1327 | / hyper::Response::builder() [INFO] [stdout] 1328 | | .header("X-Foo", "Bar") [INFO] [stdout] 1329 | | .header("Date", "N/A") [INFO] [stdout] 1330 | | .header("Content-Type", "application/json") [INFO] [stdout] 1331 | | .body(r#"{"hello":"world"}"#.into()) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:2421:9 [INFO] [stdout] | [INFO] [stdout] 2416 | let server = server::http(|req| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2421 | / hyper::Response::builder() [INFO] [stdout] 2422 | | .header("set-cookie", "lang=en") [INFO] [stdout] 2423 | | .header("set-cookie", "cook1=one") [INFO] [stdout] 2424 | | .body("".into()) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:3010:9 [INFO] [stdout] | [INFO] [stdout] 3007 | let server1 = server::http(|req| async move { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3010 | / hyper::Response::builder() [INFO] [stdout] 3011 | | .header("Date", "N/A") [INFO] [stdout] 3012 | | .body("final destination".into()) [INFO] [stdout] | |_____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/cli.rs:3022:13 [INFO] [stdout] | [INFO] [stdout] 3017 | let server2 = server::http(move |req| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3022 | / hyper::Response::builder() [INFO] [stdout] 3023 | | .status(302) [INFO] [stdout] 3024 | | .header("Location", server1_base_url) [INFO] [stdout] 3025 | | .body("redirecting...".into()) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/server/mod.rs:92:16 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn http(func: F) -> Server [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | http_inner(Arc::new(move |req| Box::new(Box::pin(func(req))))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/server/mod.rs:92:45 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn http(func: F) -> Server [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | http_inner(Arc::new(move |req| Box::new(Box::pin(func(req))))) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/server/mod.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 98 | fn http_inner(func: Arc) -> Server { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | // Spawn new runtime in thread to prevent reactor execution context conflict [INFO] [stdout] 100 | / thread::spawn(move || { [INFO] [stdout] 101 | | let rt = runtime::Builder::new_current_thread() [INFO] [stdout] 102 | | .enable_all() [INFO] [stdout] 103 | | .build() [INFO] [stdout] ... | [INFO] [stdout] 172 | | }) [INFO] [stdout] 173 | | .join() [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/server/mod.rs:167:26 [INFO] [stdout] | [INFO] [stdout] 98 | fn http_inner(func: Arc) -> Server { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | let rt = runtime::Builder::new_current_thread() [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 105 | let successful_hits = Arc::new(Mutex::new(0)); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let total_hits = Arc::new(Mutex::new(0)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let listener = rt.block_on(async move { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let (shutdown_tx, shutdown_rx) = oneshot::channel(); [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let (panic_tx, panic_rx) = std_mpsc::channel(); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | shutdown_tx: Some(shutdown_tx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 20 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xh` (test "cli") due to 21 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:66:11 [INFO] [stdout] | [INFO] [stdout] 62 | let args = Cli::parse(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | match run(args) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/auth.rs:77:38 [INFO] [stdout] | [INFO] [stdout] 75 | fn handle(&mut self, mut ctx: Context, mut request: Request) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let mut response = self.next(&mut ctx, clone_request(&mut request)?)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | match response.headers().get(WWW_AUTHENTICATE) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:74:24 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn file(file: std::fs::File) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Self { [INFO] [stdout] 74 | inner: Ansi::new(BufWriter::new(Inner::File(file))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:457:15 [INFO] [stdout] | [INFO] [stdout] 452 | pub fn parse_from(iter: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 457 | match Self::try_parse_from(iter) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:618:9 [INFO] [stdout] | [INFO] [stdout] 593 | ... let app = ::command(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 602 | ... let negations: Vec<_> = app [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 618 | / ... app.args(negations) [INFO] [stdout] 619 | | ... .after_help(format!("Each option can be reset with a --no-OPTION argument.\n\nRun \"{} help\" for more complete documentation.", env!("CARGO_PKG_NAME"))) [INFO] [stdout] | |___________________________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:644:11 [INFO] [stdout] | [INFO] [stdout] 632 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 644 | match serde_json::from_str::(&content) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:32:64 [INFO] [stdout] | [INFO] [stdout] 32 | .find_map(|value| value.to_str().ok().and_then(|value| value.parse().ok())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:38:68 [INFO] [stdout] | [INFO] [stdout] 38 | .find_map(|value| value.to_str().ok().and_then(|value| value.parse().ok())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nested_json.rs:167:8 [INFO] [stdout] | [INFO] [stdout] 161 | root: Option, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | path: &[PathAction], [INFO] [stdout] 163 | value: Value, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | Ok(match root { [INFO] [stdout] | ________^ [INFO] [stdout] 168 | | Some(Value::Object(mut obj)) => { [INFO] [stdout] 169 | | let key = match &path[0] { [INFO] [stdout] 170 | | PathAction::Key(v, ..) => v.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 209 | | }, [INFO] [stdout] 210 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/netrc.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 46 | let file = open_netrc()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let file = DecodeReaderBytesBuilder::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let file = BufReader::new(file); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let parser = Parser::new(file, host); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | // Logging I/O errors would be nice. [INFO] [stdout] 57 | parser.parse().ok()? [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_items.rs:294:12 [INFO] [stdout] | [INFO] [stdout] 262 | let mut headers = HeaderMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | #[allow(clippy::mutable_key_type)] [INFO] [stdout] 264 | let mut headers_to_unset = HashSet::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | Ok((headers, headers_to_unset)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_items.rs:337:12 [INFO] [stdout] | [INFO] [stdout] 310 | fn body_as_json(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 311 | use serde_json::Value; [INFO] [stdout] 312 | let mut body = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | Ok(Body::Json(body.unwrap_or(Value::Null))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_items.rs:360:12 [INFO] [stdout] | [INFO] [stdout] 340 | fn body_as_form(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | Ok(Body::Form(text_fields)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_items.rs:399:12 [INFO] [stdout] | [INFO] [stdout] 363 | fn body_as_multipart(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | let mut form = multipart::Form::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 399 | Ok(Body::Multipart(form)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 180 | let content = match fs::read_to_string(&path) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | Ok(content) => serde_json::from_str::(&content)?.migrate(), [INFO] [stdout] 182 | Err(err) if err.kind() == io::ErrorKind::NotFound => Content::default(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Err(err) => return Err(err.into()), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok(Session { [INFO] [stdout] | ____________^ [INFO] [stdout] 187 | | url, [INFO] [stdout] 188 | | path, [INFO] [stdout] 189 | | read_only, [INFO] [stdout] 190 | | content, [INFO] [stdout] 191 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:199:50 [INFO] [stdout] | [INFO] [stdout] 199 | .map(|Header { name, value }| Ok((name.try_into()?, value.try_into()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vendored/reqwest_cookie_store.rs:58:26 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(cookie_store: CookieStore) -> CookieStoreMutex { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | CookieStoreMutex(Mutex::new(cookie_store)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vendored/reqwest_cookie_store.rs:96:27 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn new(cookie_store: CookieStore) -> CookieStoreRwLock { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | CookieStoreRwLock(RwLock::new(cookie_store)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xh` (bin "xh") due to 19 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:66:11 [INFO] [stdout] | [INFO] [stdout] 62 | let args = Cli::parse(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | match run(args) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/auth.rs:77:38 [INFO] [stdout] | [INFO] [stdout] 75 | fn handle(&mut self, mut ctx: Context, mut request: Request) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let mut response = self.next(&mut ctx, clone_request(&mut request)?)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | match response.headers().get(WWW_AUTHENTICATE) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/buffer.rs:74:24 [INFO] [stdout] | [INFO] [stdout] 72 | pub fn file(file: std::fs::File) -> Self { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 73 | Self { [INFO] [stdout] 74 | inner: Ansi::new(BufWriter::new(Inner::File(file))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:457:15 [INFO] [stdout] | [INFO] [stdout] 452 | pub fn parse_from(iter: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 457 | match Self::try_parse_from(iter) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:618:9 [INFO] [stdout] | [INFO] [stdout] 593 | ... let app = ::command(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 602 | ... let negations: Vec<_> = app [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 618 | / ... app.args(negations) [INFO] [stdout] 619 | | ... .after_help(format!("Each option can be reset with a --no-OPTION argument.\n\nRun \"{} help\" for more complete documentation.", env!("CARGO_PKG_NAME"))) [INFO] [stdout] | |___________________________________________________________________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:644:11 [INFO] [stdout] | [INFO] [stdout] 632 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 644 | match serde_json::from_str::(&content) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:1373:13 [INFO] [stdout] | [INFO] [stdout] 1367 | fn parse(args: I) -> clap::error::Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1373 | / Some("xh".into()) [INFO] [stdout] 1374 | | .into_iter() [INFO] [stdout] 1375 | | .chain(args.into_iter().map(Into::into)), [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:32:64 [INFO] [stdout] | [INFO] [stdout] 32 | .find_map(|value| value.to_str().ok().and_then(|value| value.parse().ok())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:38:68 [INFO] [stdout] | [INFO] [stdout] 38 | .find_map(|value| value.to_str().ok().and_then(|value| value.parse().ok())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:151:15 [INFO] [stdout] | [INFO] [stdout] 149 | let mut reader = decompress(&mut uncompressed_data, Some(CompressionType::Gzip)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | let mut buffer = Vec::new(); [INFO] [stdout] 151 | match reader.read_to_end(&mut buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decoder.rs:173:15 [INFO] [stdout] | [INFO] [stdout] 171 | let mut reader = decompress(&mut sad_reader, Some(CompressionType::Gzip)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | let mut buffer = Vec::new(); [INFO] [stdout] 173 | match reader.read_to_end(&mut buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nested_json.rs:167:8 [INFO] [stdout] | [INFO] [stdout] 161 | root: Option, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | path: &[PathAction], [INFO] [stdout] 163 | value: Value, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | Ok(match root { [INFO] [stdout] | ________^ [INFO] [stdout] 168 | | Some(Value::Object(mut obj)) => { [INFO] [stdout] 169 | | let key = match &path[0] { [INFO] [stdout] 170 | | PathAction::Key(v, ..) => v.to_string(), [INFO] [stdout] ... | [INFO] [stdout] 209 | | }, [INFO] [stdout] 210 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/netrc.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 46 | let file = open_netrc()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let file = DecodeReaderBytesBuilder::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let file = BufReader::new(file); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | let parser = Parser::new(file, host); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | // Logging I/O errors would be nice. [INFO] [stdout] 57 | parser.parse().ok()? [INFO] [stdout] | ^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_items.rs:294:12 [INFO] [stdout] | [INFO] [stdout] 262 | let mut headers = HeaderMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 263 | #[allow(clippy::mutable_key_type)] [INFO] [stdout] 264 | let mut headers_to_unset = HashSet::new(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | Ok((headers, headers_to_unset)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_items.rs:337:12 [INFO] [stdout] | [INFO] [stdout] 310 | fn body_as_json(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 311 | use serde_json::Value; [INFO] [stdout] 312 | let mut body = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | Ok(Body::Json(body.unwrap_or(Value::Null))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_items.rs:360:12 [INFO] [stdout] | [INFO] [stdout] 340 | fn body_as_form(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | Ok(Body::Form(text_fields)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request_items.rs:399:12 [INFO] [stdout] | [INFO] [stdout] 363 | fn body_as_multipart(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 364 | let mut form = multipart::Form::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 399 | Ok(Body::Multipart(form)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 180 | let content = match fs::read_to_string(&path) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | Ok(content) => serde_json::from_str::(&content)?.migrate(), [INFO] [stdout] 182 | Err(err) if err.kind() == io::ErrorKind::NotFound => Content::default(), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Err(err) => return Err(err.into()), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok(Session { [INFO] [stdout] | ____________^ [INFO] [stdout] 187 | | url, [INFO] [stdout] 188 | | path, [INFO] [stdout] 189 | | read_only, [INFO] [stdout] 190 | | content, [INFO] [stdout] 191 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/session.rs:199:50 [INFO] [stdout] | [INFO] [stdout] 199 | .map(|Header { name, value }| Ok((name.try_into()?, value.try_into()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vendored/reqwest_cookie_store.rs:58:26 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(cookie_store: CookieStore) -> CookieStoreMutex { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | CookieStoreMutex(Mutex::new(cookie_store)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vendored/reqwest_cookie_store.rs:96:27 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn new(cookie_store: CookieStore) -> CookieStoreRwLock { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | CookieStoreRwLock(RwLock::new(cookie_store)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xh` (bin "xh" test) due to 22 previous errors [INFO] running `Command { std: "docker" "inspect" "0994f4f8b15c18f96e366da002643029d2e9cee92a23f8dda5f0b895176413dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0994f4f8b15c18f96e366da002643029d2e9cee92a23f8dda5f0b895176413dd", kill_on_drop: false }` [INFO] [stdout] 0994f4f8b15c18f96e366da002643029d2e9cee92a23f8dda5f0b895176413dd