[INFO] fetching crate xensec-internal-tools 0.1.0... [INFO] checking xensec-internal-tools-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xensec-internal-tools 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate xensec-internal-tools 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xensec-internal-tools 0.1.0 [INFO] finished tweaking crates.io crate xensec-internal-tools 0.1.0 [INFO] tweaked toml for crates.io crate xensec-internal-tools 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate xensec-internal-tools 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 001846d92f038716aa761a23d33249a224f62eccccd42118f6f3ec0aabea4981 [INFO] running `Command { std: "docker" "start" "-a" "001846d92f038716aa761a23d33249a224f62eccccd42118f6f3ec0aabea4981", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "001846d92f038716aa761a23d33249a224f62eccccd42118f6f3ec0aabea4981", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "001846d92f038716aa761a23d33249a224f62eccccd42118f6f3ec0aabea4981", kill_on_drop: false }` [INFO] [stdout] 001846d92f038716aa761a23d33249a224f62eccccd42118f6f3ec0aabea4981 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1597b7b1012ea4ccc8eaeb037a22ec00fd37a5f9b40f189ca283cd130b8d0627 [INFO] running `Command { std: "docker" "start" "-a" "1597b7b1012ea4ccc8eaeb037a22ec00fd37a5f9b40f189ca283cd130b8d0627", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling futures-core v0.3.15 [INFO] [stderr] Compiling tokio v1.7.1 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling futures-task v0.3.15 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Compiling futures-util v0.3.15 [INFO] [stderr] Compiling gimli v0.24.0 [INFO] [stderr] Compiling openssl v0.10.35 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling adler v1.0.2 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling httparse v1.3.6 [INFO] [stderr] Checking tinyvec v1.2.0 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking http v0.2.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking tracing-core v0.1.18 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling void v1.0.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking futures-sink v0.3.15 [INFO] [stderr] Compiling futures-channel v0.3.15 [INFO] [stderr] Compiling rustc-demangle v0.1.20 [INFO] [stderr] Compiling object v0.25.3 [INFO] [stderr] Compiling native-tls v0.2.7 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Compiling jobserver v0.1.22 [INFO] [stderr] Checking openssl-probe v0.1.4 [INFO] [stderr] Checking futures-io v0.3.15 [INFO] [stderr] Checking tracing v0.1.26 [INFO] [stderr] Compiling cc v1.0.68 [INFO] [stderr] Compiling unreachable v1.0.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking unicode-bidi v0.3.5 [INFO] [stderr] Compiling ascii v0.9.3 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Checking httpdate v0.3.2 [INFO] [stderr] Compiling byteorder v1.4.3 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking socket2 v0.4.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling combine v3.8.1 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling encoding_rs v0.8.28 [INFO] [stderr] Compiling openssl-sys v0.9.65 [INFO] [stderr] Compiling backtrace v0.3.60 [INFO] [stderr] Compiling libz-sys v1.1.3 [INFO] [stderr] Checking tower-service v0.3.1 [INFO] [stderr] Compiling libssh2-sys v0.2.21 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking doc-comment v0.3.3 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling ahash v0.7.4 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling async-trait v0.1.50 [INFO] [stderr] Checking http-body v0.4.2 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Compiling derive_builder v0.9.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking tokio-util v0.6.7 [INFO] [stderr] Checking ipnet v2.3.1 [INFO] [stderr] Compiling hyperx v1.3.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling addr2line v0.15.2 [INFO] [stderr] Compiling libgit2-sys v0.12.21+1.1.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling libsqlite3-sys v0.22.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling anyhow v1.0.41 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking arc-swap v1.3.0 [INFO] [stderr] Checking directories v3.0.2 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking h2 v0.3.3 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking hashlink v0.7.0 [INFO] [stderr] Checking rusqlite v0.25.3 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Checking tokio-native-tls v0.3.0 [INFO] [stderr] Compiling synstructure v0.12.4 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling pin-project-internal v1.0.7 [INFO] [stderr] Compiling thiserror-impl v1.0.25 [INFO] [stderr] Compiling snafu-derive v0.6.10 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Compiling strum_macros v0.21.1 [INFO] [stderr] Compiling fehler-macros v1.0.0 [INFO] [stderr] Compiling derive_more v0.99.14 [INFO] [stderr] Compiling merge_derive v0.1.0 [INFO] [stderr] Compiling extend v1.1.0 [INFO] [stderr] Compiling failure v0.1.8 [INFO] [stderr] Compiling graphql-parser v0.2.3 [INFO] [stderr] Checking merge v0.1.0 [INFO] [stderr] Checking thiserror v1.0.25 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Checking snafu v0.6.10 [INFO] [stderr] Checking pin-project v1.0.7 [INFO] [stderr] Checking fehler v1.0.0 [INFO] [stderr] Checking hyper v0.14.5 [INFO] [stderr] Checking strum v0.21.0 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling derive_builder_core v0.9.0 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking serde_urlencoded v0.7.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking serde_path_to_error v0.1.4 [INFO] [stderr] Checking ron v0.6.4 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking git2 v0.13.20 [INFO] [stderr] Compiling graphql_client_codegen v0.8.0 [INFO] [stderr] Checking reqwest v0.11.4 [INFO] [stderr] Checking json_value_merge v0.1.2 [INFO] [stderr] Checking octocrab v0.9.1 [INFO] [stderr] Compiling graphql_query_derive v0.8.0 [INFO] [stderr] Checking graphql_client v0.8.0 [INFO] [stderr] Checking gitlab v0.1311.2 [INFO] [stderr] Checking gitforge v0.2.0 [INFO] [stderr] Checking xensec-internal-tools v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `done` is never read [INFO] [stdout] --> src/cache.rs:179:3 [INFO] [stdout] | [INFO] [stdout] 178 | pub struct XsaDoneData { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 179 | done: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `XsaDoneData` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `cfg` is never read [INFO] [stdout] --> src/upstream.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct Upstream { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 31 | forge: Box, [INFO] [stdout] 32 | cfg: Arc, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Upstream` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 198 | let db = rusqlite::Connection::open(&cfg.done_cache) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Cache { db, cfg: cfg.clone(), refreshed: default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn with(&mut self, mut f: F) -> O [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | / 'ret: loop { for retry in 0.. { match (||{ [INFO] [stdout] 216 | | let mut trans = self.db.transaction().context("start transaction")?; [INFO] [stdout] 217 | | let r = f(&mut trans)?; [INFO] [stdout] 218 | | trans.commit().context("commit")?; [INFO] [stdout] ... | [INFO] [stdout] 232 | | Ok(r) => break 'ret r, [INFO] [stdout] 233 | | } } } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 259 | pub fn lookup(&mut self, xsa: XsaNum, key: &T::Key, mut calc: F) -> T [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | let got = (||{ [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 340 | / got [INFO] [stdout] 341 | | .with_context(|| format!("key={:?}", key)) [INFO] [stdout] 342 | | .context("lookup in cache db")? [INFO] [stdout] 343 | | .0 [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:328:18 [INFO] [stdout] | [INFO] [stdout] 276 | let (data, refresh_token) = (||{ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let data = data.map(Ok).unwrap_or_else(|| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | Ok::<_,AE>((data, hit)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:294:55 [INFO] [stdout] | [INFO] [stdout] 280 | let mut stmt = self.db.prepare_cached(&stmt).context("prepare")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | let mut data = stmt.query(keys.as_slice()).context("query")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | let data = data.next().context("get query row")?; [INFO] [stdout] 283 | let data = data.map(|row| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | Ok::<(Option, Option),AE>((data, refresh_token)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analysis.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 44 | #[derive(Serialize,Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 151 | let cfg = Arc::new(cfg); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let mut cache = cache::Cache::new(&cfg)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let xsas = xsagit::Repo::new(&cfg, &mut cache)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let cvelist = cvelist::Local::new(&cfg, &mut cache)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let upstream = Upstream::new(&cfg, &cvelist)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | // xxx pull xsas, cves [INFO] [stdout] 157 | Ctx { cfg, xsas, cache, cvelist, upstream } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/githelp.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 29 | let commit = self.g2().find_commit(oid).context("get commit")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let tree = commit.tree().context("get tree")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Ok::<_,AE>(Some(tree)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 46 | let forge = cfg.cvelist_upstream.forge()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | / Upstream { [INFO] [stdout] 55 | | cvelist_repo_upstream: rrepo(&cfg.cvelist_remote_upstream)?, [INFO] [stdout] 56 | | cvelist_repo_xensec: rrepo(&cfg.cvelist_remote_xensec )?, [INFO] [stdout] 57 | | forge, [INFO] [stdout] 58 | | cfg: cfg.clone(), [INFO] [stdout] 59 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream.rs:48:37 [INFO] [stdout] | [INFO] [stdout] 48 | let rrepo = |remote_name: &str| (||{ [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 49 | | let remote_url = cvelist.remote_url(remote_name)?; [INFO] [stdout] 50 | | let repo = forge.remote_url_to_repo(&remote_url)?; [INFO] [stdout] 51 | | Ok::<_,AE>(repo) [INFO] [stdout] 52 | | })().with_context(|| remote_name.to_owned()).context("find remote repo"); [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream.rs:73:7 [INFO] [stdout] | [INFO] [stdout] 73 | / anyhow!("unprocessable response: {} ", s) [INFO] [stdout] 74 | | .context(format!("req={:?}", req)) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `done` is never read [INFO] [stdout] --> src/cache.rs:179:3 [INFO] [stdout] | [INFO] [stdout] 178 | pub struct XsaDoneData { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 179 | done: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `XsaDoneData` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `cfg` is never read [INFO] [stdout] --> src/upstream.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct Upstream { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 31 | forge: Box, [INFO] [stdout] 32 | cfg: Arc, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Upstream` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:207:5 [INFO] [stdout] | [INFO] [stdout] 198 | let db = rusqlite::Connection::open(&cfg.done_cache) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Cache { db, cfg: cfg.clone(), refreshed: default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn with(&mut self, mut f: F) -> O [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | / 'ret: loop { for retry in 0.. { match (||{ [INFO] [stdout] 216 | | let mut trans = self.db.transaction().context("start transaction")?; [INFO] [stdout] 217 | | let r = f(&mut trans)?; [INFO] [stdout] 218 | | trans.commit().context("commit")?; [INFO] [stdout] ... | [INFO] [stdout] 232 | | Ok(r) => break 'ret r, [INFO] [stdout] 233 | | } } } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 259 | pub fn lookup(&mut self, xsa: XsaNum, key: &T::Key, mut calc: F) -> T [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | let got = (||{ [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 340 | / got [INFO] [stdout] 341 | | .with_context(|| format!("key={:?}", key)) [INFO] [stdout] 342 | | .context("lookup in cache db")? [INFO] [stdout] 343 | | .0 [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:328:18 [INFO] [stdout] | [INFO] [stdout] 276 | let (data, refresh_token) = (||{ [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 300 | let data = data.map(Ok).unwrap_or_else(|| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | Ok::<_,AE>((data, hit)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:294:55 [INFO] [stdout] | [INFO] [stdout] 280 | let mut stmt = self.db.prepare_cached(&stmt).context("prepare")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 281 | let mut data = stmt.query(keys.as_slice()).context("query")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | let data = data.next().context("get query row")?; [INFO] [stdout] 283 | let data = data.map(|row| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 294 | Ok::<(Option, Option),AE>((data, refresh_token)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/analysis.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 44 | #[derive(Serialize,Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:157:5 [INFO] [stdout] | [INFO] [stdout] 151 | let cfg = Arc::new(cfg); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let mut cache = cache::Cache::new(&cfg)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let xsas = xsagit::Repo::new(&cfg, &mut cache)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let cvelist = cvelist::Local::new(&cfg, &mut cache)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let upstream = Upstream::new(&cfg, &cvelist)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | // xxx pull xsas, cves [INFO] [stdout] 157 | Ctx { cfg, xsas, cache, cvelist, upstream } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/githelp.rs:31:18 [INFO] [stdout] | [INFO] [stdout] 29 | let commit = self.g2().find_commit(oid).context("get commit")?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let tree = commit.tree().context("get tree")?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Ok::<_,AE>(Some(tree)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 46 | let forge = cfg.cvelist_upstream.forge()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | / Upstream { [INFO] [stdout] 55 | | cvelist_repo_upstream: rrepo(&cfg.cvelist_remote_upstream)?, [INFO] [stdout] 56 | | cvelist_repo_xensec: rrepo(&cfg.cvelist_remote_xensec )?, [INFO] [stdout] 57 | | forge, [INFO] [stdout] 58 | | cfg: cfg.clone(), [INFO] [stdout] 59 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream.rs:48:37 [INFO] [stdout] | [INFO] [stdout] 48 | let rrepo = |remote_name: &str| (||{ [INFO] [stdout] | _____________________________________^ [INFO] [stdout] 49 | | let remote_url = cvelist.remote_url(remote_name)?; [INFO] [stdout] 50 | | let repo = forge.remote_url_to_repo(&remote_url)?; [INFO] [stdout] 51 | | Ok::<_,AE>(repo) [INFO] [stdout] 52 | | })().with_context(|| remote_name.to_owned()).context("find remote repo"); [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upstream.rs:73:7 [INFO] [stdout] | [INFO] [stdout] 73 | / anyhow!("unprocessable response: {} ", s) [INFO] [stdout] 74 | | .context(format!("req={:?}", req)) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xensec-internal-tools` (lib test) due to 12 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 11 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xensec-internal-tools` (lib) due to 12 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1597b7b1012ea4ccc8eaeb037a22ec00fd37a5f9b40f189ca283cd130b8d0627", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1597b7b1012ea4ccc8eaeb037a22ec00fd37a5f9b40f189ca283cd130b8d0627", kill_on_drop: false }` [INFO] [stdout] 1597b7b1012ea4ccc8eaeb037a22ec00fd37a5f9b40f189ca283cd130b8d0627