[INFO] fetching crate xdlol 0.0.0... [INFO] checking xdlol-0.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xdlol 0.0.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate xdlol 0.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xdlol 0.0.0 [INFO] finished tweaking crates.io crate xdlol 0.0.0 [INFO] tweaked toml for crates.io crate xdlol 0.0.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 64 packages to latest compatible versions [INFO] [stderr] Adding bitflags v0.9.1 (latest: v2.6.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cargo_metadata v0.2.3 (latest: v0.18.1) [INFO] [stderr] Adding clippy v0.0.169 (latest: v0.0.302) [INFO] [stderr] Adding clippy_lints v0.0.169 (latest: v0.0.212) [INFO] [stderr] Adding cloudabi v0.0.3 (latest: v0.1.0) [INFO] [stderr] Adding float-cmp v0.4.0 (latest: v0.9.0) [INFO] [stderr] Adding idna v0.1.5 (latest: v1.0.2) [INFO] [stderr] Adding if_chain v0.1.3 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.6.5 (latest: v0.13.0) [INFO] [stderr] Adding lazy_static v0.2.11 (latest: v1.5.0) [INFO] [stderr] Adding num v0.1.42 (latest: v0.4.3) [INFO] [stderr] Adding num-bigint v0.1.44 (latest: v0.4.6) [INFO] [stderr] Adding num-complex v0.1.43 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.1.42 (latest: v0.4.2) [INFO] [stderr] Adding percent-encoding v1.0.1 (latest: v2.3.1) [INFO] [stderr] Adding pulldown-cmark v0.0.15 (latest: v0.12.0) [INFO] [stderr] Adding rand v0.3.23 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand v0.5.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding regex-syntax v0.4.2 (latest: v0.8.4) [INFO] [stderr] Adding semver v0.6.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding statrs v0.9.0 (latest: v0.17.1) [INFO] [stderr] Adding toml v0.4.10 (latest: v0.8.19) [INFO] [stderr] Adding url v1.7.2 (latest: v2.5.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0f3ed5d4ec2d051a8f66380c4e5e1874cedf99313958d31102134ff8a10b1dea [INFO] running `Command { std: "docker" "start" "-a" "0f3ed5d4ec2d051a8f66380c4e5e1874cedf99313958d31102134ff8a10b1dea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0f3ed5d4ec2d051a8f66380c4e5e1874cedf99313958d31102134ff8a10b1dea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f3ed5d4ec2d051a8f66380c4e5e1874cedf99313958d31102134ff8a10b1dea", kill_on_drop: false }` [INFO] [stdout] 0f3ed5d4ec2d051a8f66380c4e5e1874cedf99313958d31102134ff8a10b1dea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 45815f2faa46cc293fed1bdc200129dbea582a694f3e0cad95d8612acc09aa96 [INFO] running `Command { std: "docker" "start" "-a" "45815f2faa46cc293fed1bdc200129dbea582a694f3e0cad95d8612acc09aa96", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking statrs v0.9.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking xdlol v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `p_value` is never used [INFO] [stdout] --> src/statistics/chi_square.rs:112:8 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn p_value(dof: u64, critical_value: f64) -> f64 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statistics/frequency.rs:163:22 [INFO] [stdout] | [INFO] [stdout] 154 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let mut frequency_map: HashMap = HashMap::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | default: Zero::zero(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statistics/chi_square.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn chi_square>(freqs: I) -> f64 [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / freqs [INFO] [stdout] 101 | | .into_iter() [INFO] [stdout] 102 | | .map(|actual| (actual.to_i64().unwrap() - expected as i64).pow(2) as f64 / expected) [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `K` should have a snake case name [INFO] [stdout] --> src/statistics/chi_square.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | let K: f64 = dof as f64 * 0.5; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `k` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/statistics/chi_square.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | let X: f64 = critical_value * 0.5; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xdlol` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statistics/frequency.rs:163:22 [INFO] [stdout] | [INFO] [stdout] 154 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let mut frequency_map: HashMap = HashMap::new(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | default: Zero::zero(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/statistics/chi_square.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn chi_square>(freqs: I) -> f64 [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / freqs [INFO] [stdout] 101 | | .into_iter() [INFO] [stdout] 102 | | .map(|actual| (actual.to_i64().unwrap() - expected as i64).pow(2) as f64 / expected) [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `K` should have a snake case name [INFO] [stdout] --> src/statistics/chi_square.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | let K: f64 = dof as f64 * 0.5; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `k` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/statistics/chi_square.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | let X: f64 = critical_value * 0.5; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xdlol` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "45815f2faa46cc293fed1bdc200129dbea582a694f3e0cad95d8612acc09aa96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45815f2faa46cc293fed1bdc200129dbea582a694f3e0cad95d8612acc09aa96", kill_on_drop: false }` [INFO] [stdout] 45815f2faa46cc293fed1bdc200129dbea582a694f3e0cad95d8612acc09aa96