[INFO] fetching crate xcolor 0.5.1... [INFO] checking xcolor-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xcolor 0.5.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate xcolor 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xcolor 0.5.1 [INFO] finished tweaking crates.io crate xcolor 0.5.1 [INFO] tweaked toml for crates.io crate xcolor 0.5.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate xcolor 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d3a52459d5d01325ec501590bd4dc869181fba5a923649b519d7565aca64b50b [INFO] running `Command { std: "docker" "start" "-a" "d3a52459d5d01325ec501590bd4dc869181fba5a923649b519d7565aca64b50b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d3a52459d5d01325ec501590bd4dc869181fba5a923649b519d7565aca64b50b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3a52459d5d01325ec501590bd4dc869181fba5a923649b519d7565aca64b50b", kill_on_drop: false }` [INFO] [stdout] d3a52459d5d01325ec501590bd4dc869181fba5a923649b519d7565aca64b50b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 405483d3576b564f74501a5fd6a461e3614f761968b2345cec2408a35fe6497f [INFO] running `Command { std: "docker" "start" "-a" "405483d3576b564f74501a5fd6a461e3614f761968b2345cec2408a35fe6497f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling unicode-width v0.1.8 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling anyhow v1.0.43 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking minimal-lexical v0.1.3 [INFO] [stderr] Compiling x11 v2.18.2 [INFO] [stderr] Compiling nom v7.0.0 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Checking nix v0.22.1 [INFO] [stderr] Compiling clap v2.33.3 [INFO] [stderr] Compiling xcb v0.9.0 [INFO] [stderr] Compiling xcolor v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/location.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | let mut cursor_image = XcursorImageCreate(preview_width as i32, preview_width as i32); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/location.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | let mut cursor_image = XcursorImageCreate(preview_width as i32, preview_width as i32); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:57:53 [INFO] [stdout] | [INFO] [stdout] 57 | .map_or(Some(Selection::Clipboard), |v| v.parse::().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/format.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 87 | let digit = map_res(digit1, |s: &str| s.parse::()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | map(tuple((anychar, digit)), |(char, len)| Pad { char, len })(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/format.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 95 | let escape = map(tag("%%"), |_| FormatPart::Literal("%".to_owned())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let inner = complete(map( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let expansion = preceded(tag("%{"), terminated(inner, tag("}"))); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | alt((escape, expansion))(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:57:53 [INFO] [stdout] | [INFO] [stdout] 57 | .map_or(Some(Selection::Clipboard), |v| v.parse::().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/format.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 87 | let digit = map_res(digit1, |s: &str| s.parse::()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | map(tuple((anychar, digit)), |(char, len)| Pad { char, len })(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/format.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 95 | let escape = map(tag("%%"), |_| FormatPart::Literal("%".to_owned())); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let inner = complete(map( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | let expansion = preceded(tag("%{"), terminated(inner, tag("}"))); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | alt((escape, expansion))(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xcolor` (bin "xcolor") due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xcolor` (bin "xcolor" test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "405483d3576b564f74501a5fd6a461e3614f761968b2345cec2408a35fe6497f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "405483d3576b564f74501a5fd6a461e3614f761968b2345cec2408a35fe6497f", kill_on_drop: false }` [INFO] [stdout] 405483d3576b564f74501a5fd6a461e3614f761968b2345cec2408a35fe6497f