[INFO] fetching crate xbnet 1.1.0... [INFO] checking xbnet-1.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xbnet 1.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate xbnet 1.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xbnet 1.1.0 [INFO] finished tweaking crates.io crate xbnet 1.1.0 [INFO] tweaked toml for crates.io crate xbnet 1.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate xbnet 1.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5114247ee07fa36d8d5f9f0fa6b0fec05e01c7eaae497adc2008770b33e13106 [INFO] running `Command { std: "docker" "start" "-a" "5114247ee07fa36d8d5f9f0fa6b0fec05e01c7eaae497adc2008770b33e13106", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5114247ee07fa36d8d5f9f0fa6b0fec05e01c7eaae497adc2008770b33e13106", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5114247ee07fa36d8d5f9f0fa6b0fec05e01c7eaae497adc2008770b33e13106", kill_on_drop: false }` [INFO] [stdout] 5114247ee07fa36d8d5f9f0fa6b0fec05e01c7eaae497adc2008770b33e13106 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 86962f7e0d183ca59484d138641a0dc848d6b7daaa397dfeee6d539529fa8540 [INFO] running `Command { std: "docker" "start" "-a" "86962f7e0d183ca59484d138641a0dc848d6b7daaa397dfeee6d539529fa8540", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.77 [INFO] [stderr] Compiling proc-macro2 v1.0.22 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling syn v1.0.41 [INFO] [stderr] Compiling pkg-config v0.3.18 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Compiling cc v1.0.60 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking libudev v0.2.0 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking etherparse v0.9.0 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Checking format_escape_default v0.1.1 [INFO] [stderr] Checking hex v0.4.2 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Compiling tun-tap v0.1.2 [INFO] [stderr] Checking chrono v0.4.16 [INFO] [stderr] Checking simplelog v0.7.6 [INFO] [stderr] Checking serialport v3.3.0 [INFO] [stderr] Compiling structopt-derive v0.4.11 [INFO] [stderr] Checking structopt v0.3.18 [INFO] [stderr] Checking xbnet v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `log::*` [INFO] [stdout] --> src/xbpacket.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use log::*; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `log::*` [INFO] [stdout] --> src/xbpacket.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | use log::*; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/xbpacket.rs:201:23 [INFO] [stdout] | [INFO] [stdout] 201 | .map_err(|e| String::from("More than 255 chunks to transmit"))?; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/xbpacket.rs:201:23 [INFO] [stdout] | [INFO] [stdout] 201 | .map_err(|e| String::from("More than 255 chunks to transmit"))?; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `myxbmac` and `name` are never read [INFO] [stdout] --> src/tap.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct XBTap { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 41 | pub myxbmac: u64, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 42 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `XBTap` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `showmac` is never used [INFO] [stdout] --> src/tap.rs:177:8 [INFO] [stdout] | [INFO] [stdout] 177 | pub fn showmac(mac: &[u8; 6]) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `myxbmac` and `name` are never read [INFO] [stdout] --> src/tun.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct XBTun { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 41 | pub myxbmac: u64, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 42 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `XBTun` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mkerror` is never used [INFO] [stdout] --> src/xb.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn mkerror(msg: &str) -> Error { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `assert_response` is never used [INFO] [stdout] --> src/xb.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn assert_response(resp: String, expected: String) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `U16` is never constructed [INFO] [stdout] --> src/xbpacket.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub enum XBDestAddr { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 29 | /// A 16-bit destination address. When a 64-bit address is given, this is transmitted as 0xFFFE. [INFO] [stdout] 30 | U16(u16), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `XBDestAddr` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mac64to48` is never used [INFO] [stdout] --> src/xbpacket.rs:144:8 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn mac64to48(mac64: u64) -> [u8; 6] { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mac48to64` is never used [INFO] [stdout] --> src/xbpacket.rs:152:8 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn mac48to64(mac48: &[u8; 6], pattern64: u64) -> u64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `discardframes` is never used [INFO] [stdout] --> src/xbrx.rs:157:12 [INFO] [stdout] | [INFO] [stdout] 131 | impl XBReframer { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 157 | pub fn discardframes(&mut self, ser: &mut XBSerReader) -> () { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 143 | let (mut xb, xbeesender, writerthread) = xb::XB::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | ping::genpings(dest_u64, xbeesender).expect("Failure in genpings") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:171:17 [INFO] [stdout] | [INFO] [stdout] 143 | let (mut xb, xbeesender, writerthread) = xb::XB::new( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let mut xbreframer = xbrx::XBReframer::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | pipe::stdout_processor(&mut xbreframer, &mut xb.ser_reader) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 47 | let readport = serialport::open_with_settings(&portname, &settings)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let writeport = readport.try_clone()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | [INFO] [stdout] 50 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 51 | | XBSerReader { [INFO] [stdout] 52 | | br: BufReader::new(readport), [INFO] [stdout] 53 | | portname: portname.clone(), [INFO] [stdout] ... | [INFO] [stdout] 58 | | }, [INFO] [stdout] 59 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tap.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 61 | let tap = Iface::without_packet_info(&iface_name_requested, Mode::Tap)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(XBTap { [INFO] [stdout] | ____________^ [INFO] [stdout] 70 | | myxbmac, [INFO] [stdout] 71 | | broadcast_unknown, [INFO] [stdout] 72 | | broadcast_everything, [INFO] [stdout] ... | [INFO] [stdout] 75 | | dests: Arc::new(Mutex::new(desthm)), [INFO] [stdout] 76 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tun.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 63 | let tun = Iface::without_packet_info(&iface_name_requested, Mode::Tun)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(XBTun { [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | myxbmac, [INFO] [stdout] 72 | | broadcast_everything, [INFO] [stdout] 73 | | max_ip_cache, [INFO] [stdout] ... | [INFO] [stdout] 78 | | dests: Arc::new(Mutex::new(desthm)), [INFO] [stdout] 79 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xb.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 81 | mut ser_reader: XBSerReader, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | mut ser_writer: XBSerWriter, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let (writertx, writerrx) = crossbeam_channel::bounded(5); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let writerthread = thread::spawn(move || { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | / XB { [INFO] [stdout] 163 | | ser_reader, [INFO] [stdout] 164 | | mymac, [INFO] [stdout] 165 | | maxpacketsize, [INFO] [stdout] 166 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xbnet` (bin "xbnet") due to 7 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `myxbmac` and `name` are never read [INFO] [stdout] --> src/tap.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct XBTap { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 41 | pub myxbmac: u64, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 42 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `XBTap` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `showmac` is never used [INFO] [stdout] --> src/tap.rs:177:8 [INFO] [stdout] | [INFO] [stdout] 177 | pub fn showmac(mac: &[u8; 6]) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `myxbmac` and `name` are never read [INFO] [stdout] --> src/tun.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct XBTun { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 41 | pub myxbmac: u64, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 42 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `XBTun` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mkerror` is never used [INFO] [stdout] --> src/xb.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn mkerror(msg: &str) -> Error { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `assert_response` is never used [INFO] [stdout] --> src/xb.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn assert_response(resp: String, expected: String) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `U16` is never constructed [INFO] [stdout] --> src/xbpacket.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub enum XBDestAddr { [INFO] [stdout] | ---------- variant in this enum [INFO] [stdout] 29 | /// A 16-bit destination address. When a 64-bit address is given, this is transmitted as 0xFFFE. [INFO] [stdout] 30 | U16(u16), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `XBDestAddr` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mac64to48` is never used [INFO] [stdout] --> src/xbpacket.rs:144:8 [INFO] [stdout] | [INFO] [stdout] 144 | pub fn mac64to48(mac64: u64) -> [u8; 6] { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `mac48to64` is never used [INFO] [stdout] --> src/xbpacket.rs:152:8 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn mac48to64(mac48: &[u8; 6], pattern64: u64) -> u64 { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `discardframes` is never used [INFO] [stdout] --> src/xbrx.rs:157:12 [INFO] [stdout] | [INFO] [stdout] 131 | impl XBReframer { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 157 | pub fn discardframes(&mut self, ser: &mut XBSerReader) -> () { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 143 | let (mut xb, xbeesender, writerthread) = xb::XB::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | ping::genpings(dest_u64, xbeesender).expect("Failure in genpings") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:171:17 [INFO] [stdout] | [INFO] [stdout] 143 | let (mut xb, xbeesender, writerthread) = xb::XB::new( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | let mut xbreframer = xbrx::XBReframer::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | pipe::stdout_processor(&mut xbreframer, &mut xb.ser_reader) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 47 | let readport = serialport::open_with_settings(&portname, &settings)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let writeport = readport.try_clone()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | [INFO] [stdout] 50 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 51 | | XBSerReader { [INFO] [stdout] 52 | | br: BufReader::new(readport), [INFO] [stdout] 53 | | portname: portname.clone(), [INFO] [stdout] ... | [INFO] [stdout] 58 | | }, [INFO] [stdout] 59 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tap.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 61 | let tap = Iface::without_packet_info(&iface_name_requested, Mode::Tap)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(XBTap { [INFO] [stdout] | ____________^ [INFO] [stdout] 70 | | myxbmac, [INFO] [stdout] 71 | | broadcast_unknown, [INFO] [stdout] 72 | | broadcast_everything, [INFO] [stdout] ... | [INFO] [stdout] 75 | | dests: Arc::new(Mutex::new(desthm)), [INFO] [stdout] 76 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tun.rs:70:12 [INFO] [stdout] | [INFO] [stdout] 63 | let tun = Iface::without_packet_info(&iface_name_requested, Mode::Tun)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | Ok(XBTun { [INFO] [stdout] | ____________^ [INFO] [stdout] 71 | | myxbmac, [INFO] [stdout] 72 | | broadcast_everything, [INFO] [stdout] 73 | | max_ip_cache, [INFO] [stdout] ... | [INFO] [stdout] 78 | | dests: Arc::new(Mutex::new(desthm)), [INFO] [stdout] 79 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xb.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 81 | mut ser_reader: XBSerReader, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | mut ser_writer: XBSerWriter, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let (writertx, writerrx) = crossbeam_channel::bounded(5); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let writerthread = thread::spawn(move || { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | / XB { [INFO] [stdout] 163 | | ser_reader, [INFO] [stdout] 164 | | mymac, [INFO] [stdout] 165 | | maxpacketsize, [INFO] [stdout] 166 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xbnet` (bin "xbnet" test) due to 7 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "86962f7e0d183ca59484d138641a0dc848d6b7daaa397dfeee6d539529fa8540", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86962f7e0d183ca59484d138641a0dc848d6b7daaa397dfeee6d539529fa8540", kill_on_drop: false }` [INFO] [stdout] 86962f7e0d183ca59484d138641a0dc848d6b7daaa397dfeee6d539529fa8540