[INFO] fetching crate xbf_rs 0.1.0... [INFO] checking xbf_rs-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xbf_rs 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate xbf_rs 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xbf_rs 0.1.0 [INFO] finished tweaking crates.io crate xbf_rs 0.1.0 [INFO] tweaked toml for crates.io crate xbf_rs 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate xbf_rs 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c5b9056962b1c599bceb4b4585e4d3c41bd3177f86945334358a448f19f2da60 [INFO] running `Command { std: "docker" "start" "-a" "c5b9056962b1c599bceb4b4585e4d3c41bd3177f86945334358a448f19f2da60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c5b9056962b1c599bceb4b4585e4d3c41bd3177f86945334358a448f19f2da60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5b9056962b1c599bceb4b4585e4d3c41bd3177f86945334358a448f19f2da60", kill_on_drop: false }` [INFO] [stdout] c5b9056962b1c599bceb4b4585e4d3c41bd3177f86945334358a448f19f2da60 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 34106e6cd5bb9a5b62b2f7d4b5995eb1758d6c792a79330dcc9a6b1b77a1ab37 [INFO] running `Command { std: "docker" "start" "-a" "34106e6cd5bb9a5b62b2f7d4b5995eb1758d6c792a79330dcc9a6b1b77a1ab37", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling serde v1.0.183 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Compiling tokio v1.29.1 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling openssl v0.10.55 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Checking lock_api v0.4.10 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking encoding_rs v0.8.32 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking xbf_rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling cc v1.0.81 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xbf_struct.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 91 | metadata: XbfStructMetadata, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | fields: impl IntoIterator, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | ) -> Result { [INFO] [stdout] 94 | let fields: Box<[XbfType]> = fields.into_iter().collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Ok(Self { metadata, fields }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xbf_struct.rs:257:12 [INFO] [stdout] | [INFO] [stdout] 253 | let mut struct_fields = vec![]; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | Ok(Self::new_unchecked(metadata.clone(), struct_fields)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xbf_struct.rs:359:23 [INFO] [stdout] | [INFO] [stdout] 354 | pub fn set(&mut self, field_name: &str, field_data: impl Into) -> Option { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | .and_then(|i| { [INFO] [stdout] | _______________________^ [INFO] [stdout] 360 | | let current = &mut self.fields[i]; [INFO] [stdout] 361 | | let field_data = field_data.into(); [INFO] [stdout] 362 | | if XbfMetadata::from(&*current) != XbfMetadata::from(&field_data) { [INFO] [stdout] ... | [INFO] [stdout] 366 | | } [INFO] [stdout] 367 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xbf_struct/struct_metadata.rs:62:20 [INFO] [stdout] | [INFO] [stdout] 58 | name: impl Into>, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | fields: IndexMap>, XbfMetadata>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | inner: RcType::new(XbfStructMetadataInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 63 | | name: name.into(), [INFO] [stdout] 64 | | fields: fields.into_iter().map(|(k, v)| (k.into(), v)).collect(), [INFO] [stdout] 65 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xbf_struct/struct_metadata.rs:64:58 [INFO] [stdout] | [INFO] [stdout] 64 | fields: fields.into_iter().map(|(k, v)| (k.into(), v)).collect(), [INFO] [stdout] | ------ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xbf_struct/struct_metadata.rs:230:12 [INFO] [stdout] | [INFO] [stdout] 223 | let mut fields = IndexMap::with_capacity(len as usize); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | Ok(XbfStructMetadata::new(name, fields)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xbf_vec.rs:64:46 [INFO] [stdout] | [INFO] [stdout] 64 | .all(|x| *metadata.inner_type == XbfMetadata::from(x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xbf_vec.rs:171:12 [INFO] [stdout] | [INFO] [stdout] 167 | let mut elements = Vec::with_capacity(len); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | Ok(XbfVec::new_unchecked(metadata.clone(), elements)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xbf_vec/vec_metadata.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(inner_type: impl Into) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Self { [INFO] [stdout] 37 | inner_type: RcType::new(inner_type.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/xbf_vec/vec_metadata.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 83 | let inner_type = XbfMetadata::deserialize_base_metadata(reader)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Ok(XbfVecMetadata::new(inner_type)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xbf_rs` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "34106e6cd5bb9a5b62b2f7d4b5995eb1758d6c792a79330dcc9a6b1b77a1ab37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34106e6cd5bb9a5b62b2f7d4b5995eb1758d6c792a79330dcc9a6b1b77a1ab37", kill_on_drop: false }` [INFO] [stdout] 34106e6cd5bb9a5b62b2f7d4b5995eb1758d6c792a79330dcc9a6b1b77a1ab37