[INFO] fetching crate xat 0.3.4... [INFO] checking xat-0.3.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xat 0.3.4 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate xat 0.3.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xat 0.3.4 [INFO] finished tweaking crates.io crate xat 0.3.4 [INFO] tweaked toml for crates.io crate xat 0.3.4 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate xat 0.3.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf3667a9418099a46eb7588651ef72fcca5bd3cf2df1fab3d5be1ee9594f18a7 [INFO] running `Command { std: "docker" "start" "-a" "bf3667a9418099a46eb7588651ef72fcca5bd3cf2df1fab3d5be1ee9594f18a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf3667a9418099a46eb7588651ef72fcca5bd3cf2df1fab3d5be1ee9594f18a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf3667a9418099a46eb7588651ef72fcca5bd3cf2df1fab3d5be1ee9594f18a7", kill_on_drop: false }` [INFO] [stdout] bf3667a9418099a46eb7588651ef72fcca5bd3cf2df1fab3d5be1ee9594f18a7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 843fb440aa2c9bafb897e26cd06c377c803b823b096923023a5b998b2eaac76d [INFO] running `Command { std: "docker" "start" "-a" "843fb440aa2c9bafb897e26cd06c377c803b823b096923023a5b998b2eaac76d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking simple-logging v2.0.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Compiling serde_derive v1.0.198 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking thiserror v1.0.58 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking xat v0.3.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `now2unix_ts` is never used [INFO] [stdout] --> src/dt.rs:16:15 [INFO] [stdout] | [INFO] [stdout] 16 | pub(crate) fn now2unix_ts() -> Value { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dt2unix_ts` is never used [INFO] [stdout] --> src/dt.rs:21:15 [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) fn dt2unix_ts(dt: DateTime) -> Value { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dt_from_value` is never used [INFO] [stdout] --> src/dt.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 25 | pub(crate) fn dt_from_value(value: Value) -> Result, Errors> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:18 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn new_none>(key: S) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | val: Value::Null, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmds.rs:53:34 [INFO] [stdout] | [INFO] [stdout] 53 | .map(|x| serde_json::to_string(x).expect("error in ndjson format")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `now2unix_ts` is never used [INFO] [stdout] --> src/dt.rs:16:15 [INFO] [stdout] | [INFO] [stdout] 16 | pub(crate) fn now2unix_ts() -> Value { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmds.rs:129:36 [INFO] [stdout] | [INFO] [stdout] 79 | let mut returns: Vec = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | .write_to(&mut stdout, Value::Array(returns)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dt2unix_ts` is never used [INFO] [stdout] --> src/dt.rs:21:15 [INFO] [stdout] | [INFO] [stdout] 21 | pub(crate) fn dt2unix_ts(dt: DateTime) -> Value { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dt_from_value` is never used [INFO] [stdout] --> src/dt.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 25 | pub(crate) fn dt_from_value(value: Value) -> Result, Errors> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:149:18 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn new_none>(key: S) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | val: Value::Null, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmds.rs:53:34 [INFO] [stdout] | [INFO] [stdout] 53 | .map(|x| serde_json::to_string(x).expect("error in ndjson format")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmds.rs:129:36 [INFO] [stdout] | [INFO] [stdout] 79 | let mut returns: Vec = vec![]; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | .write_to(&mut stdout, Value::Array(returns)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xat` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `xat` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "843fb440aa2c9bafb897e26cd06c377c803b823b096923023a5b998b2eaac76d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "843fb440aa2c9bafb897e26cd06c377c803b823b096923023a5b998b2eaac76d", kill_on_drop: false }` [INFO] [stdout] 843fb440aa2c9bafb897e26cd06c377c803b823b096923023a5b998b2eaac76d