[INFO] fetching crate xash3d-master 0.2.0... [INFO] checking xash3d-master-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xash3d-master 0.2.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate xash3d-master 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xash3d-master 0.2.0 [INFO] finished tweaking crates.io crate xash3d-master 0.2.0 [INFO] tweaked toml for crates.io crate xash3d-master 0.2.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate xash3d-master 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] afd43d53b78e945e0808a48999c26795990d5d1e270f40c6ab3ec95d10732ce4 [INFO] running `Command { std: "docker" "start" "-a" "afd43d53b78e945e0808a48999c26795990d5d1e270f40c6ab3ec95d10732ce4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "afd43d53b78e945e0808a48999c26795990d5d1e270f40c6ab3ec95d10732ce4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "afd43d53b78e945e0808a48999c26795990d5d1e270f40c6ab3ec95d10732ce4", kill_on_drop: false }` [INFO] [stdout] afd43d53b78e945e0808a48999c26795990d5d1e270f40c6ab3ec95d10732ce4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 311c6e51a5aafaf91269401e3d05e23d460ead56e87077152da354bbb9c51839 [INFO] running `Command { std: "docker" "start" "-a" "311c6e51a5aafaf91269401e3d05e23d460ead56e87077152da354bbb9c51839", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling once_cell v1.17.2 [INFO] [stderr] Compiling log v0.4.18 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling syn v2.0.56 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking blake2b_simd v1.0.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking chrono v0.4.26 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking ahash v0.4.8 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking xash3d-protocol v0.2.0 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking xash3d-master v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `Counters` is never constructed [INFO] [stdout] --> src/stats/stub.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct Counters; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Counters` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:270:8 [INFO] [stdout] | [INFO] [stdout] 268 | pub fn load>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | let data = fs::read(path)?; [INFO] [stdout] 270 | Ok(toml::de::from_slice(&data)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/master_server.rs:275:12 [INFO] [stdout] | [INFO] [stdout] 266 | pub fn new(cfg: Config, addr: Addr) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | let sock = UdpSocket::bind(addr).map_err(Error::BindSocket)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 276 | | sock, [INFO] [stdout] 277 | | start_time: Instant::now(), [INFO] [stdout] 278 | | challenges: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 299 | | filtered_servers_nat: Default::default(), [INFO] [stdout] 300 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/master_server.rs:330:12 [INFO] [stdout] | [INFO] [stdout] 307 | pub fn update_config(&mut self, cfg: Config) -> Result, Error> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | Ok(None) [INFO] [stdout] | ^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/master_server.rs:696:48 [INFO] [stdout] | [INFO] [stdout] 696 | let iter = args.iter().map(|i| (i, i.parse::())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Counters` is never constructed [INFO] [stdout] --> src/stats/stub.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct Counters; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Counters` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:270:8 [INFO] [stdout] | [INFO] [stdout] 268 | pub fn load>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 269 | let data = fs::read(path)?; [INFO] [stdout] 270 | Ok(toml::de::from_slice(&data)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/master_server.rs:275:12 [INFO] [stdout] | [INFO] [stdout] 266 | pub fn new(cfg: Config, addr: Addr) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | let sock = UdpSocket::bind(addr).map_err(Error::BindSocket)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 276 | | sock, [INFO] [stdout] 277 | | start_time: Instant::now(), [INFO] [stdout] 278 | | challenges: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 299 | | filtered_servers_nat: Default::default(), [INFO] [stdout] 300 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/master_server.rs:330:12 [INFO] [stdout] | [INFO] [stdout] 307 | pub fn update_config(&mut self, cfg: Config) -> Result, Error> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 330 | Ok(None) [INFO] [stdout] | ^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/master_server.rs:696:48 [INFO] [stdout] | [INFO] [stdout] 696 | let iter = args.iter().map(|i| (i, i.parse::())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xash3d-master` (bin "xash3d-master" test) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xash3d-master` (bin "xash3d-master") due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "311c6e51a5aafaf91269401e3d05e23d460ead56e87077152da354bbb9c51839", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "311c6e51a5aafaf91269401e3d05e23d460ead56e87077152da354bbb9c51839", kill_on_drop: false }` [INFO] [stdout] 311c6e51a5aafaf91269401e3d05e23d460ead56e87077152da354bbb9c51839