[INFO] fetching crate xand-utils 1.0.0... [INFO] checking xand-utils-1.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xand-utils 1.0.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate xand-utils 1.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xand-utils 1.0.0 [INFO] finished tweaking crates.io crate xand-utils 1.0.0 [INFO] tweaked toml for crates.io crate xand-utils 1.0.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 32 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding derive_more v0.15.0 (latest: v1.0.0) [INFO] [stderr] Adding nix v0.14.1 (latest: v0.29.0) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding snafu v0.6.10 (latest: v0.8.4) [INFO] [stderr] Adding snafu-derive v0.6.10 (latest: v0.8.4) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 45b95df0e19238a9d1398a0e6e13d795346d610db1cf76ccaacefcd1707ba4b8 [INFO] running `Command { std: "docker" "start" "-a" "45b95df0e19238a9d1398a0e6e13d795346d610db1cf76ccaacefcd1707ba4b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "45b95df0e19238a9d1398a0e6e13d795346d610db1cf76ccaacefcd1707ba4b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45b95df0e19238a9d1398a0e6e13d795346d610db1cf76ccaacefcd1707ba4b8", kill_on_drop: false }` [INFO] [stdout] 45b95df0e19238a9d1398a0e6e13d795346d610db1cf76ccaacefcd1707ba4b8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7f117004f38d44fa4a3c24099de52b46ee614793303b633d2b7922df8b4cbe5f [INFO] running `Command { std: "docker" "start" "-a" "7f117004f38d44fa4a3c24099de52b46ee614793303b633d2b7922df8b4cbe5f", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling snafu-derive v0.6.10 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking snafu v0.6.10 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling derive_more v0.15.0 [INFO] [stderr] Checking xand-utils v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procutils.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(command: Command) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | child: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procutils.rs:51:20 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn with_kill_mode(command: Command, kill_mode: ChildKillMode) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | child: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadutils.rs:11:24 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn spawn_immortal(f: F) -> JoinHandle [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | std::thread::spawn(move || loop { [INFO] [stdout] | ________________________^ [INFO] [stdout] 12 | | let handle = std::thread::spawn(f.clone()); [INFO] [stdout] 13 | | match handle.join() { [INFO] [stdout] 14 | | Err(_) => (), [INFO] [stdout] ... | [INFO] [stdout] 19 | | std::thread::sleep(Duration::from_secs(1)); [INFO] [stdout] 20 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/timeout.rs:37:24 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn send_to_channel_after_timeout(d: Duration, sender: Sender) -> JoinHandle<()> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let start = Instant::now(); [INFO] [stdout] 37 | std::thread::spawn(move || loop { [INFO] [stdout] | ________________________^ [INFO] [stdout] 38 | | if start + d < Instant::now() { [INFO] [stdout] 39 | | let _ = sender.send(true); [INFO] [stdout] 40 | | break; [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | std::thread::sleep(Duration::from_millis(10)); [INFO] [stdout] 43 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xand-utils` (lib) due to 5 previous errors [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procutils.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new(command: Command) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | child: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procutils.rs:51:20 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn with_kill_mode(command: Command, kill_mode: ChildKillMode) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | child: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/procutils.rs:163:15 [INFO] [stdout] | [INFO] [stdout] 141 | let cmd = { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let mut cmd = Command::new("sleep"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | let mut dropme = KillChildOnDrop::new(cmd); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | match process.try_wait() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadutils.rs:11:24 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn spawn_immortal(f: F) -> JoinHandle [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | std::thread::spawn(move || loop { [INFO] [stdout] | ________________________^ [INFO] [stdout] 12 | | let handle = std::thread::spawn(f.clone()); [INFO] [stdout] 13 | | match handle.join() { [INFO] [stdout] 14 | | Err(_) => (), [INFO] [stdout] ... | [INFO] [stdout] 19 | | std::thread::sleep(Duration::from_secs(1)); [INFO] [stdout] 20 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/timeout.rs:37:24 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn send_to_channel_after_timeout(d: Duration, sender: Sender) -> JoinHandle<()> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let start = Instant::now(); [INFO] [stdout] 37 | std::thread::spawn(move || loop { [INFO] [stdout] | ________________________^ [INFO] [stdout] 38 | | if start + d < Instant::now() { [INFO] [stdout] 39 | | let _ = sender.send(true); [INFO] [stdout] 40 | | break; [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | std::thread::sleep(Duration::from_millis(10)); [INFO] [stdout] 43 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xand-utils` (lib test) due to 6 previous errors [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "7f117004f38d44fa4a3c24099de52b46ee614793303b633d2b7922df8b4cbe5f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7f117004f38d44fa4a3c24099de52b46ee614793303b633d2b7922df8b4cbe5f", kill_on_drop: false }` [INFO] [stdout] 7f117004f38d44fa4a3c24099de52b46ee614793303b633d2b7922df8b4cbe5f