[INFO] fetching crate xan-actor 1.2.10... [INFO] checking xan-actor-1.2.10 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate xan-actor 1.2.10 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate xan-actor 1.2.10 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate xan-actor 1.2.10 [INFO] finished tweaking crates.io crate xan-actor 1.2.10 [INFO] tweaked toml for crates.io crate xan-actor 1.2.10 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 48 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cfc2232e199daf5aabd3e3b0610f1257860720f4fc1105d09eaeb5e66557a0cd [INFO] running `Command { std: "docker" "start" "-a" "cfc2232e199daf5aabd3e3b0610f1257860720f4fc1105d09eaeb5e66557a0cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cfc2232e199daf5aabd3e3b0610f1257860720f4fc1105d09eaeb5e66557a0cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cfc2232e199daf5aabd3e3b0610f1257860720f4fc1105d09eaeb5e66557a0cd", kill_on_drop: false }` [INFO] [stdout] cfc2232e199daf5aabd3e3b0610f1257860720f4fc1105d09eaeb5e66557a0cd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9f0b13a45274eb4c16001ab8b949eb0ad0c8e6f32d5999d9175d354dd661bf46 [INFO] running `Command { std: "docker" "start" "-a" "9f0b13a45274eb4c16001ab8b949eb0ad0c8e6f32d5999d9175d354dd661bf46", kill_on_drop: false }` [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking xan-actor v1.2.10 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio_actor.rs:58:39 [INFO] [stdout] | [INFO] [stdout] 55 | actor_system_tx: tokio::sync::mpsc::UnboundedSender>, [INFO] [stdout] | ------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | kill_in_error: bool, [INFO] [stdout] 57 | ready_tx: tokio::sync::mpsc::UnboundedSender<()>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | ) -> Result<(), ActorError> { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 59 | | let mut restarted = false; [INFO] [stdout] 60 | | loop { [INFO] [stdout] 61 | | if restarted { [INFO] [stdout] ... | [INFO] [stdout] 138 | | } [INFO] [stdout] 139 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio_actor.rs:140:92 [INFO] [stdout] | [INFO] [stdout] 140 | async fn register(mut self, actor_system: &mut ActorSystem, kill_in_error: bool) { [INFO] [stdout] | ___________________________----_____________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | | let (tx, mut rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] 142 | | let actor_system_tx = actor_system.handler_tx(); [INFO] [stdout] 143 | | let _ = [INFO] [stdout] 144 | | tokio::spawn(async move { self.run_actor(actor_system_tx, kill_in_error, tx).await }); [INFO] [stdout] 145 | | let _ = rx.recv().await; [INFO] [stdout] 146 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio_actor.rs:144:90 [INFO] [stdout] | [INFO] [stdout] 140 | async fn register(mut self, actor_system: &mut ActorSystem, kill_in_error: bool) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let (tx, mut rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let actor_system_tx = actor_system.handler_tx(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | let _ = [INFO] [stdout] 144 | tokio::spawn(async move { self.run_actor(actor_system_tx, kill_in_error, tx).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio_actor.rs:174:22 [INFO] [stdout] | [INFO] [stdout] 172 | mut handler_rx: tokio::sync::mpsc::UnboundedReceiver>, [INFO] [stdout] | -------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | ) -> tokio::task::JoinHandle<()> { [INFO] [stdout] 174 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 175 | | let mut map = HashMap::< [INFO] [stdout] 176 | | String, [INFO] [stdout] 177 | | ( [INFO] [stdout] ... | [INFO] [stdout] 236 | | } [INFO] [stdout] 237 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/test.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | let result = actor_system [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/test.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | let result = actor_system [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `result` [INFO] [stdout] --> src/test.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | let result = actor_system_move [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_result` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xan-actor` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variant `Exit` is never constructed [INFO] [stdout] --> src/test.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 4 | pub enum MyMessage { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 7 | Exit, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MyMessage` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio_actor.rs:58:39 [INFO] [stdout] | [INFO] [stdout] 55 | actor_system_tx: tokio::sync::mpsc::UnboundedSender>, [INFO] [stdout] | ------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | kill_in_error: bool, [INFO] [stdout] 57 | ready_tx: tokio::sync::mpsc::UnboundedSender<()>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | ) -> Result<(), ActorError> { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 59 | | let mut restarted = false; [INFO] [stdout] 60 | | loop { [INFO] [stdout] 61 | | if restarted { [INFO] [stdout] ... | [INFO] [stdout] 138 | | } [INFO] [stdout] 139 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio_actor.rs:140:92 [INFO] [stdout] | [INFO] [stdout] 140 | async fn register(mut self, actor_system: &mut ActorSystem, kill_in_error: bool) { [INFO] [stdout] | ___________________________----_____________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | | let (tx, mut rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] 142 | | let actor_system_tx = actor_system.handler_tx(); [INFO] [stdout] 143 | | let _ = [INFO] [stdout] 144 | | tokio::spawn(async move { self.run_actor(actor_system_tx, kill_in_error, tx).await }); [INFO] [stdout] 145 | | let _ = rx.recv().await; [INFO] [stdout] 146 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio_actor.rs:144:90 [INFO] [stdout] | [INFO] [stdout] 140 | async fn register(mut self, actor_system: &mut ActorSystem, kill_in_error: bool) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | let (tx, mut rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | let actor_system_tx = actor_system.handler_tx(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | let _ = [INFO] [stdout] 144 | tokio::spawn(async move { self.run_actor(actor_system_tx, kill_in_error, tx).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tokio_actor.rs:174:22 [INFO] [stdout] | [INFO] [stdout] 172 | mut handler_rx: tokio::sync::mpsc::UnboundedReceiver>, [INFO] [stdout] | -------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | ) -> tokio::task::JoinHandle<()> { [INFO] [stdout] 174 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 175 | | let mut map = HashMap::< [INFO] [stdout] 176 | | String, [INFO] [stdout] 177 | | ( [INFO] [stdout] ... | [INFO] [stdout] 236 | | } [INFO] [stdout] 237 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `xan-actor` (lib test) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9f0b13a45274eb4c16001ab8b949eb0ad0c8e6f32d5999d9175d354dd661bf46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f0b13a45274eb4c16001ab8b949eb0ad0c8e6f32d5999d9175d354dd661bf46", kill_on_drop: false }` [INFO] [stdout] 9f0b13a45274eb4c16001ab8b949eb0ad0c8e6f32d5999d9175d354dd661bf46