[INFO] fetching crate x-lint 0.1.0... [INFO] checking x-lint-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate x-lint 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate x-lint 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate x-lint 0.1.0 [INFO] finished tweaking crates.io crate x-lint 0.1.0 [INFO] tweaked toml for crates.io crate x-lint 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 82 packages to latest compatible versions [INFO] [stderr] Adding atomicwrites v0.2.5 (latest: v0.4.3) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cargo_metadata v0.12.3 (latest: v0.18.1) [INFO] [stderr] Adding cfg-expr v0.7.4 (latest: v0.16.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding determinator v0.3.0 (latest: v0.12.0) [INFO] [stderr] Adding diffus v0.9.1 (latest: v0.10.0) [INFO] [stderr] Adding diffy v0.2.2 (latest: v0.4.0) [INFO] [stderr] Adding fixedbitset v0.2.0 (latest: v0.5.7) [INFO] [stderr] Adding guppy v0.8.0 (latest: v0.17.7) [INFO] [stderr] Adding guppy-summaries v0.4.0 (latest: v0.7.1) [INFO] [stderr] Adding hakari v0.2.0 (latest: v0.17.3) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding indoc v1.0.9 (latest: v2.0.5) [INFO] [stderr] Adding itertools v0.8.2 (latest: v0.13.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding nix v0.14.1 (latest: v0.29.0) [INFO] [stderr] Adding petgraph v0.5.1 (latest: v0.6.5) [INFO] [stderr] Adding rand v0.4.6 (latest: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (latest: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (latest: v0.8.3) [INFO] [stderr] Adding remove_dir_all v0.5.3 (latest: v0.8.3) [INFO] [stderr] Adding semver v0.11.0 (latest: v1.0.23) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding target-spec v0.7.0 (latest: v3.2.1) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8f70d0c895d440029a2f2317f4077271f1bb50d17232d88655e6f0eb9b239069 [INFO] running `Command { std: "docker" "start" "-a" "8f70d0c895d440029a2f2317f4077271f1bb50d17232d88655e6f0eb9b239069", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8f70d0c895d440029a2f2317f4077271f1bb50d17232d88655e6f0eb9b239069", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f70d0c895d440029a2f2317f4077271f1bb50d17232d88655e6f0eb9b239069", kill_on_drop: false }` [INFO] [stdout] 8f70d0c895d440029a2f2317f4077271f1bb50d17232d88655e6f0eb9b239069 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6ebbc11d64c8001d11e4ff13fb37fe952244f22075ac2f7558574a96de151472 [INFO] running `Command { std: "docker" "start" "-a" "6ebbc11d64c8001d11e4ff13fb37fe952244f22075ac2f7558574a96de151472", kill_on_drop: false }` [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking ucd-trie v0.1.6 [INFO] [stderr] Compiling target-spec v0.7.0 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking cfg-expr v0.7.4 [INFO] [stderr] Checking fixedbitset v0.2.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking nested v0.1.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking camino v1.1.9 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking supercow v0.1.0 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking pest v2.7.11 [INFO] [stderr] Checking petgraph v0.5.1 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking diffy v0.2.2 [INFO] [stderr] Compiling indoc v1.0.9 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking diffus v0.9.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking semver-parser v0.10.2 [INFO] [stderr] Checking semver v0.11.0 [INFO] [stderr] Checking atomicwrites v0.2.5 [INFO] [stderr] Checking cargo_metadata v0.12.3 [INFO] [stderr] Checking guppy-summaries v0.4.0 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Checking guppy v0.8.0 [INFO] [stderr] Checking determinator v0.3.0 [INFO] [stderr] Checking hakari v0.2.0 [INFO] [stderr] Compiling rental-impl v0.5.5 [INFO] [stderr] Checking rental v0.5.6 [INFO] [stderr] Checking x-core v0.1.0 [INFO] [stderr] Checking x-lint v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_path.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 58 | Ok(contents_opt.map(|content| ContentContext::new(self, content))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:188:48 [INFO] [stdout] | [INFO] [stdout] 188 | .filter_map(|linter| match linter.pre_run(&file_ctx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_path.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 58 | Ok(contents_opt.map(|content| ContentContext::new(self, content))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 244 | Ok(tracked_files [INFO] [stdout] | ____________^ [INFO] [stdout] 245 | | .iter() [INFO] [stdout] 246 | | .filter(|f| !f.starts_with("testsuite/diem-fuzzer/artifacts/"))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:188:48 [INFO] [stdout] | [INFO] [stdout] 188 | .filter_map(|linter| match linter.pre_run(&file_ctx) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runner.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 244 | Ok(tracked_files [INFO] [stdout] | ____________^ [INFO] [stdout] 245 | | .iter() [INFO] [stdout] 246 | | .filter(|f| !f.starts_with("testsuite/diem-fuzzer/artifacts/"))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `x-lint` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `x-lint` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "6ebbc11d64c8001d11e4ff13fb37fe952244f22075ac2f7558574a96de151472", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ebbc11d64c8001d11e4ff13fb37fe952244f22075ac2f7558574a96de151472", kill_on_drop: false }` [INFO] [stdout] 6ebbc11d64c8001d11e4ff13fb37fe952244f22075ac2f7558574a96de151472