[INFO] fetching crate ws_stream_endpoint 0.1.0... [INFO] checking ws_stream_endpoint-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ws_stream_endpoint 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate ws_stream_endpoint 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ws_stream_endpoint 0.1.0 [INFO] finished tweaking crates.io crate ws_stream_endpoint 0.1.0 [INFO] tweaked toml for crates.io crate ws_stream_endpoint 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding bytes v0.4.12 (latest: v1.7.1) [INFO] [stderr] Adding futures v0.1.31 (latest: v0.3.30) [INFO] [stderr] Adding ringbuf v0.1.9 (latest: v0.4.4) [INFO] [stderr] Adding rustc_version v0.2.3 (latest: v0.4.1) [INFO] [stderr] Adding semver v0.9.0 (latest: v1.0.23) [INFO] [stderr] Adding semver-parser v0.7.0 (latest: v0.10.2) [INFO] [stderr] Adding tokio v0.1.22 (latest: v1.40.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1780989be95cee0d3d5066ffb3d8649b51b34ed5f97bb8dc9fc619439aa5951d [INFO] running `Command { std: "docker" "start" "-a" "1780989be95cee0d3d5066ffb3d8649b51b34ed5f97bb8dc9fc619439aa5951d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1780989be95cee0d3d5066ffb3d8649b51b34ed5f97bb8dc9fc619439aa5951d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1780989be95cee0d3d5066ffb3d8649b51b34ed5f97bb8dc9fc619439aa5951d", kill_on_drop: false }` [INFO] [stdout] 1780989be95cee0d3d5066ffb3d8649b51b34ed5f97bb8dc9fc619439aa5951d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7a5721a720d74f70a3fe0f4fa4250e481c1975a1803e64fe0dbc9b6e180f6fcf [INFO] running `Command { std: "docker" "start" "-a" "7a5721a720d74f70a3fe0f4fa4250e481c1975a1803e64fe0dbc9b6e180f6fcf", kill_on_drop: false }` [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling ringbuf v0.1.9 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking ws_stream_endpoint v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:55:4 [INFO] [stdout] | [INFO] [stdout] 40 | let ab_buf = RingBuffer::::new( a_buf ); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let ba_buf = RingBuffer::::new( b_buf ); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | let (ab_writer, ab_reader) = ab_buf.split(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let (ba_writer, ba_reader) = ba_buf.split(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | [INFO] [stdout] 46 | let a_rtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let a_wtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let b_rtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let b_wtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | let a_open = Arc::new(AtomicBool::new( true )); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let b_open = Arc::new(AtomicBool::new( true )); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | / Endpoint [INFO] [stdout] 56 | | { [INFO] [stdout] 57 | | name : "A_Server" , [INFO] [stdout] 58 | | writer : ab_writer , [INFO] [stdout] ... | [INFO] [stdout] 66 | | other_open : b_open.clone() , [INFO] [stdout] 67 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:69:4 [INFO] [stdout] | [INFO] [stdout] 40 | let ab_buf = RingBuffer::::new( a_buf ); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let ba_buf = RingBuffer::::new( b_buf ); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | let (ab_writer, ab_reader) = ab_buf.split(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let (ba_writer, ba_reader) = ba_buf.split(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | [INFO] [stdout] 46 | let a_rtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let a_wtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let b_rtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let b_wtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | let a_open = Arc::new(AtomicBool::new( true )); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let b_open = Arc::new(AtomicBool::new( true )); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | / Endpoint [INFO] [stdout] 70 | | { [INFO] [stdout] 71 | | name : "B_Client" , [INFO] [stdout] 72 | | writer : ba_writer , [INFO] [stdout] ... | [INFO] [stdout] 80 | | other_open : a_open.clone() , [INFO] [stdout] 81 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:55:4 [INFO] [stdout] | [INFO] [stdout] 40 | let ab_buf = RingBuffer::::new( a_buf ); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let ba_buf = RingBuffer::::new( b_buf ); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | let (ab_writer, ab_reader) = ab_buf.split(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let (ba_writer, ba_reader) = ba_buf.split(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | [INFO] [stdout] 46 | let a_rtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let a_wtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let b_rtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let b_wtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | let a_open = Arc::new(AtomicBool::new( true )); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let b_open = Arc::new(AtomicBool::new( true )); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | / Endpoint [INFO] [stdout] 56 | | { [INFO] [stdout] 57 | | name : "A_Server" , [INFO] [stdout] 58 | | writer : ab_writer , [INFO] [stdout] ... | [INFO] [stdout] 66 | | other_open : b_open.clone() , [INFO] [stdout] 67 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:69:4 [INFO] [stdout] | [INFO] [stdout] 40 | let ab_buf = RingBuffer::::new( a_buf ); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | let ba_buf = RingBuffer::::new( b_buf ); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | let (ab_writer, ab_reader) = ab_buf.split(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let (ba_writer, ba_reader) = ba_buf.split(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | [INFO] [stdout] 46 | let a_rtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let a_wtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let b_rtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let b_wtask = Arc::new(Mutex::new( None )); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | [INFO] [stdout] 51 | let a_open = Arc::new(AtomicBool::new( true )); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let b_open = Arc::new(AtomicBool::new( true )); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | / Endpoint [INFO] [stdout] 70 | | { [INFO] [stdout] 71 | | name : "B_Client" , [INFO] [stdout] 72 | | writer : ba_writer , [INFO] [stdout] ... | [INFO] [stdout] 80 | | other_open : a_open.clone() , [INFO] [stdout] 81 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ws_stream_endpoint` (lib test) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ws_stream_endpoint` (lib) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "7a5721a720d74f70a3fe0f4fa4250e481c1975a1803e64fe0dbc9b6e180f6fcf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a5721a720d74f70a3fe0f4fa4250e481c1975a1803e64fe0dbc9b6e180f6fcf", kill_on_drop: false }` [INFO] [stdout] 7a5721a720d74f70a3fe0f4fa4250e481c1975a1803e64fe0dbc9b6e180f6fcf