[INFO] fetching crate wrflib 0.0.3... [INFO] checking wrflib-0.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wrflib 0.0.3 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate wrflib 0.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wrflib 0.0.3 [INFO] finished tweaking crates.io crate wrflib 0.0.3 [INFO] tweaked toml for crates.io crate wrflib 0.0.3 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 109 packages to latest compatible versions [INFO] [stderr] Adding bindgen v0.59.2 (latest: v0.70.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding env_logger v0.9.3 (latest: v0.11.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding peeking_take_while v0.1.2 (latest: v1.0.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding which v4.4.2 (latest: v6.0.3) [INFO] [stderr] Adding widestring v0.4.3 (latest: v1.1.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e6996d2b2b61e61f8dcb978f38b8e2d1a3f399e4fa58b716cf17944a8defcb40 [INFO] running `Command { std: "docker" "start" "-a" "e6996d2b2b61e61f8dcb978f38b8e2d1a3f399e4fa58b716cf17944a8defcb40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6996d2b2b61e61f8dcb978f38b8e2d1a3f399e4fa58b716cf17944a8defcb40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6996d2b2b61e61f8dcb978f38b8e2d1a3f399e4fa58b716cf17944a8defcb40", kill_on_drop: false }` [INFO] [stdout] e6996d2b2b61e61f8dcb978f38b8e2d1a3f399e4fa58b716cf17944a8defcb40 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d7c66e73c4aa52711dbb3e4656dbf644fb19cdf77227387f43b468d61dc68fd3 [INFO] running `Command { std: "docker" "start" "-a" "d7c66e73c4aa52711dbb3e4656dbf644fb19cdf77227387f43b468d61dc68fd3", kill_on_drop: false }` [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling xml-rs v0.8.21 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Compiling wrflib_glx_sys v0.0.3 [INFO] [stderr] Compiling wrflib_x11_sys v0.0.3 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking wrflib_shader_compiler v0.0.3 [INFO] [stderr] Checking wrflib_vector v0.0.3 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking ureq v2.10.1 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking wrflib v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std_shader::*` [INFO] [stdout] --> src/lib.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | pub use std_shader::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `layout_api::*` [INFO] [stdout] --> src/lib.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | pub use layout_api::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `macros::*` [INFO] [stdout] --> src/lib.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | pub use macros::*; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std_shader::*` [INFO] [stdout] --> src/lib.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | pub use std_shader::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `layout_api::*` [INFO] [stdout] --> src/lib.rs:148:9 [INFO] [stdout] | [INFO] [stdout] 148 | pub use layout_api::*; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `macros::*` [INFO] [stdout] --> src/lib.rs:150:9 [INFO] [stdout] | [INFO] [stdout] 150 | pub use macros::*; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/fonts.rs:357:17 [INFO] [stdout] | [INFO] [stdout] 357 | let mut fonts_atlas = &mut cx.fonts_data.write().unwrap().fonts_atlas; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/fonts.rs:357:17 [INFO] [stdout] | [INFO] [stdout] 357 | let mut fonts_atlas = &mut cx.fonts_data.write().unwrap().fonts_atlas; [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fonts.rs:489:19 [INFO] [stdout] | [INFO] [stdout] 461 | let fonts_data_read_lock = fonts_data.read().unwrap(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 489 | (glyph_index, fonts_data.read().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry.rs:34:35 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(vertex_attributes: Vec, triangle_indices: Vec<[u32; 3]>) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Self { vertex_attributes: Box::new(vertex_attributes), triangle_indices } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shader.rs:321:90 [INFO] [stdout] | [INFO] [stdout] 321 | let gpu_geometry = shader.build_geom.map(|build_geom| GpuGeometry::new(self, (build_geom)())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fonts.rs:489:19 [INFO] [stdout] | [INFO] [stdout] 461 | let fonts_data_read_lock = fonts_data.read().unwrap(); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 489 | (glyph_index, fonts_data.read().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry.rs:34:35 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(vertex_attributes: Vec, triangle_indices: Vec<[u32; 3]>) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Self { vertex_attributes: Box::new(vertex_attributes), triangle_indices } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shader.rs:321:90 [INFO] [stdout] | [INFO] [stdout] 321 | let gpu_geometry = shader.build_geom.map(|build_geom| GpuGeometry::new(self, (build_geom)())); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wrflib` (lib) due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `wrflib` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d7c66e73c4aa52711dbb3e4656dbf644fb19cdf77227387f43b468d61dc68fd3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d7c66e73c4aa52711dbb3e4656dbf644fb19cdf77227387f43b468d61dc68fd3", kill_on_drop: false }` [INFO] [stdout] d7c66e73c4aa52711dbb3e4656dbf644fb19cdf77227387f43b468d61dc68fd3