[INFO] fetching crate wowsunpack 0.2.2... [INFO] checking wowsunpack-0.2.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate wowsunpack 0.2.2 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate wowsunpack 0.2.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate wowsunpack 0.2.2 [INFO] finished tweaking crates.io crate wowsunpack 0.2.2 [INFO] tweaked toml for crates.io crate wowsunpack 0.2.2 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate wowsunpack 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b1959e22b5ed9c5fbc2a2cec4ceee36622d5c94c5b5c8d4d2efa50bf1af70c0e [INFO] running `Command { std: "docker" "start" "-a" "b1959e22b5ed9c5fbc2a2cec4ceee36622d5c94c5b5c8d4d2efa50bf1af70c0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b1959e22b5ed9c5fbc2a2cec4ceee36622d5c94c5b5c8d4d2efa50bf1af70c0e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b1959e22b5ed9c5fbc2a2cec4ceee36622d5c94c5b5c8d4d2efa50bf1af70c0e", kill_on_drop: false }` [INFO] [stdout] b1959e22b5ed9c5fbc2a2cec4ceee36622d5c94c5b5c8d4d2efa50bf1af70c0e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7612d98c0cce283655c11bffc820b5cc9d9d55f4b0800d854a10637fb3314473 [INFO] running `Command { std: "docker" "start" "-a" "7612d98c0cce283655c11bffc820b5cc9d9d55f4b0800d854a10637fb3314473", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling binrw_derive v0.11.2 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling binrw v0.11.2 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking iter-read v0.3.1 [INFO] [stderr] Checking bytemuck v1.17.0 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking roxmltree v0.19.0 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking gettext v0.4.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling uuid v0.8.2 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling darling_core v0.11.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Compiling darling_macro v0.11.0 [INFO] [stderr] Compiling darling v0.11.0 [INFO] [stderr] Compiling variantly v0.4.0 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking pickled v1.2.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking wowsunpack v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/data/mod.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `io::Cursor` and `time::Instant` [INFO] [stdout] --> src/game_params/provider.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | io::Cursor, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 8 | time::Instant, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `flate2::read::ZlibDecoder` [INFO] [stdout] --> src/game_params/provider.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use flate2::read::ZlibDecoder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DeOptions` [INFO] [stdout] --> src/game_params/provider.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 15 | use pickled::{DeOptions, HashableValue, Value}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::Map` [INFO] [stdout] --> src/game_params/provider.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use serde_json::Map; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Version` [INFO] [stdout] --> src/game_params/provider.rs:21:85 [INFO] [stdout] | [INFO] [stdout] 21 | data::{idx::FileNode, pkg::PkgFileLoader, DataFileWithCallback, ResourceLoader, Version}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::PathBuf` [INFO] [stdout] --> src/data/mod.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::path::PathBuf; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `io::Cursor` and `time::Instant` [INFO] [stdout] --> src/game_params/provider.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | io::Cursor, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 8 | time::Instant, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `flate2::read::ZlibDecoder` [INFO] [stdout] --> src/game_params/provider.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use flate2::read::ZlibDecoder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `DeOptions` [INFO] [stdout] --> src/game_params/provider.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 15 | use pickled::{DeOptions, HashableValue, Value}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::Map` [INFO] [stdout] --> src/game_params/provider.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use serde_json::Map; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Version` [INFO] [stdout] --> src/game_params/provider.rs:21:85 [INFO] [stdout] | [INFO] [stdout] 21 | data::{idx::FileNode, pkg::PkgFileLoader, DataFileWithCallback, ResourceLoader, Version}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/data/idx.rs:6:24 [INFO] [stdout] | [INFO] [stdout] 6 | io::{self, Cursor, Read, SeekFrom, Write}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/data/pkg.rs:4:24 [INFO] [stdout] | [INFO] [stdout] 4 | io::{self, Cursor, Read, Write}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/data/idx.rs:6:24 [INFO] [stdout] | [INFO] [stdout] 6 | io::{self, Cursor, Read, SeekFrom, Write}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/data/pkg.rs:4:24 [INFO] [stdout] | [INFO] [stdout] 4 | io::{self, Cursor, Read, Write}, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rpc/entitydefs.rs:367:13 [INFO] [stdout] | [INFO] [stdout] 367 | let mut internal_properties: Vec<_> = properties [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rpc/entitydefs.rs:380:13 [INFO] [stdout] | [INFO] [stdout] 380 | let mut base_properties: Vec<_> = properties [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rpc/entitydefs.rs:367:13 [INFO] [stdout] | [INFO] [stdout] 367 | let mut internal_properties: Vec<_> = properties [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rpc/entitydefs.rs:380:13 [INFO] [stdout] | [INFO] [stdout] 380 | let mut base_properties: Vec<_> = properties [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/rpc/typedefs.rs:655:13 [INFO] [stdout] | [INFO] [stdout] 655 | let mut aliases = HashMap::new(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `resources_meta_offset` and `resources_metadata` are never read [INFO] [stdout] --> src/data/idx.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 37 | pub struct IdxFile { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 38 | /// The offset at which parsing began for this structure [INFO] [stdout] 39 | resources_meta_offset: PosValue<()>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 40 | /// Metadata describing resource/file/volume tables [INFO] [stdout] 41 | resources_metadata: ResourceMetadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `IdxFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `murmur_hash` is never read [INFO] [stdout] --> src/data/idx.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 55 | struct Header { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 59 | murmur_hash: u32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `unused` is never read [INFO] [stdout] --> src/data/idx.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 65 | struct ResourceMetadata { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 72 | unused: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ResourceMetadata` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `this_offset`, `resource_ptr`, and `filename_ptr` are never read [INFO] [stdout] --> src/data/idx.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 81 | pub struct PackedFileMetadata { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 82 | /// This struct's offset in the IDX file it was read from [INFO] [stdout] 83 | this_offset: PosValue<()>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 86 | resource_ptr: u64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 89 | filename_ptr: u64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PackedFileMetadata` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `this_offset` is never read [INFO] [stdout] --> src/data/idx.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 122 | pub struct Volume { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 123 | this_offset: PosValue<()>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Volume` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `build_skill_modifiers` is never used [INFO] [stdout] --> src/game_params/provider.rs:161:4 [INFO] [stdout] | [INFO] [stdout] 161 | fn build_skill_modifiers( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/idx.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 227 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | self.find(path)?.read_file(pkg_loader, out_data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/idx.rs:263:35 [INFO] [stdout] | [INFO] [stdout] 263 | .map(|p| FileNode(p.0.upgrade().expect("failed to get parent node"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/idx.rs:416:37 [INFO] [stdout] | [INFO] [stdout] 416 | .and_then(|parent| Some(FileNode(parent.0.upgrade()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/idx.rs:450:5 [INFO] [stdout] | [INFO] [stdout] 450 | IdxFile::read_ne(data).map_err(IdxError::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/pkg.rs:37:19 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new>(pkgs_dir: P) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | pkgs: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:126:19 [INFO] [stdout] | [INFO] [stdout] 124 | fn from(x: serde_json::Error) -> Error { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Error { [INFO] [stdout] 126 | kind: x.into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:135:23 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn failure_from_kind(kind: ErrorKind) -> nom::Err { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | nom::Err::Failure(Error { [INFO] [stdout] | _______________________^ [INFO] [stdout] 136 | | kind: kind.into(), [INFO] [stdout] 137 | | backtrace: vec![], [INFO] [stdout] 138 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game_params/convert.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 124 | let mut decoder = ZlibDecoder::new(Cursor::new(game_params_data)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | / pickled::from_reader( [INFO] [stdout] 129 | | &mut decompressed_data, [INFO] [stdout] 130 | | DeOptions::default() [INFO] [stdout] 131 | | .replace_unresolved_globals() [INFO] [stdout] 132 | | .decode_strings(), [INFO] [stdout] 133 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game_params/provider.rs:718:12 [INFO] [stdout] | [INFO] [stdout] 716 | let specs = Arc::new(parse_scripts(&data_file_loader).unwrap()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 717 | [INFO] [stdout] 718 | Ok(GameMetadataProvider { [INFO] [stdout] | ____________^ [INFO] [stdout] 719 | | params: params.into(), [INFO] [stdout] 720 | | param_id_to_translation_id, [INFO] [stdout] 721 | | translations: None, [INFO] [stdout] 722 | | specs, [INFO] [stdout] 723 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `resources_meta_offset` and `resources_metadata` are never read [INFO] [stdout] --> src/data/idx.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 37 | pub struct IdxFile { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 38 | /// The offset at which parsing began for this structure [INFO] [stdout] 39 | resources_meta_offset: PosValue<()>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 40 | /// Metadata describing resource/file/volume tables [INFO] [stdout] 41 | resources_metadata: ResourceMetadata, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `IdxFile` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wowsunpack` (lib test) due to 10 previous errors; 17 warnings emitted [INFO] [stdout] warning: field `murmur_hash` is never read [INFO] [stdout] --> src/data/idx.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 55 | struct Header { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 59 | murmur_hash: u32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `unused` is never read [INFO] [stdout] --> src/data/idx.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 65 | struct ResourceMetadata { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 72 | unused: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ResourceMetadata` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `this_offset`, `resource_ptr`, and `filename_ptr` are never read [INFO] [stdout] --> src/data/idx.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 81 | pub struct PackedFileMetadata { [INFO] [stdout] | ------------------ fields in this struct [INFO] [stdout] 82 | /// This struct's offset in the IDX file it was read from [INFO] [stdout] 83 | this_offset: PosValue<()>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 86 | resource_ptr: u64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 89 | filename_ptr: u64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PackedFileMetadata` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `this_offset` is never read [INFO] [stdout] --> src/data/idx.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 122 | pub struct Volume { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 123 | this_offset: PosValue<()>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Volume` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `build_skill_modifiers` is never used [INFO] [stdout] --> src/game_params/provider.rs:161:4 [INFO] [stdout] | [INFO] [stdout] 161 | fn build_skill_modifiers( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/idx.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 227 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 231 | self.find(path)?.read_file(pkg_loader, out_data) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/idx.rs:263:35 [INFO] [stdout] | [INFO] [stdout] 263 | .map(|p| FileNode(p.0.upgrade().expect("failed to get parent node"))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/idx.rs:416:37 [INFO] [stdout] | [INFO] [stdout] 416 | .and_then(|parent| Some(FileNode(parent.0.upgrade()?))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/idx.rs:450:5 [INFO] [stdout] | [INFO] [stdout] 450 | IdxFile::read_ne(data).map_err(IdxError::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/pkg.rs:37:19 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn new>(pkgs_dir: P) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | pkgs: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:126:19 [INFO] [stdout] | [INFO] [stdout] 124 | fn from(x: serde_json::Error) -> Error { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | Error { [INFO] [stdout] 126 | kind: x.into(), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:135:23 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn failure_from_kind(kind: ErrorKind) -> nom::Err { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | nom::Err::Failure(Error { [INFO] [stdout] | _______________________^ [INFO] [stdout] 136 | | kind: kind.into(), [INFO] [stdout] 137 | | backtrace: vec![], [INFO] [stdout] 138 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game_params/convert.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 124 | let mut decoder = ZlibDecoder::new(Cursor::new(game_params_data)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | / pickled::from_reader( [INFO] [stdout] 129 | | &mut decompressed_data, [INFO] [stdout] 130 | | DeOptions::default() [INFO] [stdout] 131 | | .replace_unresolved_globals() [INFO] [stdout] 132 | | .decode_strings(), [INFO] [stdout] 133 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game_params/provider.rs:718:12 [INFO] [stdout] | [INFO] [stdout] 716 | let specs = Arc::new(parse_scripts(&data_file_loader).unwrap()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 717 | [INFO] [stdout] 718 | Ok(GameMetadataProvider { [INFO] [stdout] | ____________^ [INFO] [stdout] 719 | | params: params.into(), [INFO] [stdout] 720 | | param_id_to_translation_id, [INFO] [stdout] 721 | | translations: None, [INFO] [stdout] 722 | | specs, [INFO] [stdout] 723 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wowsunpack` (lib) due to 10 previous errors; 16 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7612d98c0cce283655c11bffc820b5cc9d9d55f4b0800d854a10637fb3314473", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7612d98c0cce283655c11bffc820b5cc9d9d55f4b0800d854a10637fb3314473", kill_on_drop: false }` [INFO] [stdout] 7612d98c0cce283655c11bffc820b5cc9d9d55f4b0800d854a10637fb3314473